You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Adar Dembo (Code Review)" <ge...@cloudera.org> on 2016/08/16 18:12:25 UTC
[kudu-CR] mini cluster: avoid SIGSEGV when master fails to start up
Hello Todd Lipcon,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/4006
to review the following change.
Change subject: mini_cluster: avoid SIGSEGV when master fails to start up
......................................................................
mini_cluster: avoid SIGSEGV when master fails to start up
My machine's clock became desynchronized causing MiniCluster-based tests to
SIGSEGV. The root cause appears to be in how we manage the mini_masters_
vector. By resizing it right at the beginning, various code paths later on
may iterate on some number of non-existent masters and dereference empty
shared pointers.
Change-Id: Id1cc262ba83f70d97434fca4c75f76b095db77d6
---
M src/kudu/integration-tests/mini_cluster.cc
1 file changed, 5 insertions(+), 9 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/06/4006/1
--
To view, visit http://gerrit.cloudera.org:8080/4006
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id1cc262ba83f70d97434fca4c75f76b095db77d6
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] mini cluster: avoid SIGSEGV when master fails to start up
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.
Change subject: mini_cluster: avoid SIGSEGV when master fails to start up
......................................................................
Patch Set 1:
Build Started http://104.196.14.100/job/kudu-gerrit/2949/
--
To view, visit http://gerrit.cloudera.org:8080/4006
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1cc262ba83f70d97434fca4c75f76b095db77d6
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] mini cluster: avoid SIGSEGV when master fails to start up
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: mini_cluster: avoid SIGSEGV when master fails to start up
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/4006
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1cc262ba83f70d97434fca4c75f76b095db77d6
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] mini cluster: avoid SIGSEGV when master fails to start up
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged.
Change subject: mini_cluster: avoid SIGSEGV when master fails to start up
......................................................................
mini_cluster: avoid SIGSEGV when master fails to start up
My machine's clock became desynchronized causing MiniCluster-based tests to
SIGSEGV. The root cause appears to be in how we manage the mini_masters_
vector. By resizing it right at the beginning, various code paths later on
may iterate on some number of non-existent masters and dereference empty
shared pointers.
Change-Id: Id1cc262ba83f70d97434fca4c75f76b095db77d6
Reviewed-on: http://gerrit.cloudera.org:8080/4006
Tested-by: Kudu Jenkins
Reviewed-by: Todd Lipcon <to...@apache.org>
---
M src/kudu/integration-tests/mini_cluster.cc
1 file changed, 5 insertions(+), 9 deletions(-)
Approvals:
Todd Lipcon: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/4006
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id1cc262ba83f70d97434fca4c75f76b095db77d6
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>