You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/06/08 06:58:55 UTC

[GitHub] [shardingsphere] xuelijun-dev opened a new pull request, #18237: properties spring.shardingsphere.enable docs supplement

xuelijun-dev opened a new pull request, #18237:
URL: https://github.com/apache/shardingsphere/pull/18237

   Changes proposed in this pull request:
   -docs/document/content/user-manual/shardingsphere-jdbc/spring-boot-starter/data-source.cn.md
   -docs/document/content/user-manual/shardingsphere-jdbc/spring-boot-starter/data-source.en.md
   -docs/document/content/user-manual/shardingsphere-jdbc/spring-boot-starter/rules/sharding.cn.md
   -docs/document/content/user-manual/shardingsphere-jdbc/spring-boot-starter/rules/sharding.en.md
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] zjcnb commented on a diff in pull request #18237: properties spring.shardingsphere.enable docs supplement

Posted by GitBox <gi...@apache.org>.
zjcnb commented on code in PR #18237:
URL: https://github.com/apache/shardingsphere/pull/18237#discussion_r893410832


##########
docs/document/content/user-manual/shardingsphere-jdbc/spring-boot-starter/data-source.en.md:
##########
@@ -9,6 +9,7 @@ chapter = true
 ### Configuration Item Explanation
 
 ```properties
+spring.shardingsphere.enabled= # Whether enable shardingsphere or not, default value: true

Review Comment:
   > I think should be remove this about this configuration :
   > 
   > ```
   >     {
   >       "name": "spring.shardingsphere.enabled",
   >       "type": "java.lang.Boolean",
   >       "description": "Whether enable shardingsphere or not.",
   >       "defaultValue": true
   >     }
   > ```
   > 
   > It 's from additional-spring-configuration-metadata.json in `shardingsphere-jdbc-core-spring-boot-starter` module.
   
   After testing, it seems that it is a feature of springboot. If `ShardingSphere` do not provide configuration, it can still take effect. So, i think we can remove it? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] terrymanu commented on a diff in pull request #18237: properties spring.shardingsphere.enable docs supplement

Posted by GitBox <gi...@apache.org>.
terrymanu commented on code in PR #18237:
URL: https://github.com/apache/shardingsphere/pull/18237#discussion_r893149792


##########
docs/document/content/user-manual/shardingsphere-jdbc/spring-boot-starter/data-source.en.md:
##########
@@ -9,6 +9,7 @@ chapter = true
 ### Configuration Item Explanation
 
 ```properties
+spring.shardingsphere.enabled= # Whether enable shardingsphere or not, default value: true

Review Comment:
   Does the configuration come from ShardingSphere?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] xuelijun-dev commented on a diff in pull request #18237: properties spring.shardingsphere.enable docs supplement

Posted by GitBox <gi...@apache.org>.
xuelijun-dev commented on code in PR #18237:
URL: https://github.com/apache/shardingsphere/pull/18237#discussion_r893527714


##########
docs/document/content/user-manual/shardingsphere-jdbc/spring-boot-starter/data-source.en.md:
##########
@@ -9,6 +9,7 @@ chapter = true
 ### Configuration Item Explanation
 
 ```properties
+spring.shardingsphere.enabled= # Whether enable shardingsphere or not, default value: true

Review Comment:
   It can flexibly turn on or off the use of shardingsphere



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] zjcnb closed pull request #18237: properties spring.shardingsphere.enable docs supplement

Posted by GitBox <gi...@apache.org>.
zjcnb closed pull request #18237: properties spring.shardingsphere.enable docs supplement
URL: https://github.com/apache/shardingsphere/pull/18237


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] zjcnb commented on a diff in pull request #18237: properties spring.shardingsphere.enable docs supplement

Posted by GitBox <gi...@apache.org>.
zjcnb commented on code in PR #18237:
URL: https://github.com/apache/shardingsphere/pull/18237#discussion_r893265798


##########
docs/document/content/user-manual/shardingsphere-jdbc/spring-boot-starter/data-source.en.md:
##########
@@ -9,6 +9,7 @@ chapter = true
 ### Configuration Item Explanation
 
 ```properties
+spring.shardingsphere.enabled= # Whether enable shardingsphere or not, default value: true

Review Comment:
   I think should be remove this about this configuration :
   
   ```
       {
         "name": "spring.shardingsphere.enabled",
         "type": "java.lang.Boolean",
         "description": "Whether enable shardingsphere or not.",
         "defaultValue": true
       }
   ```
   
   It 's from additional-spring-configuration-metadata.json in `shardingsphere-jdbc-core-spring-boot-starter` module.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] zjcnb commented on pull request #18237: properties spring.shardingsphere.enable docs supplement

Posted by GitBox <gi...@apache.org>.
zjcnb commented on PR #18237:
URL: https://github.com/apache/shardingsphere/pull/18237#issuecomment-1153162113

   Hi, I think we don't need this configuration, so i removed this configuration item refer to #18316. So i closed this pull request. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] xuelijun-dev commented on a diff in pull request #18237: properties spring.shardingsphere.enable docs supplement

Posted by GitBox <gi...@apache.org>.
xuelijun-dev commented on code in PR #18237:
URL: https://github.com/apache/shardingsphere/pull/18237#discussion_r893517691


##########
docs/document/content/user-manual/shardingsphere-jdbc/spring-boot-starter/data-source.en.md:
##########
@@ -9,6 +9,7 @@ chapter = true
 ### Configuration Item Explanation
 
 ```properties
+spring.shardingsphere.enabled= # Whether enable shardingsphere or not, default value: true

Review Comment:
   It is recommended to keep this configuration



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] xuelijun-dev commented on a diff in pull request #18237: properties spring.shardingsphere.enable docs supplement

Posted by GitBox <gi...@apache.org>.
xuelijun-dev commented on code in PR #18237:
URL: https://github.com/apache/shardingsphere/pull/18237#discussion_r893237356


##########
docs/document/content/user-manual/shardingsphere-jdbc/spring-boot-starter/data-source.en.md:
##########
@@ -9,6 +9,7 @@ chapter = true
 ### Configuration Item Explanation
 
 ```properties
+spring.shardingsphere.enabled= # Whether enable shardingsphere or not, default value: true

Review Comment:
   yes,this config properties from ShardingSphereAutoConfiguration file



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org