You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "zxs1633079383 (via GitHub)" <gi...@apache.org> on 2025/12/02 12:15:47 UTC
[PR] fix(pg): complete PostgreSQL custom type & VARBIT support with full test coverage (includes #37216) [shardingsphere]
zxs1633079383 opened a new pull request, #37259:
URL: https://github.com/apache/shardingsphere/pull/37259
Fixes #36978.
This PR is the complete version of the PostgreSQL custom type / VARBIT fix.
It contains:
1. All functional changes from PR #37216
(PostgreSQL extended protocol fixes, typeName propagation,
UDT/enum/domain handling, VARBIT support, JSONB consistency, etc.)
2. Full updates to unit tests and E2E tests
to ensure that the entire build passes CI, including:
- typeName propagation across metadata / binder / prepared statement
- extended-protocol Parse → Describe → Bind → Execute test cases
- adjustments to affected SQL parsing, metadata and YAML tests
- spotless & checkstyle compliance
- E2E pipelines for MySQL / MariaDB / PostgreSQL
3. All checks pass locally:
- `./mvnw spotless:apply -Pcheck`
- `./mvnw clean install -B -T1C -Pcheck`
Changes proposed in this pull request:
- Restore correct JSON/JSONB OIDs (114 / 3802)
- Add VARBIT / BIT VARYING value parser and metadata support
- Propagate typeName across ColumnMetaData → ShardingSphereColumn → binder
- Resolve PostgreSQL parameter type & typeName during Describe phase
- Construct PGobject safely in Bind phase with fallback typeName
- Remove mutable enum state and avoid cross-statement leakage
- Update all relevant unit tests and E2E cases to match new behavior
---
Before committing this PR, I'm sure that I have checked the following options:
- [x] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [x] I have self-reviewed the commit code.
- [x] I have (or in comment I request) added corresponding labels for the pull request.
- [x] I have passed maven check locally :
`./mvnw spotless:apply -Pcheck`
`./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [ ] I have made corresponding changes to the documentation.
- [x] I have added corresponding unit tests for my changes.
- [x] I have updated the Release Notes of the current development version.
This PR aims to provide a stable, fully tested version of the PostgreSQL custom
type implementation, and I am happy to address any additional comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(pg): complete PostgreSQL custom type & VARBIT support with full test coverage (includes #37216) [shardingsphere]
Posted by "zxs1633079383 (via GitHub)" <gi...@apache.org>.
zxs1633079383 commented on PR #37259:
URL: https://github.com/apache/shardingsphere/pull/37259#issuecomment-3607032709
1. About the scope issue you mentioned
Just to confirm my understanding:
Are you mainly referring to the commit history containing mixed or unrelated commits, rather than the actual file changes in this PR?If so, I can reorganize or squash the commits to ensure the PR history is clean and strictly focused on UDT-related changes.
Please let me know your preferred approach — I’m happy to adjust or split the PR if needed.
2. Mutable enum state
The previous withTypeName() usage has already been fully removed.
No enum mutation remains, and the typeName pipeline is now completely stateless and thread-safe.
3. Types.OTHER / JSONB behavior
Current behavior:
UDTs remain Types.OTHER in metadata
JSON → "json"
JSONB → "jsonb"
JSON / JSONB bypass UDT logic
Other Types.OTHER use normal fallback
No UDT_GENERIC mapping in the current PR
Bind phase only uses typeName to construct PGobject
I will add focused tests to validate JSON / JSONB / UDT / non-UDT behavior.
4. UDT discovery
I will improve UDT loading with:
an enable/disable option
optional caching , and more in the future.
and add tests for protocol behavior.
5. Tests
I will add the missing tests for:
UDT bind/describe/execute
JSON / JSONB
non-UDT Types.OTHER
minimal reproducible scenarios
Thanks again for your time and guidance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(pg): complete PostgreSQL custom type & VARBIT support with full test coverage (includes #37216) [shardingsphere]
Posted by "zxs1633079383 (via GitHub)" <gi...@apache.org>.
zxs1633079383 commented on PR #37259:
URL: https://github.com/apache/shardingsphere/pull/37259#issuecomment-3728284816
Hi @terrymanu ,
Thank you again for your guidance. I would like to provide an update regarding this PR:
Scope / commit history
This PR is focused strictly on UDT-related changes. Unrelated commits (e.g., checkstyle config reformatting, sample YAML) have been avoided.
Please let me know if you prefer me to squash or reorganize the commits further.
Mutable enum state
The previous withTypeName() usage has been fully removed.
No enum mutation remains; the typeName pipeline is now completely stateless and thread-safe.
Types.OTHER / JSON / JSONB behavior
Current behavior:
UDTs remain Types.OTHER in metadata.
JSON → "json"
JSONB → "jsonb"
JSON / JSONB bypass UDT logic.
Other Types.OTHER uses normal fallback.
No UDT_GENERIC mapping is included in this PR.
UDT discovery
UDT scanning improvements included:
Enable/disable option
Optional caching
Protocol behavior handling
The updates clarify scope/configuration and improve UDT handling without extra catalog queries.
Tests
All missing tests for UDT bind/describe/execute, JSON / JSONB, and non-UDT Types.OTHER have now been added.
Minimal reproducible scenarios are included.
Checkstyle / CI considerations
Due to recent changes in checkstyle.xml, many legacy files now violate the updated rules.
Running ./mvnw spotless:apply -Pcheck currently produces 700+ violations in a single module, which blocks automatic formatting.
All functional tests pass successfully with ./mvnw clean install.
For CI, please advise if there are any additional build or verification steps you would like me to include before merging.
Thanks again for your time and guidance.
<img width="1826" height="614" alt="image" src="https://github.com/user-attachments/assets/34b3b533-5a02-4c16-a8e4-71ae2334d24c" />
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(pg): complete PostgreSQL custom type & VARBIT support with full test coverage (includes #37216) [shardingsphere]
Posted by "zxs1633079383 (via GitHub)" <gi...@apache.org>.
zxs1633079383 commented on PR #37259:
URL: https://github.com/apache/shardingsphere/pull/37259#issuecomment-3602781705
Hi @yx9o
I’ve updated the PR and fixed all Checkstyle violations.
The code now passes the Checkstyle check locally.
Could you please rerun the CI pipeline to verify the latest changes?
Thanks a lot for your time and support.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(pg): complete PostgreSQL custom type & VARBIT support with full test coverage (includes #37216) [shardingsphere]
Posted by "fatekingsama (via GitHub)" <gi...@apache.org>.
fatekingsama commented on PR #37259:
URL: https://github.com/apache/shardingsphere/pull/37259#issuecomment-3722765741
Hi folks, any update on this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(pg): complete PostgreSQL custom type & VARBIT support with full test coverage (includes #37216) [shardingsphere]
Posted by "zxs1633079383 (via GitHub)" <gi...@apache.org>.
zxs1633079383 commented on code in PR #37259:
URL: https://github.com/apache/shardingsphere/pull/37259#discussion_r2581645833
##########
proxy/frontend/dialect/postgresql/src/main/java/org/apache/shardingsphere/proxy/frontend/postgresql/command/query/extended/PostgreSQLServerPreparedStatement.java:
##########
@@ -48,6 +48,8 @@ public final class PostgreSQLServerPreparedStatement implements ServerPreparedSt
private final List<PostgreSQLColumnType> parameterTypes;
+ private final List<String> parameterTypeNames;
Review Comment:
He's now assigning values to parameterTypes in the same way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(pg): complete PostgreSQL custom type & VARBIT support with full test coverage (includes #37216) [shardingsphere]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #37259:
URL: https://github.com/apache/shardingsphere/pull/37259#discussion_r2581455349
##########
test/it/rewriter/src/test/java/org/apache/shardingsphere/test/it/rewriter/engine/scenario/MixSQLRewriterIT.java:
##########
@@ -39,21 +39,21 @@ class MixSQLRewriterIT extends SQLRewriterIT {
protected Collection<ShardingSphereSchema> mockSchemas(final String schemaName) {
Collection<ShardingSphereTable> tables = new LinkedList<>();
tables.add(new ShardingSphereTable("t_account", Arrays.asList(
- new ShardingSphereColumn("account_id", Types.INTEGER, true, true, false, true, false, false),
- new ShardingSphereColumn("password", Types.VARCHAR, false, false, false, true, false, false),
- new ShardingSphereColumn("amount", Types.DECIMAL, false, false, false, true, false, false),
- new ShardingSphereColumn("status", Types.TINYINT, false, false, false, false, false, false)),
+ new ShardingSphereColumn("account_id", Types.INTEGER, true, true, "int", false, true, false, false),
+ new ShardingSphereColumn("password", Types.VARCHAR, false, false, "varchar", false, true, false, false),
+ new ShardingSphereColumn("amount", Types.DECIMAL, false, false, "decimal", false, true, false, false),
+ new ShardingSphereColumn("status", Types.TINYINT, false, false, "int", false, false, false, false)),
Review Comment:
Incorrect typeName for `status` column. The column has type `Types.TINYINT` but typeName is set to `"int"`. It should be `"tinyint"` to match the data type.
##########
infra/executor/src/test/java/org/apache/shardingsphere/infra/executor/sql/context/ExecutionContextBuilderTest.java:
##########
@@ -131,26 +131,26 @@ void assertBuildRouteSQLRewriteResultWithEmptyPrimaryKeyMeta() {
private Collection<ShardingSphereSchema> buildSchemas() {
Collection<ShardingSphereTable> tables = new LinkedList<>();
- tables.add(new ShardingSphereTable("logicName1", Arrays.asList(new ShardingSphereColumn("order_id", Types.INTEGER, true, false, false, true, false, false),
- new ShardingSphereColumn("user_id", Types.INTEGER, false, false, false, true, false, false),
- new ShardingSphereColumn("status", Types.INTEGER, false, false, false, true, false, false)), Collections.emptySet(), Collections.emptyList()));
- tables.add(new ShardingSphereTable("logicName2", Arrays.asList(new ShardingSphereColumn("item_id", Types.INTEGER, true, false, false, true, false, false),
- new ShardingSphereColumn("order_id", Types.INTEGER, false, false, false, true, false, false),
- new ShardingSphereColumn("user_id", Types.INTEGER, false, false, false, true, false, false),
- new ShardingSphereColumn("status", Types.VARCHAR, false, false, false, true, false, false),
- new ShardingSphereColumn("c_date", Types.TIMESTAMP, false, false, false, true, false, false)), Collections.emptySet(), Collections.emptyList()));
+ tables.add(new ShardingSphereTable("logicName1", Arrays.asList(new ShardingSphereColumn("order_id", Types.INTEGER, true, false, "int", false, true, false, false),
+ new ShardingSphereColumn("user_id", Types.INTEGER, false, false, "int", false, true, false, false),
+ new ShardingSphereColumn("status", Types.INTEGER, false, false, "int", false, true, false, false)), Collections.emptySet(), Collections.emptyList()));
+ tables.add(new ShardingSphereTable("logicName2", Arrays.asList(new ShardingSphereColumn("item_id", Types.INTEGER, true, false, "int", false, true, false, false),
+ new ShardingSphereColumn("order_id", Types.INTEGER, false, false, "int", false, true, false, false),
+ new ShardingSphereColumn("user_id", Types.INTEGER, false, false, "int", false, true, false, false),
+ new ShardingSphereColumn("status", Types.VARCHAR, false, false, "int", false, true, false, false),
+ new ShardingSphereColumn("c_date", Types.TIMESTAMP, false, false, "int", false, true, false, false)), Collections.emptySet(), Collections.emptyList()));
Review Comment:
Incorrect typeName for `c_date` column. The column has type `Types.TIMESTAMP` but typeName is set to `"int"`. It should be `"timestamp"` to match the data type.
##########
kernel/sql-federation/compiler/src/test/java/org/apache/shardingsphere/sqlfederation/compiler/compiler/it/SQLStatementCompilerIT.java:
##########
@@ -96,145 +96,145 @@ private Collection<SqlOperatorTable> getOperatorTables() {
}
private ShardingSphereTable createOrderFederationTableMetaData() {
- ShardingSphereColumn orderIdColumn = new ShardingSphereColumn("order_id", Types.VARCHAR, true, false, false, true, false, false);
- ShardingSphereColumn userIdColumn = new ShardingSphereColumn("user_id", Types.VARCHAR, false, false, false, true, false, false);
- ShardingSphereColumn statusColumn = new ShardingSphereColumn("status", Types.VARCHAR, false, false, false, true, false, false);
+ ShardingSphereColumn orderIdColumn = new ShardingSphereColumn("order_id", Types.VARCHAR, true, false, "varchar", false, true, false, false);
+ ShardingSphereColumn userIdColumn = new ShardingSphereColumn("user_id", Types.VARCHAR, false, false, "varchar", false, true, false, false);
+ ShardingSphereColumn statusColumn = new ShardingSphereColumn("status", Types.VARCHAR, false, false, "varchar", false, true, false, false);
return new ShardingSphereTable("t_order_federate", Arrays.asList(orderIdColumn, userIdColumn, statusColumn), Collections.emptyList(), Collections.emptyList());
}
private ShardingSphereTable createUserInfoTableMetaData() {
- ShardingSphereColumn userIdColumn = new ShardingSphereColumn("user_id", Types.VARCHAR, true, false, false, true, false, false);
- ShardingSphereColumn informationColumn = new ShardingSphereColumn("information", Types.VARCHAR, false, false, false, true, false, false);
+ ShardingSphereColumn userIdColumn = new ShardingSphereColumn("user_id", Types.VARCHAR, true, false, "varchar", false, true, false, false);
+ ShardingSphereColumn informationColumn = new ShardingSphereColumn("information", Types.VARCHAR, false, false, "varchar", false, true, false, false);
return new ShardingSphereTable("t_user_info", Arrays.asList(userIdColumn, informationColumn), Collections.emptyList(), Collections.emptyList());
}
private ShardingSphereTable createTOrderTableMetaData() {
- ShardingSphereColumn orderIdColumn = new ShardingSphereColumn("order_id", Types.BIGINT, true, false, false, true, false, false);
- ShardingSphereColumn userIdColumn = new ShardingSphereColumn("user_id", Types.INTEGER, false, false, false, true, false, false);
- ShardingSphereColumn statusColumn = new ShardingSphereColumn("status", Types.VARCHAR, false, false, false, true, false, false);
- ShardingSphereColumn merchantIdColumn = new ShardingSphereColumn("merchant_id", Types.INTEGER, false, false, false, true, false, false);
- ShardingSphereColumn remarkColumn = new ShardingSphereColumn("remark", Types.VARCHAR, false, false, false, true, false, false);
- ShardingSphereColumn creationDateColumn = new ShardingSphereColumn("creation_date", Types.DATE, false, false, false, true, false, false);
+ ShardingSphereColumn orderIdColumn = new ShardingSphereColumn("order_id", Types.BIGINT, true, false, "bigint", false, true, false, false);
+ ShardingSphereColumn userIdColumn = new ShardingSphereColumn("user_id", Types.INTEGER, false, false, "varchar", false, true, false, false);
Review Comment:
Incorrect typeName for `user_id` column. The column has type `Types.INTEGER` but typeName is set to `"varchar"`. It should be `"int"` to match the data type.
##########
proxy/frontend/dialect/postgresql/src/main/java/org/apache/shardingsphere/proxy/frontend/postgresql/command/query/extended/PostgreSQLServerPreparedStatement.java:
##########
@@ -48,6 +48,8 @@ public final class PostgreSQLServerPreparedStatement implements ServerPreparedSt
private final List<PostgreSQLColumnType> parameterTypes;
+ private final List<String> parameterTypeNames;
Review Comment:
getParameterTypeNames exposes the internal representation stored in field parameterTypeNames. The value may be modified [after this call to getParameterTypeNames](1).
getParameterTypeNames exposes the internal representation stored in field parameterTypeNames. The value may be modified [after this call to getParameterTypeNames](2).
##########
infra/executor/src/test/java/org/apache/shardingsphere/infra/executor/sql/context/ExecutionContextBuilderTest.java:
##########
@@ -131,26 +131,26 @@ void assertBuildRouteSQLRewriteResultWithEmptyPrimaryKeyMeta() {
private Collection<ShardingSphereSchema> buildSchemas() {
Collection<ShardingSphereTable> tables = new LinkedList<>();
- tables.add(new ShardingSphereTable("logicName1", Arrays.asList(new ShardingSphereColumn("order_id", Types.INTEGER, true, false, false, true, false, false),
- new ShardingSphereColumn("user_id", Types.INTEGER, false, false, false, true, false, false),
- new ShardingSphereColumn("status", Types.INTEGER, false, false, false, true, false, false)), Collections.emptySet(), Collections.emptyList()));
- tables.add(new ShardingSphereTable("logicName2", Arrays.asList(new ShardingSphereColumn("item_id", Types.INTEGER, true, false, false, true, false, false),
- new ShardingSphereColumn("order_id", Types.INTEGER, false, false, false, true, false, false),
- new ShardingSphereColumn("user_id", Types.INTEGER, false, false, false, true, false, false),
- new ShardingSphereColumn("status", Types.VARCHAR, false, false, false, true, false, false),
- new ShardingSphereColumn("c_date", Types.TIMESTAMP, false, false, false, true, false, false)), Collections.emptySet(), Collections.emptyList()));
+ tables.add(new ShardingSphereTable("logicName1", Arrays.asList(new ShardingSphereColumn("order_id", Types.INTEGER, true, false, "int", false, true, false, false),
+ new ShardingSphereColumn("user_id", Types.INTEGER, false, false, "int", false, true, false, false),
+ new ShardingSphereColumn("status", Types.INTEGER, false, false, "int", false, true, false, false)), Collections.emptySet(), Collections.emptyList()));
+ tables.add(new ShardingSphereTable("logicName2", Arrays.asList(new ShardingSphereColumn("item_id", Types.INTEGER, true, false, "int", false, true, false, false),
+ new ShardingSphereColumn("order_id", Types.INTEGER, false, false, "int", false, true, false, false),
+ new ShardingSphereColumn("user_id", Types.INTEGER, false, false, "int", false, true, false, false),
+ new ShardingSphereColumn("status", Types.VARCHAR, false, false, "int", false, true, false, false),
Review Comment:
Incorrect typeName for `status` column. The column has type `Types.VARCHAR` but typeName is set to `"int"`. It should be `"varchar"` to match the data type.
##########
infra/binder/core/src/test/java/org/apache/shardingsphere/infra/binder/engine/segment/dml/from/type/SimpleTableSegmentBinderTest.java:
##########
@@ -60,12 +60,12 @@ void assertBindTableNotExists() {
private ShardingSphereMetaData createMetaData() {
ShardingSphereSchema schema = mock(ShardingSphereSchema.class, RETURNS_DEEP_STUBS);
when(schema.getTable("t_order").getAllColumns()).thenReturn(Arrays.asList(
- new ShardingSphereColumn("order_id", Types.INTEGER, true, false, false, true, false, false),
- new ShardingSphereColumn("user_id", Types.INTEGER, false, false, false, true, false, false),
- new ShardingSphereColumn("status", Types.INTEGER, false, false, false, true, false, false)));
+ new ShardingSphereColumn("order_id", Types.INTEGER, true, false, "int", false, true, false, false),
+ new ShardingSphereColumn("user_id", Types.INTEGER, false, false, "int", false, true, false, false),
+ new ShardingSphereColumn("status", Types.INTEGER, false, false, "int", false, true, false, false)));
when(schema.getTable("pg_database").getAllColumns()).thenReturn(Arrays.asList(
- new ShardingSphereColumn("datname", Types.VARCHAR, false, false, false, true, false, false),
- new ShardingSphereColumn("datdba", Types.VARCHAR, false, false, false, true, false, false)));
+ new ShardingSphereColumn("datname", Types.VARCHAR, false, false, "int", false, true, false, false),
+ new ShardingSphereColumn("datdba", Types.VARCHAR, false, false, "int", false, true, false, false)));
Review Comment:
Incorrect typeName for `datname` and `datdba` columns. Both columns have type `Types.VARCHAR` but typeName is set to `"int"`. It should be `"varchar"` to match the data type.
##########
proxy/frontend/dialect/mysql/src/test/java/org/apache/shardingsphere/proxy/frontend/mysql/command/query/text/query/MySQLMultiStatementsProxyBackendHandlerTest.java:
##########
@@ -185,8 +185,8 @@ private ContextManager mockContextManager() {
when(result.getMetaDataContexts().getMetaData().getProps().<Integer>getValue(ConfigurationPropertyKey.KERNEL_EXECUTOR_SIZE)).thenReturn(1);
when(result.getMetaDataContexts().getMetaData().getProps().<Boolean>getValue(ConfigurationPropertyKey.SQL_SHOW)).thenReturn(false);
when(result.getMetaDataContexts().getMetaData().getProps().<Integer>getValue(ConfigurationPropertyKey.MAX_CONNECTIONS_SIZE_PER_QUERY)).thenReturn(1);
- ShardingSphereTable table = new ShardingSphereTable("t", Arrays.asList(new ShardingSphereColumn("id", Types.BIGINT, true, false, false, false, true, false),
- new ShardingSphereColumn("v", Types.INTEGER, false, false, false, false, true, false)), Collections.emptyList(), Collections.emptyList());
+ ShardingSphereTable table = new ShardingSphereTable("t", Arrays.asList(new ShardingSphereColumn("id", Types.BIGINT, true, false, "int", false, false, true, false),
Review Comment:
Incorrect typeName for `id` column. The column has type `Types.BIGINT` but typeName is set to `"int"`. It should be `"bigint"` to match the data type.
##########
proxy/frontend/dialect/postgresql/src/main/java/org/apache/shardingsphere/proxy/frontend/postgresql/command/query/extended/PostgreSQLServerPreparedStatement.java:
##########
@@ -48,6 +48,8 @@ public final class PostgreSQLServerPreparedStatement implements ServerPreparedSt
private final List<PostgreSQLColumnType> parameterTypes;
Review Comment:
getParameterTypes exposes the internal representation stored in field parameterTypes. The value may be modified [after this call to getParameterTypes](1).
getParameterTypes exposes the internal representation stored in field parameterTypes. The value may be modified [after this call to getParameterTypes](2).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(pg): complete PostgreSQL custom type & VARBIT support with full test coverage (includes #37216) [shardingsphere]
Posted by "zxs1633079383 (via GitHub)" <gi...@apache.org>.
zxs1633079383 commented on code in PR #37259:
URL: https://github.com/apache/shardingsphere/pull/37259#discussion_r2581650151
##########
proxy/frontend/dialect/postgresql/src/main/java/org/apache/shardingsphere/proxy/frontend/postgresql/command/query/extended/PostgreSQLServerPreparedStatement.java:
##########
@@ -48,6 +48,8 @@ public final class PostgreSQLServerPreparedStatement implements ServerPreparedSt
private final List<PostgreSQLColumnType> parameterTypes;
Review Comment:
He's now assigning values to parameterTypes in the same way, just like above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(pg): complete PostgreSQL custom type & VARBIT support with full test coverage (includes #37216) [shardingsphere]
Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu closed pull request #37259: fix(pg): complete PostgreSQL custom type & VARBIT support with full test coverage (includes #37216)
URL: https://github.com/apache/shardingsphere/pull/37259
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(pg): complete PostgreSQL custom type & VARBIT support with full test coverage (includes #37216) [shardingsphere]
Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu commented on PR #37259:
URL: https://github.com/apache/shardingsphere/pull/37259#issuecomment-3885180765
Closed because of no response anymore.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org