[incubator-superset] branch master updated: Fix "Select all" option in SelectControl (#11692)

[gr...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

graceguo pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git


The following commit(s) were added to refs/heads/master by this push:
     new 8a39f27  Fix "Select all" option in SelectControl (#11692)
8a39f27 is described below

commit 8a39f2799aafd2b9dc49283400433372343e4faf
Author: Kamil Gabryjelski <ka...@gmail.com>
AuthorDate: Tue Nov 17 02:23:32 2020 +0100

    Fix "Select all" option in SelectControl (#11692)
---
 .../src/explore/components/controls/SelectControl.jsx             | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/superset-frontend/src/explore/components/controls/SelectControl.jsx b/superset-frontend/src/explore/components/controls/SelectControl.jsx
index 183b31d..9b8baee 100644
--- a/superset-frontend/src/explore/components/controls/SelectControl.jsx
+++ b/superset-frontend/src/explore/components/controls/SelectControl.jsx
@@ -109,11 +109,9 @@ export default class SelectControl extends React.PureComponent {
         opt.forEach(o => {
           // select all options
           if (o.meta === true) {
-            this.props.onChange(
-              this.getOptions(this.props)
-                .filter(x => !x.meta)
-                .map(x => x[this.props.valueKey]),
-            );
+            optionValue = this.getOptions(this.props)
+              .filter(x => !x.meta)
+              .map(x => x[this.props.valueKey]);
             return;
           }
           optionValue.push(o[this.props.valueKey] || o);