[GitHub] [arrow-datafusion] isidentical commented on a diff in pull request #4128: Combined TPCH runs & uniformed summaries for benchmarks

[GitBox <gi...@apache.org>]

isidentical commented on code in PR #4128:
URL: https://github.com/apache/arrow-datafusion/pull/4128#discussion_r1017211833


##########
benchmarks/README.md:
##########
@@ -49,6 +49,11 @@ The benchmark can then be run (assuming the data created from `dbgen` is in `./d
 cargo run --release --bin tpch -- benchmark datafusion --iterations 3 --path ./data --format tbl --query 1 --batch-size 4096
 ```
 
+If you omit `--query=<query_id>` argument, then all benchmarks will be run one by one (from query 1 to query 22).
+```bash
+cargo run --release --bin tpch -- benchmark datafusion --iterations 1 --path ./data --format tbl --query 1 --batch-size 4096

Review Comment:
   Upps, that's a nice catch!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org