[GitHub] [trafficcontrol] ajschmidt commented on a change in pull request #2785: In Traffic Router Support Snapshots which only update Delivery Services

[GitBox <gi...@apache.org>]

ajschmidt commented on a change in pull request #2785: In Traffic Router Support Snapshots which only update Delivery Services
URL: https://github.com/apache/trafficcontrol/pull/2785#discussion_r342859130
 
 

 ##########
 File path: traffic_router/core/src/main/java/com/comcast/cdn/traffic_control/traffic_router/core/dns/ZoneManager.java
 ##########
 @@ -886,14 +1109,19 @@ private static Record createRecord(final Name name, final InetRecord address) th
 			Zone zone = getZone(name);
 			final InetAddress addr = InetAddress.getByName(address);
 			final int qtype = (addr instanceof Inet6Address) ? Type.AAAA : Type.A;
-			final Zone dynamicZone = createDynamicZone(zone, name, qtype, addr, true, builder);
+			final DNSRequest request = new DNSRequest(zone, name, qtype);
+			request.setClientIP(addr.getHostAddress());
+			request.setHostname(name.relativize(Name.root).toString());
+			request.setDnssec(true);
 
 Review comment:
   The 'true' in the deleted call to createDynamicZone was for the DNSSec setting. I don't know why this was originally hardcoded. I just made sure to preserve the logic. Also, they're are no references in the code to this particular signature of the 'resolve' method. I suspect that it has been put here for testing purposes. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services