[GitHub] [spark] dongjoon-hyun commented on a change in pull request #29061: [SPARK-32258][SQL] NormalizeFloatingNumbers can directly normalize on certain children expressions

[GitBox <gi...@apache.org>]

dongjoon-hyun commented on a change in pull request #29061:
URL: https://github.com/apache/spark/pull/29061#discussion_r452481750



##########
File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/NormalizeFloatingPointNumbersSuite.scala
##########
@@ -91,5 +91,38 @@ class NormalizeFloatingPointNumbersSuite extends PlanTest {
 
     comparePlans(doubleOptimized, correctAnswer)
   }
+
+  test("directly normalize on the children of If") {

Review comment:
       I guess we can remove `directly` here and line 110.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org