You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "claudio4j (via GitHub)" <gi...@apache.org> on 2023/10/30 19:46:36 UTC
[PR] Fix SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder" [camel-k]
claudio4j opened a new pull request, #4883:
URL: https://github.com/apache/camel-k/pull/4883
camel-k-maven-logging from camel-k-runtime will bring slf4j-api 2.0 slf4j-api 1.7 originally from maven zip should be removed
Fix https://github.com/apache/camel-k/issues/4882
The [camel-k-runtime fix 1100](https://github.com/apache/camel-k-runtime/pull/1100) should be merged first
<!-- Description -->
<!--
Enter your extended release note in the below block. If the PR requires
additional action from users switching to the new release, include the string
"action required". If no release note is required, write "NONE".
You can (optionally) mark this PR with labels "kind/bug" or "kind/feature" to make sure
the text is added to the right section of the release notes.
-->
**Release Note**
```release-note
NONE
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder" [camel-k]
Posted by "claudio4j (via GitHub)" <gi...@apache.org>.
claudio4j merged PR #4883:
URL: https://github.com/apache/camel-k/pull/4883
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder" [camel-k]
Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez commented on PR #4883:
URL: https://github.com/apache/camel-k/pull/4883#issuecomment-1792242238
> Do you mean to remove the parent java/pom.xml ?
Yes. CRDs and Logging have to be separate poms.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder" [camel-k]
Posted by "claudio4j (via GitHub)" <gi...@apache.org>.
claudio4j commented on PR #4883:
URL: https://github.com/apache/camel-k/pull/4883#issuecomment-1786814516
the runtime dependency is not good, we can deal with this exclusively on camel-k operator side, by having the maven_overlay script to check the slf4j / logback compatibility and add the missing slf4j-2.0.jar, wdyt ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder" [camel-k]
Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez commented on code in PR #4883:
URL: https://github.com/apache/camel-k/pull/4883#discussion_r1381602953
##########
script/Makefile:
##########
@@ -430,7 +430,7 @@ check-licenses:
maven-overlay:
@echo "####### Preparing maven dependencies bundle..."
mkdir -p build/_maven_overlay
- ./script/maven_overlay.sh -s "$(STAGING_RUNTIME_REPO)" -d "$(CAMEL_K_RUNTIME_DIR)" $(DEFAULT_RUNTIME_VERSION) build/_maven_overlay
+ ./script/maven_overlay.sh build/_maven_overlay
Review Comment:
Ah, I overlooked it. Nitpick: maybe it is better to use `package` phase instead of `install`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder" [camel-k]
Posted by "claudio4j (via GitHub)" <gi...@apache.org>.
claudio4j commented on code in PR #4883:
URL: https://github.com/apache/camel-k/pull/4883#discussion_r1381617769
##########
script/Makefile:
##########
@@ -430,7 +430,7 @@ check-licenses:
maven-overlay:
@echo "####### Preparing maven dependencies bundle..."
mkdir -p build/_maven_overlay
- ./script/maven_overlay.sh -s "$(STAGING_RUNTIME_REPO)" -d "$(CAMEL_K_RUNTIME_DIR)" $(DEFAULT_RUNTIME_VERSION) build/_maven_overlay
+ ./script/maven_overlay.sh build/_maven_overlay
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder" [camel-k]
Posted by "claudio4j (via GitHub)" <gi...@apache.org>.
claudio4j commented on PR #4883:
URL: https://github.com/apache/camel-k/pull/4883#issuecomment-1792592389
I think this fix is important for 2.1.x, I will provide a PR soon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder" [camel-k]
Posted by "claudio4j (via GitHub)" <gi...@apache.org>.
claudio4j commented on PR #4883:
URL: https://github.com/apache/camel-k/pull/4883#issuecomment-1787710624
A proposal would be to move the camel-k-runtime/camel-k-maven-logging to camel-k/java project.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder" [camel-k]
Posted by "claudio4j (via GitHub)" <gi...@apache.org>.
claudio4j commented on PR #4883:
URL: https://github.com/apache/camel-k/pull/4883#issuecomment-1792378854
Somehow the symlink got lost, I will link them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder" [camel-k]
Posted by "claudio4j (via GitHub)" <gi...@apache.org>.
claudio4j commented on PR #4883:
URL: https://github.com/apache/camel-k/pull/4883#issuecomment-1792239805
Do you mean to remove the parent java/pom.xml ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder" [camel-k]
Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez commented on PR #4883:
URL: https://github.com/apache/camel-k/pull/4883#issuecomment-1786829843
Yes. This is kind of how it was managed before [1]. However, we used to have a static set of dependencies. We should have instead an internal maven project in order to have dependabot and all the stuff on it.
[1] https://github.com/apache/camel-k/pull/3376
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder" [camel-k]
Posted by "claudio4j (via GitHub)" <gi...@apache.org>.
claudio4j commented on code in PR #4883:
URL: https://github.com/apache/camel-k/pull/4883#discussion_r1381588631
##########
script/Makefile:
##########
@@ -430,7 +430,7 @@ check-licenses:
maven-overlay:
@echo "####### Preparing maven dependencies bundle..."
mkdir -p build/_maven_overlay
- ./script/maven_overlay.sh -s "$(STAGING_RUNTIME_REPO)" -d "$(CAMEL_K_RUNTIME_DIR)" $(DEFAULT_RUNTIME_VERSION) build/_maven_overlay
+ ./script/maven_overlay.sh build/_maven_overlay
Review Comment:
The maven_overlay.sh contains the clean operation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder" [camel-k]
Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez commented on code in PR #4883:
URL: https://github.com/apache/camel-k/pull/4883#discussion_r1381575196
##########
script/Makefile:
##########
@@ -430,7 +430,7 @@ check-licenses:
maven-overlay:
@echo "####### Preparing maven dependencies bundle..."
mkdir -p build/_maven_overlay
- ./script/maven_overlay.sh -s "$(STAGING_RUNTIME_REPO)" -d "$(CAMEL_K_RUNTIME_DIR)" $(DEFAULT_RUNTIME_VERSION) build/_maven_overlay
+ ./script/maven_overlay.sh build/_maven_overlay
Review Comment:
Maybe it misses a `mvn clean package` before calling the script? or alternatively it should be executed in the script.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org