[GitHub] [arrow] emkornfield commented on a diff in pull request #34668: GH-34667: [C++][Parquet] Test DeltaLengthByteArrayDecoder with invalid inputs

["emkornfield (via GitHub)" <gi...@apache.org>]

emkornfield commented on code in PR #34668:
URL: https://github.com/apache/arrow/pull/34668#discussion_r1144042752


##########
cpp/src/parquet/encoding.cc:
##########
@@ -2723,6 +2730,7 @@ class DeltaLengthByteArrayDecoder : public DecoderImpl,
     // Decode up to `max_values` strings into an internal buffer
     // and reference them into `buffer`.
     max_values = std::min(max_values, num_valid_values_);
+    DCHECK_GE(max_values, 0);

Review Comment:
   should this be an exception?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org