You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2021/03/23 12:50:43 UTC
[GitHub] [camel] coheigea opened a new pull request #5255: CAMEL-16389 - Remove json-smart
coheigea opened a new pull request #5255:
URL: https://github.com/apache/camel/pull/5255
I'm not sure if it makes sense to make it configurable whether to install Jackson, json-smart, etc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] oscerd commented on pull request #5255: CAMEL-16389 - Remove json-smart
Posted by GitBox <gi...@apache.org>.
oscerd commented on pull request #5255:
URL: https://github.com/apache/camel/pull/5255#issuecomment-804880342
and json-smart is used as dependency in camel-karaf, so either you need to leave the placeholder in parent/pom or move the property placeholder in camel-karaf pom.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] oscerd commented on pull request #5255: CAMEL-16389 - Remove json-smart
Posted by GitBox <gi...@apache.org>.
oscerd commented on pull request #5255:
URL: https://github.com/apache/camel/pull/5255#issuecomment-804904735
I think we should merge this as-is and think about the component removal later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] oscerd commented on pull request #5255: CAMEL-16389 - Remove json-smart
Posted by GitBox <gi...@apache.org>.
oscerd commented on pull request #5255:
URL: https://github.com/apache/camel/pull/5255#issuecomment-804879257
Chunk will bring the dependency as transitive dependency: https://mvnrepository.com/artifact/com.x5dev/chunk-templates/3.6.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] oscerd commented on pull request #5255: CAMEL-16389 - Remove json-smart
Posted by GitBox <gi...@apache.org>.
oscerd commented on pull request #5255:
URL: https://github.com/apache/camel/pull/5255#issuecomment-804878458
There is already a ticket about this and I don't think exclude it is enough.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #5255: CAMEL-16389 - Remove json-smart
Posted by GitBox <gi...@apache.org>.
davsclaus commented on pull request #5255:
URL: https://github.com/apache/camel/pull/5255#issuecomment-804943732
Lets get this removed from camel-jsonpath first. Then we can look at chunk later. At least we can then deprecate chunk for 3.10, and remove in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #5255: CAMEL-16389 - Remove json-smart
Posted by GitBox <gi...@apache.org>.
davsclaus commented on pull request #5255:
URL: https://github.com/apache/camel/pull/5255#issuecomment-804921808
Have anyone reported to the chunk report about moving to another json library?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] oscerd commented on pull request #5255: CAMEL-16389 - Remove json-smart
Posted by GitBox <gi...@apache.org>.
oscerd commented on pull request #5255:
URL: https://github.com/apache/camel/pull/5255#issuecomment-805523889
Chunk 3.6.1 released
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] oscerd commented on pull request #5255: CAMEL-16389 - Remove json-smart
Posted by GitBox <gi...@apache.org>.
oscerd commented on pull request #5255:
URL: https://github.com/apache/camel/pull/5255#issuecomment-804879692
For jsonpath yes, I was planning to do the same. For the other transitive dependencies we have, there is no solution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] oscerd commented on pull request #5255: CAMEL-16389 - Remove json-smart
Posted by GitBox <gi...@apache.org>.
oscerd commented on pull request #5255:
URL: https://github.com/apache/camel/pull/5255#issuecomment-805203645
We can wait for camel-chunk, the maintainer will release a new version with json-smart as optional dependency and jackson-databind as base provider.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] oscerd closed pull request #5255: CAMEL-16389 - Remove json-smart
Posted by GitBox <gi...@apache.org>.
oscerd closed pull request #5255:
URL: https://github.com/apache/camel/pull/5255
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus edited a comment on pull request #5255: CAMEL-16389 - Remove json-smart
Posted by GitBox <gi...@apache.org>.
davsclaus edited a comment on pull request #5255:
URL: https://github.com/apache/camel/pull/5255#issuecomment-804921808
Have anyone reported to the chunk project about moving to another json library?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] oscerd commented on pull request #5255: CAMEL-16389 - Remove json-smart
Posted by GitBox <gi...@apache.org>.
oscerd commented on pull request #5255:
URL: https://github.com/apache/camel/pull/5255#issuecomment-805531315
Merged. Some work to do on the Karaf side, and I'll update chunk.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] coheigea commented on pull request #5255: CAMEL-16389 - Remove json-smart
Posted by GitBox <gi...@apache.org>.
coheigea commented on pull request #5255:
URL: https://github.com/apache/camel/pull/5255#issuecomment-804897932
OK let me know what you think and removing camel-chunk or not, and I will update the PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] oscerd commented on pull request #5255: CAMEL-16389 - Remove json-smart
Posted by GitBox <gi...@apache.org>.
oscerd commented on pull request #5255:
URL: https://github.com/apache/camel/pull/5255#issuecomment-804927825
https://github.com/tomj74/chunk-templates/issues/37
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] oscerd commented on pull request #5255: CAMEL-16389 - Remove json-smart
Posted by GitBox <gi...@apache.org>.
oscerd commented on pull request #5255:
URL: https://github.com/apache/camel/pull/5255#issuecomment-804892626
No, it works only with json-smart. So if we want to get rid of it we need to remove the component.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org