You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@myfaces.apache.org by ta...@apache.org on 2018/12/25 21:43:34 UTC
[myfaces] 01/02: removed TODO, it's ok,
the code isn't the same and the benefit would be minimal
This is an automated email from the ASF dual-hosted git repository.
tandraschko pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/myfaces.git
commit af8a4fd62ba1129eec7d5fbfe5fcc962e99e1eae
Author: Thomas Andraschko <ta...@apache.org>
AuthorDate: Tue Dec 25 22:23:45 2018 +0100
removed TODO, it's ok, the code isn't the same and the benefit would be minimal
---
.../org/apache/myfaces/view/facelets/tag/ui/CompositionHandler.java | 4 ++--
.../java/org/apache/myfaces/view/facelets/tag/ui/DecorateHandler.java | 4 +---
2 files changed, 3 insertions(+), 5 deletions(-)
diff --git a/impl/src/main/java/org/apache/myfaces/view/facelets/tag/ui/CompositionHandler.java b/impl/src/main/java/org/apache/myfaces/view/facelets/tag/ui/CompositionHandler.java
index 2981e59..4e68784 100644
--- a/impl/src/main/java/org/apache/myfaces/view/facelets/tag/ui/CompositionHandler.java
+++ b/impl/src/main/java/org/apache/myfaces/view/facelets/tag/ui/CompositionHandler.java
@@ -42,7 +42,7 @@ import org.apache.myfaces.view.facelets.TemplateClient;
import org.apache.myfaces.view.facelets.tag.TagHandlerUtils;
/**
- * TODO: REFACTOR - This class could easily use a common parent with DecoratorHandler
+ *
*
* @author Jacob Hookom
* @version $Id$
@@ -74,7 +74,7 @@ public final class CompositionHandler extends TagHandler implements TemplateClie
_template = getAttribute("template");
if (_template != null)
{
- _handlers = new HashMap<String, DefineHandler>();
+ _handlers = new HashMap<>();
for (DefineHandler handler : TagHandlerUtils.findNextByType(nextHandler, DefineHandler.class))
{
_handlers.put(handler.getName(), handler);
diff --git a/impl/src/main/java/org/apache/myfaces/view/facelets/tag/ui/DecorateHandler.java b/impl/src/main/java/org/apache/myfaces/view/facelets/tag/ui/DecorateHandler.java
index d41c554..c7e6537 100644
--- a/impl/src/main/java/org/apache/myfaces/view/facelets/tag/ui/DecorateHandler.java
+++ b/impl/src/main/java/org/apache/myfaces/view/facelets/tag/ui/DecorateHandler.java
@@ -52,9 +52,7 @@ import org.apache.myfaces.view.facelets.tag.jsf.ComponentSupport;
*
* The sum of it all is that you can take any element in the document and decorate
* it with some external logic as provided by the template.
- *
- * TODO: REFACTOR - This class could easily use a common parent with CompositionHandler
- *
+ *
* @author Jacob Hookom
* @version $Id$
*/