You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2021/05/31 12:59:00 UTC
[jira] [Commented] (LUCENE-9971) Inconsistent SSDVFF and Taxonomy
facet behavior in case of unseen dimension
[ https://issues.apache.org/jira/browse/LUCENE-9971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17354446#comment-17354446 ]
ASF subversion and git services commented on LUCENE-9971:
---------------------------------------------------------
Commit 65842c5c4d3fbc17c861491bdf06d337a2892d07 in lucene's branch refs/heads/main from Alexander Lukyanchikov
[ https://gitbox.apache.org/repos/asf?p=lucene.git;h=65842c5 ]
LUCENE-9971: Inconsistent SSDVFF and Taxonomy facet behavior in case of unseen dimension (#149)
> Inconsistent SSDVFF and Taxonomy facet behavior in case of unseen dimension
> ---------------------------------------------------------------------------
>
> Key: LUCENE-9971
> URL: https://issues.apache.org/jira/browse/LUCENE-9971
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Alexander L
> Priority: Minor
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> Unlike other org.apache.lucene.facet.Facet interface implementations, SortedSetDocValuesFacetCounts and ConcurrentSortedSetDocValuesFacetCounts [throw an exception in case of unseen dimension in the getTopChildren() method |https://github.com/apache/lucene/blob/main/lucene/facet/src/java/org/apache/lucene/facet/sortedset/SortedSetDocValuesFacetCounts.java#L99]
> It is inconsistent with [Facet interface documentation|https://github.com/apache/lucene/blob/main/lucene/facet/src/java/org/apache/lucene/facet/Facets.java#L33] and not pleasant to deal with: in our case requested dimensions can be manually specified by the user, so we should always catch that and check the exception message to be sure of the exact cause.
> During the PR review, it was also decided to make similar changes for Taxonomy implementation.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org