You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "ai-yang (via GitHub)" <gi...@apache.org> on 2026/08/01 11:40:19 UTC

[PR] [studio][ISSUE #733] Prevent stale LLM model responses from overriding providers [rocketmq-dashboard]

ai-yang opened a new pull request, #737:
URL: https://github.com/apache/rocketmq-dashboard/pull/737

   Fixes #733
   
   ## What changed
   
   The LLM settings page now starts initial configuration/model discovery in an effect with cleanup and awaits the complete configuration-plus-model request chain.
   
   Lifecycle, provider-interaction, configuration-request, and model-request generations ensure that only work still owned by the mounted page and active provider may publish configuration, model options, warnings, errors, or loading completion. Provider changes and unmounting invalidate older work, and delayed configuration from a discarded StrictMode lifecycle cannot reset the active form.
   
   This PR is intentionally limited to initial configuration and model-list request ownership. It does not change the LLM API/provider format or the save/connection-test contract.
   
   ## Validation
   
   - Both issue business assertions failed in 5/5 isolated processes on the unmodified `rocketmq-studio` baseline (stale OpenAI model and premature loading completion)
   - Controlled-Promise regression file: 20/20 isolated Node 20.19.5 processes, 5/5 tests per process (100/100 total)
   - Related LLM/API/client tests: 29/29 passed
   - Complete frontend suite on the committed diff: 64 files, 270/270 tests passed
   - ESLint: 0 errors (4 pre-existing Fast Refresh warnings)
   - TypeScript and production Vite build: passed (7,979 modules)
   - Repository pre-commit hook and `git diff --check`: passed
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [studio][ISSUE #733] Prevent stale LLM model responses from overriding providers [rocketmq-dashboard]

Posted by "RockteMQ-AI (via GitHub)" <gi...@apache.org>.
RockteMQ-AI commented on PR #737:
URL: https://github.com/apache/rocketmq-dashboard/pull/737#issuecomment-5153350340

   ## PR Review for #737: [studio][ISSUE #733] Prevent stale LLM model responses from overriding providers
   
   ### Summary
   This PR modifies 2 file(s) with +377/-60 lines changed.
   
   ### Changed Files
   - web/src/pages/studio/LlmSettings.tsx
   -  web/src/pages/studio/__tests__/LlmSettingsAsyncState.test.tsx
   
   ### Observations
   - PR author: @ai-yang
   - Diff size: 18431 characters
   - 379 additions, 62 deletions in diff
   
   ### ⚠️ Warning
   Potential sensitive data exposure detected in diff. Please verify no credentials are hardcoded.
   
   ### Next Steps
   A detailed code-level review requires the code engine. This is a structural overview only.
   Please verify correctness, thread safety, and backward compatibility manually.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [studio][ISSUE #733] Prevent stale LLM model responses from overriding providers [rocketmq-dashboard]

Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins merged PR #737:
URL: https://github.com/apache/rocketmq-dashboard/pull/737


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [studio][ISSUE #733] Prevent stale LLM model responses from overriding providers [rocketmq-dashboard]

Posted by "ai-yang (via GitHub)" <gi...@apache.org>.
ai-yang commented on PR #737:
URL: https://github.com/apache/rocketmq-dashboard/pull/737#issuecomment-5158670541

   Clarification on the automated sensitive-data warning: this diff contains no credential value. The matches are `apiKeyConfigured: true` and the existing `MASKED_API_KEY` placeholder used by the UI tests; no API key or secret is hardcoded.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org