[PR] HDDS-9737. Legacy Replication Manager should consider that UNHEALTHY replicas might be decommissioning [ozone]

["siddhantsangwan (via GitHub)" <gi...@apache.org>]

siddhantsangwan opened a new pull request, #5674:
URL: https://github.com/apache/ozone/pull/5674

   ## What changes were proposed in this pull request?
   The initial problem was that `LegacyReplicationManager` was not considering that `UNHEALTHY` replicas could be decommissioning or entering maintenance. So, its logic for determining whether a container with all `UNHEALTHY` replicas is under replicated was flawed. This was fixed in [HDDS-9652](https://issues.apache.org/jira/browse/HDDS-9652). The fix simply used existing logic in `RatisContainerReplicaCount` that is able to account for decommissioning `UNHEALTHY` replicas. However this didn't completely fix the problem because `DatanodeAdminMonitorImpl` also needs to be updated. The reason it needs to be updated is that `RatisContainerReplicaCount` (extended by `LegacyRatisContainerReplicaCount`, exclusively used by the legacy replication manager) is the interface between the replication manager and the decommissioning flow. It's used by both to determine whether a container is under replicated. This Jira should make it so that when a container has all `UNHEALTHY` replicas, `Datano
 deAdminMonitor` receives the `LegacyRatisContainerReplicaCount` object which can handle decommissioning `UNHEALTHY` containers.
   
   ## What is the link to the Apache JIRA
   
   https://issues.apache.org/jira/browse/HDDS-9737
   
   ## How was this patch tested?
   
   Added unit tests.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

Re: [PR] HDDS-9737. Legacy Replication Manager should consider that UNHEALTHY replicas might be decommissioning [ozone]

["sodonnel (via GitHub)" <gi...@apache.org>]

sodonnel merged PR #5674:
URL: https://github.com/apache/ozone/pull/5674


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org