You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by hanm <gi...@git.apache.org> on 2017/03/14 04:13:09 UTC
[GitHub] zookeeper pull request #190: ZOOKEEPER-2178: fix flaky StandaloneDisabledTes...
GitHub user hanm opened a pull request:
https://github.com/apache/zookeeper/pull/190
ZOOKEEPER-2178: fix flaky StandaloneDisabledTest
The flaky (that existing for a long time) is caused by a ghost server that although not appear in the quorum's config but still up and running and send requests to the quorum {2, 3, 4}. Fix is simply kill the server 1 after it's used. Verified that with the fix the test survive stress test (100+ runs) while w/o the fix the tests fails frequently, on internal Jenkins machine.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hanm/zookeeper ZOOKEEPER-2178
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zookeeper/pull/190.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #190
----
commit 85d4fb7fb5769a7c95b93588ab2357aa3d7f4242
Author: Michael Han <ha...@apache.org>
Date: 2017-03-14T03:48:03Z
ZOOKEEPER-2178: org.apache.zookeeper.server.quorum.StandaloneDisabledTest fails intermittently.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zookeeper pull request #190: ZOOKEEPER-2718: fix flaky StandaloneDisabledTes...
Posted by hanm <gi...@git.apache.org>.
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/190#discussion_r105830547
--- Diff: src/java/test/org/apache/zookeeper/server/quorum/StandaloneDisabledTest.java ---
@@ -102,6 +102,8 @@ public void startSingleServerTest() throws Exception {
Assert.fail("Should have been BadArgumentsException!");
}
+ // Kill server 1 to avoid it interferences with FLE of the quorum {2, 3, 4}.
+ shutDownServer(1);
--- End diff --
oops, fixed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zookeeper issue #190: ZOOKEEPER-2718: fix flaky StandaloneDisabledTest
Posted by hanm <gi...@git.apache.org>.
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/190
Thanks for review, Alex! Committed and closing PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zookeeper issue #190: ZOOKEEPER-2178: fix flaky StandaloneDisabledTest
Posted by hanm <gi...@git.apache.org>.
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/190
@shralex You might want to take a look at this one :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zookeeper pull request #190: ZOOKEEPER-2718: fix flaky StandaloneDisabledTes...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zookeeper/pull/190
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zookeeper pull request #190: ZOOKEEPER-2718: fix flaky StandaloneDisabledTes...
Posted by shralex <gi...@git.apache.org>.
Github user shralex commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/190#discussion_r105828217
--- Diff: src/java/test/org/apache/zookeeper/server/quorum/StandaloneDisabledTest.java ---
@@ -102,6 +102,8 @@ public void startSingleServerTest() throws Exception {
Assert.fail("Should have been BadArgumentsException!");
}
+ // Kill server 1 to avoid it interferences with FLE of the quorum {2, 3, 4}.
+ shutDownServer(1);
--- End diff --
replace 1 with follower1 and perhaps move up, to line 92
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zookeeper issue #190: ZOOKEEPER-2718: fix flaky StandaloneDisabledTest
Posted by shralex <gi...@git.apache.org>.
Github user shralex commented on the issue:
https://github.com/apache/zookeeper/pull/190
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zookeeper pull request #190: ZOOKEEPER-2718: fix flaky StandaloneDisabledTes...
Posted by hanm <gi...@git.apache.org>.
Github user hanm closed the pull request at:
https://github.com/apache/zookeeper/pull/190
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zookeeper pull request #190: ZOOKEEPER-2718: fix flaky StandaloneDisabledTes...
Posted by hanm <gi...@git.apache.org>.
GitHub user hanm reopened a pull request:
https://github.com/apache/zookeeper/pull/190
ZOOKEEPER-2718: fix flaky StandaloneDisabledTest
The flaky (that existing for a long time) is caused by a ghost server that although not appear in the quorum's config but still up and running and send requests to the quorum {2, 3, 4}. Fix is simply kill the server 1 after it's used. Verified that with the fix the test survive stress test (100+ runs) while w/o the fix the tests fails frequently, on internal Jenkins machine.
ZOOKEEPER-2718: build bot do something please.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hanm/zookeeper ZOOKEEPER-2178
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zookeeper/pull/190.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #190
----
commit 85d4fb7fb5769a7c95b93588ab2357aa3d7f4242
Author: Michael Han <ha...@apache.org>
Date: 2017-03-14T03:48:03Z
ZOOKEEPER-2178: org.apache.zookeeper.server.quorum.StandaloneDisabledTest fails intermittently.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---