You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@camel.apache.org by "Stan Lewis (JIRA)" <ji...@apache.org> on 2010/03/18 16:05:46 UTC
[jira] Created: (CAMEL-2559) HttpComponent only checks the registry
for an HttpClientConfigurer, setHttpClientConfigurer no longer works.
HttpComponent only checks the registry for an HttpClientConfigurer, setHttpClientConfigurer no longer works.
------------------------------------------------------------------------------------------------------------
Key: CAMEL-2559
URL: https://issues.apache.org/activemq/browse/CAMEL-2559
Project: Apache Camel
Issue Type: Bug
Components: camel-http
Affects Versions: 2.2.0
Reporter: Stan Lewis
Assignee: Stan Lewis
Fix For: 2.3.0
Basically you can't currently do this:
{code}
public void configure() {
ProxyHttpClientConfigurer configurer = new ProxyHttpClientConfigurer(
"proxyhost",
80,
"user",
"password",
null,
null);
getContext().getComponent("http", HttpComponent.class).setHttpClientConfigurer(configurer);
from("direct:start")
.to("http://www.google.com/search");
}
{code}
HttpComponent only looks in the registry for an HttpClientConfigurer.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (CAMEL-2559) HttpComponent only checks the
registry for an HttpClientConfigurer, setHttpClientConfigurer no longer
works.
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Claus Ibsen resolved CAMEL-2559.
--------------------------------
Resolution: Fixed
trunk: 925759.
Committed patch. 100% test with entire Camel.
> HttpComponent only checks the registry for an HttpClientConfigurer, setHttpClientConfigurer no longer works.
> ------------------------------------------------------------------------------------------------------------
>
> Key: CAMEL-2559
> URL: https://issues.apache.org/activemq/browse/CAMEL-2559
> Project: Apache Camel
> Issue Type: Bug
> Components: camel-http
> Affects Versions: 2.2.0
> Reporter: Stan Lewis
> Assignee: Stan Lewis
> Fix For: 2.3.0
>
> Attachments: CAMEL-2559.patch
>
>
> Basically you can't currently do this:
> {code}
> public void configure() {
> ProxyHttpClientConfigurer configurer = new ProxyHttpClientConfigurer(
> "proxyhost",
> 80,
> "user",
> "password",
> null,
> null);
> getContext().getComponent("http", HttpComponent.class).setHttpClientConfigurer(configurer);
> from("direct:start")
> .to("http://www.google.com/search");
> }
> {code}
> HttpComponent only looks in the registry for an HttpClientConfigurer.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CAMEL-2559) HttpComponent only checks the registry
for an HttpClientConfigurer, setHttpClientConfigurer no longer works.
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Claus Ibsen updated CAMEL-2559:
-------------------------------
Attachment: CAMEL-2559.patch
The patch which fixes the issues listed above
> HttpComponent only checks the registry for an HttpClientConfigurer, setHttpClientConfigurer no longer works.
> ------------------------------------------------------------------------------------------------------------
>
> Key: CAMEL-2559
> URL: https://issues.apache.org/activemq/browse/CAMEL-2559
> Project: Apache Camel
> Issue Type: Bug
> Components: camel-http
> Affects Versions: 2.2.0
> Reporter: Stan Lewis
> Assignee: Stan Lewis
> Fix For: 2.3.0
>
> Attachments: CAMEL-2559.patch
>
>
> Basically you can't currently do this:
> {code}
> public void configure() {
> ProxyHttpClientConfigurer configurer = new ProxyHttpClientConfigurer(
> "proxyhost",
> 80,
> "user",
> "password",
> null,
> null);
> getContext().getComponent("http", HttpComponent.class).setHttpClientConfigurer(configurer);
> from("direct:start")
> .to("http://www.google.com/search");
> }
> {code}
> HttpComponent only looks in the registry for an HttpClientConfigurer.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (CAMEL-2559) HttpComponent only checks the
registry for an HttpClientConfigurer, setHttpClientConfigurer no longer
works.
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Claus Ibsen reopened CAMEL-2559:
--------------------------------
This commit caused problems.
The test {{JettyHttpBindingRefTest}} now fails
> HttpComponent only checks the registry for an HttpClientConfigurer, setHttpClientConfigurer no longer works.
> ------------------------------------------------------------------------------------------------------------
>
> Key: CAMEL-2559
> URL: https://issues.apache.org/activemq/browse/CAMEL-2559
> Project: Apache Camel
> Issue Type: Bug
> Components: camel-http
> Affects Versions: 2.2.0
> Reporter: Stan Lewis
> Assignee: Stan Lewis
> Fix For: 2.3.0
>
>
> Basically you can't currently do this:
> {code}
> public void configure() {
> ProxyHttpClientConfigurer configurer = new ProxyHttpClientConfigurer(
> "proxyhost",
> 80,
> "user",
> "password",
> null,
> null);
> getContext().getComponent("http", HttpComponent.class).setHttpClientConfigurer(configurer);
> from("direct:start")
> .to("http://www.google.com/search");
> }
> {code}
> HttpComponent only looks in the registry for an HttpClientConfigurer.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-2559) HttpComponent only checks the
registry for an HttpClientConfigurer, setHttpClientConfigurer no longer
works.
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=58356#action_58356 ]
Claus Ibsen commented on CAMEL-2559:
------------------------------------
The problem is really HttpComponent allows endpoints to override the component configured options which is wrong.
In fact endpoints should
- use endpoint configured options over component configured
- not mess with the component configured
> HttpComponent only checks the registry for an HttpClientConfigurer, setHttpClientConfigurer no longer works.
> ------------------------------------------------------------------------------------------------------------
>
> Key: CAMEL-2559
> URL: https://issues.apache.org/activemq/browse/CAMEL-2559
> Project: Apache Camel
> Issue Type: Bug
> Components: camel-http
> Affects Versions: 2.2.0
> Reporter: Stan Lewis
> Assignee: Stan Lewis
> Fix For: 2.3.0
>
>
> Basically you can't currently do this:
> {code}
> public void configure() {
> ProxyHttpClientConfigurer configurer = new ProxyHttpClientConfigurer(
> "proxyhost",
> 80,
> "user",
> "password",
> null,
> null);
> getContext().getComponent("http", HttpComponent.class).setHttpClientConfigurer(configurer);
> from("direct:start")
> .to("http://www.google.com/search");
> }
> {code}
> HttpComponent only looks in the registry for an HttpClientConfigurer.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-2559) HttpComponent only checks the
registry for an HttpClientConfigurer, setHttpClientConfigurer no longer
works.
Posted by "Stan Lewis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=58307#action_58307 ]
Stan Lewis commented on CAMEL-2559:
-----------------------------------
Sending src/main/java/org/apache/camel/component/http/HttpComponent.java
Adding src/test/java/org/apache/camel/component/http/HttpClientConfigurerTest.java
Transmitting file data ..
Committed revision 924849.
> HttpComponent only checks the registry for an HttpClientConfigurer, setHttpClientConfigurer no longer works.
> ------------------------------------------------------------------------------------------------------------
>
> Key: CAMEL-2559
> URL: https://issues.apache.org/activemq/browse/CAMEL-2559
> Project: Apache Camel
> Issue Type: Bug
> Components: camel-http
> Affects Versions: 2.2.0
> Reporter: Stan Lewis
> Assignee: Stan Lewis
> Fix For: 2.3.0
>
>
> Basically you can't currently do this:
> {code}
> public void configure() {
> ProxyHttpClientConfigurer configurer = new ProxyHttpClientConfigurer(
> "proxyhost",
> 80,
> "user",
> "password",
> null,
> null);
> getContext().getComponent("http", HttpComponent.class).setHttpClientConfigurer(configurer);
> from("direct:start")
> .to("http://www.google.com/search");
> }
> {code}
> HttpComponent only looks in the registry for an HttpClientConfigurer.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (CAMEL-2559) HttpComponent only checks the
registry for an HttpClientConfigurer, setHttpClientConfigurer no longer
works.
Posted by "Stan Lewis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Stan Lewis resolved CAMEL-2559.
-------------------------------
Resolution: Fixed
> HttpComponent only checks the registry for an HttpClientConfigurer, setHttpClientConfigurer no longer works.
> ------------------------------------------------------------------------------------------------------------
>
> Key: CAMEL-2559
> URL: https://issues.apache.org/activemq/browse/CAMEL-2559
> Project: Apache Camel
> Issue Type: Bug
> Components: camel-http
> Affects Versions: 2.2.0
> Reporter: Stan Lewis
> Assignee: Stan Lewis
> Fix For: 2.3.0
>
>
> Basically you can't currently do this:
> {code}
> public void configure() {
> ProxyHttpClientConfigurer configurer = new ProxyHttpClientConfigurer(
> "proxyhost",
> 80,
> "user",
> "password",
> null,
> null);
> getContext().getComponent("http", HttpComponent.class).setHttpClientConfigurer(configurer);
> from("direct:start")
> .to("http://www.google.com/search");
> }
> {code}
> HttpComponent only looks in the registry for an HttpClientConfigurer.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-2559) HttpComponent only checks the
registry for an HttpClientConfigurer, setHttpClientConfigurer no longer
works.
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=58357#action_58357 ]
Claus Ibsen commented on CAMEL-2559:
------------------------------------
I think I got it covered now, will do more testing.
But I have reworked camel-http and camel-jetty a little big to
- use endpoint configured options over component configured
- not mess with the component configured
- using a single shared {{clientConnectionManager}} as that is whats meant
- properly registering http/https with correct port number on SchemeRegistry on {{clientConnectionManager}}
> HttpComponent only checks the registry for an HttpClientConfigurer, setHttpClientConfigurer no longer works.
> ------------------------------------------------------------------------------------------------------------
>
> Key: CAMEL-2559
> URL: https://issues.apache.org/activemq/browse/CAMEL-2559
> Project: Apache Camel
> Issue Type: Bug
> Components: camel-http
> Affects Versions: 2.2.0
> Reporter: Stan Lewis
> Assignee: Stan Lewis
> Fix For: 2.3.0
>
>
> Basically you can't currently do this:
> {code}
> public void configure() {
> ProxyHttpClientConfigurer configurer = new ProxyHttpClientConfigurer(
> "proxyhost",
> 80,
> "user",
> "password",
> null,
> null);
> getContext().getComponent("http", HttpComponent.class).setHttpClientConfigurer(configurer);
> from("direct:start")
> .to("http://www.google.com/search");
> }
> {code}
> HttpComponent only looks in the registry for an HttpClientConfigurer.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.