You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@stdcxx.apache.org by "Andrew Black (JIRA)" <ji...@apache.org> on 2006/07/10 22:11:29 UTC
[jira] Created: (STDCXX-258) run_locale_utils.sh doesn't consider
path to locale and localedef
run_locale_utils.sh doesn't consider path to locale and localedef
-----------------------------------------------------------------
Key: STDCXX-258
URL: http://issues.apache.org/jira/browse/STDCXX-258
Project: C++ Standard Library
Type: Bug
Components: Build
Reporter: Andrew Black
At this time, the run_locale_utils.sh script invoks the locale and localedef utilities using the PATH environment variable to determine the location of the utilities. This creates a problem if the bin subdirectory of the buildspace isn't in the PATH variable (likely), or if a system copy of locale or localedef is present in the PATH variable prior to the buildspace bin subdirectory.
One possible solution is to alter the PATH variable when calling the run_locale_utils.sh script, either manually or in the stub locale and sanity_check scripts. The trade off of this method is that other programs may be invoked incorrectly, if the altered PATH masks another utility used in the script.
A second possibility is to alter the run_locale_utils.sh script to use relative or absolute paths to the locale and localedef utilities.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Resolved: (STDCXX-258) run_locale_utils.sh doesn't consider
path to locale and localedef
Posted by "Martin Sebor (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/STDCXX-258?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Sebor resolved STDCXX-258.
---------------------------------
Resolution: Fixed
Looks like this is resolved. Hard to say for sure since there's no test case to verify that this is actually fixed. Marking it resolved -- Andrew, can you double-check the fix works as you intended?
> run_locale_utils.sh doesn't consider path to locale and localedef
> -----------------------------------------------------------------
>
> Key: STDCXX-258
> URL: https://issues.apache.org/jira/browse/STDCXX-258
> Project: C++ Standard Library
> Issue Type: Bug
> Components: Build
> Affects Versions: 4.1.2, 4.1.3
> Reporter: Andrew Black
> Assignee: Martin Sebor
> Priority: Minor
> Fix For: 4.2
>
> Attachments: run_utils1.diff
>
>
> At this time, the run_locale_utils.sh script invoks the locale and localedef utilities using the PATH environment variable to determine the location of the utilities. This creates a problem if the bin subdirectory of the buildspace isn't in the PATH variable (likely), or if a system copy of locale or localedef is present in the PATH variable prior to the buildspace bin subdirectory.
> One possible solution is to alter the PATH variable when calling the run_locale_utils.sh script, either manually or in the stub locale and sanity_check scripts. The trade off of this method is that other programs may be invoked incorrectly, if the altered PATH masks another utility used in the script.
> A second possibility is to alter the run_locale_utils.sh script to use relative or absolute paths to the locale and localedef utilities.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (STDCXX-258) run_locale_utils.sh doesn't consider
path to locale and localedef
Posted by "Martin Sebor (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/STDCXX-258?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Sebor updated STDCXX-258:
--------------------------------
Severity: Runtime Error
Priority: Minor (was: Major)
Patch Info: [Patch Available]
Affects Version/s: 4.1.2
4.1.3
Fix Version/s: 4.2
> run_locale_utils.sh doesn't consider path to locale and localedef
> -----------------------------------------------------------------
>
> Key: STDCXX-258
> URL: https://issues.apache.org/jira/browse/STDCXX-258
> Project: C++ Standard Library
> Issue Type: Bug
> Components: Build
> Affects Versions: 4.1.2, 4.1.3
> Reporter: Andrew Black
> Assignee: Martin Sebor
> Priority: Minor
> Fix For: 4.2
>
> Attachments: run_utils1.diff
>
>
> At this time, the run_locale_utils.sh script invoks the locale and localedef utilities using the PATH environment variable to determine the location of the utilities. This creates a problem if the bin subdirectory of the buildspace isn't in the PATH variable (likely), or if a system copy of locale or localedef is present in the PATH variable prior to the buildspace bin subdirectory.
> One possible solution is to alter the PATH variable when calling the run_locale_utils.sh script, either manually or in the stub locale and sanity_check scripts. The trade off of this method is that other programs may be invoked incorrectly, if the altered PATH masks another utility used in the script.
> A second possibility is to alter the run_locale_utils.sh script to use relative or absolute paths to the locale and localedef utilities.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (STDCXX-258) run_locale_utils.sh doesn't consider
path to locale and localedef
Posted by "Martin Sebor (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/STDCXX-258?page=all ]
Martin Sebor reassigned STDCXX-258:
-----------------------------------
Assign To: Martin Sebor
> run_locale_utils.sh doesn't consider path to locale and localedef
> -----------------------------------------------------------------
>
> Key: STDCXX-258
> URL: http://issues.apache.org/jira/browse/STDCXX-258
> Project: C++ Standard Library
> Type: Bug
> Components: Build
> Reporter: Andrew Black
> Assignee: Martin Sebor
> Attachments: run_utils1.diff
>
> At this time, the run_locale_utils.sh script invoks the locale and localedef utilities using the PATH environment variable to determine the location of the utilities. This creates a problem if the bin subdirectory of the buildspace isn't in the PATH variable (likely), or if a system copy of locale or localedef is present in the PATH variable prior to the buildspace bin subdirectory.
> One possible solution is to alter the PATH variable when calling the run_locale_utils.sh script, either manually or in the stub locale and sanity_check scripts. The trade off of this method is that other programs may be invoked incorrectly, if the altered PATH masks another utility used in the script.
> A second possibility is to alter the run_locale_utils.sh script to use relative or absolute paths to the locale and localedef utilities.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (STDCXX-258) run_locale_utils.sh doesn't consider
path to locale and localedef
Posted by "Martin Sebor (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/STDCXX-258?page=comments#action_12420184 ]
Martin Sebor commented on STDCXX-258:
-------------------------------------
Should be fixed by this commit: http://svn.apache.org/viewvc?rev=420652&view=rev
> run_locale_utils.sh doesn't consider path to locale and localedef
> -----------------------------------------------------------------
>
> Key: STDCXX-258
> URL: http://issues.apache.org/jira/browse/STDCXX-258
> Project: C++ Standard Library
> Type: Bug
> Components: Build
> Reporter: Andrew Black
> Assignee: Martin Sebor
> Attachments: run_utils1.diff
>
> At this time, the run_locale_utils.sh script invoks the locale and localedef utilities using the PATH environment variable to determine the location of the utilities. This creates a problem if the bin subdirectory of the buildspace isn't in the PATH variable (likely), or if a system copy of locale or localedef is present in the PATH variable prior to the buildspace bin subdirectory.
> One possible solution is to alter the PATH variable when calling the run_locale_utils.sh script, either manually or in the stub locale and sanity_check scripts. The trade off of this method is that other programs may be invoked incorrectly, if the altered PATH masks another utility used in the script.
> A second possibility is to alter the run_locale_utils.sh script to use relative or absolute paths to the locale and localedef utilities.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (STDCXX-258) run_locale_utils.sh doesn't consider
path to locale and localedef
Posted by "Andrew Black (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/STDCXX-258?page=all ]
Andrew Black updated STDCXX-258:
--------------------------------
Attachment: run_utils1.diff
A possible patch for run_locale_utils.sh
A problem with this patch is that if the run_locale_utils.sh script is invoked from a location other than the the bin subdirectory of the build directory, the script will fail to call the locale and localedef utilities, as it expects them in the current working directory.
This will likely be a problem when manually calling any locale generation wrapper script from the command line, but the behavior of make/run_all is that the wrapper scripts will be called with a current working directory being the correct location.
Changelog:
* run_locale_utils.sh: Alter calls to 'locale' and 'localedef' to call './locale' and './localedef' respectively
Change required to avoid using $PATH in calling locale utilities
> run_locale_utils.sh doesn't consider path to locale and localedef
> -----------------------------------------------------------------
>
> Key: STDCXX-258
> URL: http://issues.apache.org/jira/browse/STDCXX-258
> Project: C++ Standard Library
> Type: Bug
> Components: Build
> Reporter: Andrew Black
> Attachments: run_utils1.diff
>
> At this time, the run_locale_utils.sh script invoks the locale and localedef utilities using the PATH environment variable to determine the location of the utilities. This creates a problem if the bin subdirectory of the buildspace isn't in the PATH variable (likely), or if a system copy of locale or localedef is present in the PATH variable prior to the buildspace bin subdirectory.
> One possible solution is to alter the PATH variable when calling the run_locale_utils.sh script, either manually or in the stub locale and sanity_check scripts. The trade off of this method is that other programs may be invoked incorrectly, if the altered PATH masks another utility used in the script.
> A second possibility is to alter the run_locale_utils.sh script to use relative or absolute paths to the locale and localedef utilities.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Closed: (STDCXX-258) run_locale_utils.sh doesn't consider
path to locale and localedef
Posted by "Andrew Black (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/STDCXX-258?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Black closed STDCXX-258.
-------------------------------
Confirmed fixed in a manual test.
How I tested was by creating a 'fake' locale and localedef script, which echoed an error message indicating that it wasn't the desired utility, then exited with a non-zero status. These scripts were placed in a directory which I prepended to $PATH, then used this PATH to run the sanity_test.sh and en_US.UTF-8.sh scripts. Both tests ran to completion.
I could see a benefit in altering the test infrastructure so that it used this strategy as part of the tests, but that would be an enhancement for 4.2.1 or later.
> run_locale_utils.sh doesn't consider path to locale and localedef
> -----------------------------------------------------------------
>
> Key: STDCXX-258
> URL: https://issues.apache.org/jira/browse/STDCXX-258
> Project: C++ Standard Library
> Issue Type: Bug
> Components: Build
> Affects Versions: 4.1.2, 4.1.3
> Reporter: Andrew Black
> Assignee: Martin Sebor
> Priority: Minor
> Fix For: 4.2
>
> Attachments: run_utils1.diff
>
>
> At this time, the run_locale_utils.sh script invoks the locale and localedef utilities using the PATH environment variable to determine the location of the utilities. This creates a problem if the bin subdirectory of the buildspace isn't in the PATH variable (likely), or if a system copy of locale or localedef is present in the PATH variable prior to the buildspace bin subdirectory.
> One possible solution is to alter the PATH variable when calling the run_locale_utils.sh script, either manually or in the stub locale and sanity_check scripts. The trade off of this method is that other programs may be invoked incorrectly, if the altered PATH masks another utility used in the script.
> A second possibility is to alter the run_locale_utils.sh script to use relative or absolute paths to the locale and localedef utilities.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.