You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by danbroudy <no...@github.com> on 2014/10/31 23:15:28 UTC
[jclouds-labs-google] Loadbalancer Live Test Improvements (#71)
You can merge this Pull Request by running:
git pull https://github.com/danbroudy/jclouds-labs-google loadbalancer
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds-labs-google/pull/71
-- Commit Summary --
* Improved HttpHealthCheckApiLiveTest
* Improved TargetPoolApiLiveTest
* Improved ForwardingRuleApiLiveTest
-- File Changes --
M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/features/ForwardingRuleApi.java (5)
M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/features/TargetPoolApi.java (9)
M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/features/ForwardingRuleApiExpectTest.java (3)
M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/features/ForwardingRuleApiLiveTest.java (38)
M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/features/HttpHealthCheckApiLiveTest.java (67)
M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/features/TargetPoolApiLiveTest.java (206)
-- Patch Links --
https://github.com/jclouds/jclouds-labs-google/pull/71.patch
https://github.com/jclouds/jclouds-labs-google/pull/71.diff
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/71
Re: [jclouds-labs-google] Loadbalancer Live Test Improvements (#71)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-labs-google-pull-requests #201](https://jclouds.ci.cloudbees.com/job/jclouds-labs-google-pull-requests/201/) UNSTABLE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/71#issuecomment-61341503
Re: [jclouds-labs-google] Loadbalancer Live Test Improvements (#71)
Posted by Adrian Cole <no...@github.com>.
> @@ -36,7 +47,14 @@ private HttpHealthCheckApi api() {
>
> @Test(groups = "live")
> public void testInsertHttpHealthCheck() {
> - assertGlobalOperationDoneSucessfully(api().insert(HTTP_HEALTH_CHECK_NAME), TIME_WAIT);
> + HttpHealthCheckCreationOptions options = new HttpHealthCheckCreationOptions()
nit I prefer to declare HttpHealthCheckCreationOptions as a constant as opposed to making a bunch of fields that partially describe it. Then just use that constant object in your assertions below. ex. assertEquals(response.getName(), options.getName());
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/71/files#r19697105
Re: [jclouds-labs-google] Loadbalancer Live Test Improvements (#71)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-labs-google-pull-requests #199](https://jclouds.ci.cloudbees.com/job/jclouds-labs-google-pull-requests/199/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/71#issuecomment-61338808
Re: [jclouds-labs-google] Loadbalancer Live Test Improvements (#71)
Posted by Adrian Cole <no...@github.com>.
> + assertNotNull(targetPool);
> + assertEquals(targetPool.getName(), THIRD_TARGETPOOL_NAME);
> + assertEquals(targetPool.getBackupPool(), fromNullable(null));
> +
> + URI selfLink = api().get(TARGETPOOL_NAME).getSelfLink();
> +
> + Float failoverRatio = Float.valueOf((float) 0.5);
> + assertRegionOperationDoneSucessfully(api().setBackup(THIRD_TARGETPOOL_NAME, failoverRatio, selfLink), TIME_WAIT);
> +
> + TargetPool targetPoolUpdated = api().get(THIRD_TARGETPOOL_NAME);
> + assertNotNull(targetPoolUpdated);
> + assertEquals(targetPoolUpdated.getName(), THIRD_TARGETPOOL_NAME);
> + assertEquals(targetPoolUpdated.getBackupPool(), fromNullable(selfLink));
> + }
> +
> + @Test(groups = "live", dependsOnMethods = {"testListTargetPool",
hmmm :)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/71/files#r19697128
Re: [jclouds-labs-google] Loadbalancer Live Test Improvements (#71)
Posted by Adrian Cole <no...@github.com>.
nice work @danbroudy! At some point we will have to go through the hard work of cherry-picking changes missed into the 1.8.x branch. Less commits mildly eases that burden. Mind squashing?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/71#issuecomment-61338856
Re: [jclouds-labs-google] Loadbalancer Live Test Improvements (#71)
Posted by danbroudy <no...@github.com>.
>
> /**
> * Changes backup pool configurations.
> *
> * @param targetPool the name of the target pool.
> * @param target the URL of target pool for which you want to use as backup.
> + * WARNING: failoverRatio and BackupPool must either both be set or not set. This method
Will do. Also in this case target is the backupPool.
Putting in this link reference:
https://cloud.google.com/compute/docs/reference/latest/targetPools/setBackup
Unless you think a different one makes more sense.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/71/files#r19697313
Re: [jclouds-labs-google] Loadbalancer Live Test Improvements (#71)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-labs-google-pull-requests #200](https://jclouds.ci.cloudbees.com/job/jclouds-labs-google-pull-requests/200/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/71#issuecomment-61339314
Re: [jclouds-labs-google] Loadbalancer Live Test Improvements (#71)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds-labs-google #1600](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-google/1600/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/71#issuecomment-61339621
Re: [jclouds-labs-google] Loadbalancer Live Test Improvements (#71)
Posted by Adrian Cole <no...@github.com>.
Closed #71.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/71#event-186857909
Re: [jclouds-labs-google] Loadbalancer Live Test Improvements (#71)
Posted by Adrian Cole <no...@github.com>.
>
> /**
> * Changes backup pool configurations.
> *
> * @param targetPool the name of the target pool.
> * @param target the URL of target pool for which you want to use as backup.
> + * WARNING: failoverRatio and BackupPool must either both be set or not set. This method
oh maybe the ref would be a code ref.. like `{@link #backupPool}` (presuming that's implemented!)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/71/files#r19697369
Re: [jclouds-labs-google] Loadbalancer Live Test Improvements (#71)
Posted by danbroudy <no...@github.com>.
Ready to go!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/71#issuecomment-61341395
Re: [jclouds-labs-google] Loadbalancer Live Test Improvements (#71)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds-labs-google #1599](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-google/1599/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/71#issuecomment-61339044
Re: [jclouds-labs-google] Loadbalancer Live Test Improvements (#71)
Posted by Adrian Cole <no...@github.com>.
and.. landed! Thanks for taking time to fix broken windows, @danbroudy!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/71#issuecomment-61342101
Re: [jclouds-labs-google] Loadbalancer Live Test Improvements (#71)
Posted by Adrian Cole <no...@github.com>.
ok I've made some low priority comments. whenever you are ready. say go, and I'll merge.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/71#issuecomment-61339337
Re: [jclouds-labs-google] Loadbalancer Live Test Improvements (#71)
Posted by Adrian Cole <no...@github.com>.
>
> /**
> * Changes backup pool configurations.
> *
> * @param targetPool the name of the target pool.
> * @param target the URL of target pool for which you want to use as backup.
> + * WARNING: failoverRatio and BackupPool must either both be set or not set. This method
nit: link refs probably would help here, considering failoverRatio and BackupPool don't refer to parameters.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/71/files#r19697009
Re: [jclouds-labs-google] Loadbalancer Live Test Improvements (#71)
Posted by Adrian Cole <no...@github.com>.
kicked build job
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/71#issuecomment-61341658
Re: [jclouds-labs-google] Loadbalancer Live Test Improvements (#71)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds-labs-google #1601](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-google/1601/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/71#issuecomment-61341749