[GitHub] [incubator-pegasus] foreverneverer commented on a diff in pull request #1104: refactor(java-client): add more detail message for error log

[GitBox <gi...@apache.org>]

foreverneverer commented on code in PR #1104:
URL: https://github.com/apache/incubator-pegasus/pull/1104#discussion_r942263060


##########
java-client/src/main/java/org/apache/pegasus/client/PegasusTable.java:
##########
@@ -51,6 +51,8 @@ public class PegasusTable implements PegasusTableInterface {
   private WriteLimiter writeLimiter;
   private String metaList;
 
+  public static final byte[] defaultByte = "".getBytes();

Review Comment:
   rename `EMPTY_BYTES`, const variable is suggested named uppercase letter



##########
java-client/src/test/java/org/apache/pegasus/client/TestBasic.java:
##########
@@ -2780,4 +2780,103 @@ private void assertScanResult(
           new String(actuallyRes.results.get(i - startIndex).getRight()));
     }
   }
+
+  @Test // To create a timeout condition,need to change configuration/pegasus.properties timeout
+  // parameter to 1 in this case

Review Comment:
   I don't see the change of this pr, so your unit test shouldn't pass?
   
   However, you shouldn't change the config, which may be used for other unit test and cause timeout. if you want create `client` with specific parameters, you should use `createClient` api.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org