You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by Michael Osipov <mi...@apache.org> on 2021/08/04 20:02:12 UTC
[VOTE] Release Apache Maven version 3.8.2
Hi,
We solved 68 issues:
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12316922&version=12349965
There are still a couple of issues left in JIRA:
https://issues.apache.org/jira/issues/?jql=project%20%3D%20MNG%20AND%20resolution%20%3D%20Unresolved%20ORDER%20BY%20priority%20DESC%2C%20updated%20DESC
Staging repo:
https://repository.apache.org/content/repositories/maven-1657/
Dev dist directory:
https://dist.apache.org/repos/dist/dev/maven/maven-3/3.8.2/
Source release checksums:
apache-maven-3.8.2-src.zip sha512:
228ae07dfd89f73cc7d0b10b60708db2730465dbe6022968bde6c5d7f0df9bcd7f460fe1d8012726a29f136486bdb63d1e1ba932e307380fe4c1f4db440407dd
apache-maven-3.8.2-src.tar.gz sha512:
617377ad85ced7961f972610ed88535fd3f1ab18e104556d8a3adee7769515ee67ee3cbaff50afcffd74a443b471b806acb1ae92f91a259bc8ccaab56795baf6
Binary release checksums:
apache-maven-3.8.2-bin.zip sha512:
59ad2cbd6b7abde34ebedda94ce5631256373718e71b55202035bd1190d0144f071433f78b99e16f1204413b3eb888659e5039009e1ad0106f16332e3c62bced
apache-maven-3.8.2-bin.tar.gz sha512:
b0bf39460348b2d8eae1c861ced6c3e8a077b6e761fb3d4669be5de09490521a74db294cf031b0775b2dfcd57bd82246e42ce10904063ef8e3806222e686f222
Draft for release notes:
https://github.com/apache/maven-site/pull/251
Guide to testing staged releases:
http://maven.apache.org/guides/development/guide-testing-releases.html
Vote open for at least 72 hours.
[ ] +1
[ ] +0
[ ] -1
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: [VOTE] Release Apache Maven version 3.8.2
Posted by Olivier Lamy <ol...@apache.org>.
+1
include some interesting fixes
Thanks to take care of this!
On Thu, 5 Aug 2021 at 06:02, Michael Osipov <mi...@apache.org> wrote:
> Hi,
>
> We solved 68 issues:
>
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12316922&version=12349965
>
> There are still a couple of issues left in JIRA:
>
> https://issues.apache.org/jira/issues/?jql=project%20%3D%20MNG%20AND%20resolution%20%3D%20Unresolved%20ORDER%20BY%20priority%20DESC%2C%20updated%20DESC
>
> Staging repo:
> https://repository.apache.org/content/repositories/maven-1657/
>
> Dev dist directory:
> https://dist.apache.org/repos/dist/dev/maven/maven-3/3.8.2/
>
> Source release checksums:
> apache-maven-3.8.2-src.zip sha512:
>
> 228ae07dfd89f73cc7d0b10b60708db2730465dbe6022968bde6c5d7f0df9bcd7f460fe1d8012726a29f136486bdb63d1e1ba932e307380fe4c1f4db440407dd
> apache-maven-3.8.2-src.tar.gz sha512:
>
> 617377ad85ced7961f972610ed88535fd3f1ab18e104556d8a3adee7769515ee67ee3cbaff50afcffd74a443b471b806acb1ae92f91a259bc8ccaab56795baf6
>
> Binary release checksums:
> apache-maven-3.8.2-bin.zip sha512:
>
> 59ad2cbd6b7abde34ebedda94ce5631256373718e71b55202035bd1190d0144f071433f78b99e16f1204413b3eb888659e5039009e1ad0106f16332e3c62bced
> apache-maven-3.8.2-bin.tar.gz sha512:
>
> b0bf39460348b2d8eae1c861ced6c3e8a077b6e761fb3d4669be5de09490521a74db294cf031b0775b2dfcd57bd82246e42ce10904063ef8e3806222e686f222
>
> Draft for release notes:
> https://github.com/apache/maven-site/pull/251
>
>
> Guide to testing staged releases:
> http://maven.apache.org/guides/development/guide-testing-releases.html
>
> Vote open for at least 72 hours.
>
> [ ] +1
> [ ] +0
> [ ] -1
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>
--
Olivier Lamy
http://twitter.com/olamy | http://linkedin.com/in/olamy
Re: [VOTE] Release Apache Maven version 3.8.2
Posted by Enrico Olivelli <eo...@gmail.com>.
+1 (non binding)
Enrico
Il Dom 8 Ago 2021, 10:07 Michael Osipov <mi...@apache.org> ha scritto:
> Am 2021-08-04 um 22:02 schrieb Michael Osipov:
> > Hi,
> >
> > We solved 68 issues:
> >
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12316922&version=12349965
> >
> >
> > There are still a couple of issues left in JIRA:
> >
> https://issues.apache.org/jira/issues/?jql=project%20%3D%20MNG%20AND%20resolution%20%3D%20Unresolved%20ORDER%20BY%20priority%20DESC%2C%20updated%20DESC
> >
> >
> > Staging repo:
> > https://repository.apache.org/content/repositories/maven-1657/
> >
> > Dev dist directory:
> > https://dist.apache.org/repos/dist/dev/maven/maven-3/3.8.2/
> >
> > Source release checksums:
> > apache-maven-3.8.2-src.zip sha512:
> >
> 228ae07dfd89f73cc7d0b10b60708db2730465dbe6022968bde6c5d7f0df9bcd7f460fe1d8012726a29f136486bdb63d1e1ba932e307380fe4c1f4db440407dd
>
> >
> > apache-maven-3.8.2-src.tar.gz sha512:
> >
> 617377ad85ced7961f972610ed88535fd3f1ab18e104556d8a3adee7769515ee67ee3cbaff50afcffd74a443b471b806acb1ae92f91a259bc8ccaab56795baf6
>
> >
> >
> > Binary release checksums:
> > apache-maven-3.8.2-bin.zip sha512:
> >
> 59ad2cbd6b7abde34ebedda94ce5631256373718e71b55202035bd1190d0144f071433f78b99e16f1204413b3eb888659e5039009e1ad0106f16332e3c62bced
>
> >
> > apache-maven-3.8.2-bin.tar.gz sha512:
> >
> b0bf39460348b2d8eae1c861ced6c3e8a077b6e761fb3d4669be5de09490521a74db294cf031b0775b2dfcd57bd82246e42ce10904063ef8e3806222e686f222
>
> >
> >
> > Draft for release notes:
> > https://github.com/apache/maven-site/pull/251
> >
> >
> > Guide to testing staged releases:
> > http://maven.apache.org/guides/development/guide-testing-releases.html
> >
> > Vote open for at least 72 hours.
>
> +1
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>
Re: [VOTE] Release Apache Maven version 3.8.2
Posted by Michael Osipov <mi...@apache.org>.
Am 2021-08-04 um 22:02 schrieb Michael Osipov:
> Hi,
>
> We solved 68 issues:
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12316922&version=12349965
>
>
> There are still a couple of issues left in JIRA:
> https://issues.apache.org/jira/issues/?jql=project%20%3D%20MNG%20AND%20resolution%20%3D%20Unresolved%20ORDER%20BY%20priority%20DESC%2C%20updated%20DESC
>
>
> Staging repo:
> https://repository.apache.org/content/repositories/maven-1657/
>
> Dev dist directory:
> https://dist.apache.org/repos/dist/dev/maven/maven-3/3.8.2/
>
> Source release checksums:
> apache-maven-3.8.2-src.zip sha512:
> 228ae07dfd89f73cc7d0b10b60708db2730465dbe6022968bde6c5d7f0df9bcd7f460fe1d8012726a29f136486bdb63d1e1ba932e307380fe4c1f4db440407dd
>
> apache-maven-3.8.2-src.tar.gz sha512:
> 617377ad85ced7961f972610ed88535fd3f1ab18e104556d8a3adee7769515ee67ee3cbaff50afcffd74a443b471b806acb1ae92f91a259bc8ccaab56795baf6
>
>
> Binary release checksums:
> apache-maven-3.8.2-bin.zip sha512:
> 59ad2cbd6b7abde34ebedda94ce5631256373718e71b55202035bd1190d0144f071433f78b99e16f1204413b3eb888659e5039009e1ad0106f16332e3c62bced
>
> apache-maven-3.8.2-bin.tar.gz sha512:
> b0bf39460348b2d8eae1c861ced6c3e8a077b6e761fb3d4669be5de09490521a74db294cf031b0775b2dfcd57bd82246e42ce10904063ef8e3806222e686f222
>
>
> Draft for release notes:
> https://github.com/apache/maven-site/pull/251
>
>
> Guide to testing staged releases:
> http://maven.apache.org/guides/development/guide-testing-releases.html
>
> Vote open for at least 72 hours.
+1
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: [VOTE] Release Apache Maven version 3.8.2
Posted by Michael Osipov <mi...@apache.org>.
Am 2021-08-06 um 12:07 schrieb Falko Modler:
> Hi all,
>
> it wouldn't surprise me if it was that ThreadLocal quickfix from my PR.
> I think everyone agrees that it is a bandaid solution but well, correctness and stability over (some) speed, IMO.
I absolutely agree here!
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: [VOTE] Release Apache Maven version 3.8.2
Posted by Falko Modler <f....@gmx.net>.
Hi all,
it wouldn't surprise me if it was that ThreadLocal quickfix from my PR.
I think everyone agrees that it is a bandaid solution but well, correctness and stability over (some) speed, IMO.
It would be nice to limit this workaround to only when aggregating goals are involved but that seems like adding more code to a quickfix that should be removed by a proper solution rather sooner than later...
Cheers,
Falko
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: [VOTE] Release Apache Maven version 3.8.2
Posted by Michael Osipov <mi...@apache.org>.
Dan,
thank you very much for testing. Do you think you could bisect to the
commit which introduced the 10% overhead? Maybe it is really the
classpath concurrency issue which has been addressed by Falko Modler.
Also can you try Maven from master and see whether you can reproduce the
10%?
Michael
Am 2021-08-06 um 01:38 schrieb Dan Tran:
> tested with my company internal build with 300+ modules. the build time
> increase by 10%. Not sure if anyone sees the same. but I am happy to take
> it due to the fix at the classpath concurrency issue.
>
> Thanks for pushing this out
>
> -D
>
> On Thu, Aug 5, 2021 at 1:23 PM Tamás Cservenák <ta...@cservenak.net> wrote:
>
>> +1
>>
>> T
>>
>> On Wed, Aug 4, 2021 at 10:02 PM Michael Osipov <mi...@apache.org>
>> wrote:
>>
>>> Hi,
>>>
>>> We solved 68 issues:
>>>
>>>
>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12316922&version=12349965
>>>
>>> There are still a couple of issues left in JIRA:
>>>
>>>
>> https://issues.apache.org/jira/issues/?jql=project%20%3D%20MNG%20AND%20resolution%20%3D%20Unresolved%20ORDER%20BY%20priority%20DESC%2C%20updated%20DESC
>>>
>>> Staging repo:
>>> https://repository.apache.org/content/repositories/maven-1657/
>>>
>>> Dev dist directory:
>>> https://dist.apache.org/repos/dist/dev/maven/maven-3/3.8.2/
>>>
>>> Source release checksums:
>>> apache-maven-3.8.2-src.zip sha512:
>>>
>>>
>> 228ae07dfd89f73cc7d0b10b60708db2730465dbe6022968bde6c5d7f0df9bcd7f460fe1d8012726a29f136486bdb63d1e1ba932e307380fe4c1f4db440407dd
>>> apache-maven-3.8.2-src.tar.gz sha512:
>>>
>>>
>> 617377ad85ced7961f972610ed88535fd3f1ab18e104556d8a3adee7769515ee67ee3cbaff50afcffd74a443b471b806acb1ae92f91a259bc8ccaab56795baf6
>>>
>>> Binary release checksums:
>>> apache-maven-3.8.2-bin.zip sha512:
>>>
>>>
>> 59ad2cbd6b7abde34ebedda94ce5631256373718e71b55202035bd1190d0144f071433f78b99e16f1204413b3eb888659e5039009e1ad0106f16332e3c62bced
>>> apache-maven-3.8.2-bin.tar.gz sha512:
>>>
>>>
>> b0bf39460348b2d8eae1c861ced6c3e8a077b6e761fb3d4669be5de09490521a74db294cf031b0775b2dfcd57bd82246e42ce10904063ef8e3806222e686f222
>>>
>>> Draft for release notes:
>>> https://github.com/apache/maven-site/pull/251
>>>
>>>
>>> Guide to testing staged releases:
>>> http://maven.apache.org/guides/development/guide-testing-releases.html
>>>
>>> Vote open for at least 72 hours.
>>>
>>> [ ] +1
>>> [ ] +0
>>> [ ] -1
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>>> For additional commands, e-mail: dev-help@maven.apache.org
>>>
>>>
>>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: [VOTE] Release Apache Maven version 3.8.2
Posted by Dan Tran <da...@gmail.com>.
tested with my company internal build with 300+ modules. the build time
increase by 10%. Not sure if anyone sees the same. but I am happy to take
it due to the fix at the classpath concurrency issue.
Thanks for pushing this out
-D
On Thu, Aug 5, 2021 at 1:23 PM Tamás Cservenák <ta...@cservenak.net> wrote:
> +1
>
> T
>
> On Wed, Aug 4, 2021 at 10:02 PM Michael Osipov <mi...@apache.org>
> wrote:
>
> > Hi,
> >
> > We solved 68 issues:
> >
> >
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12316922&version=12349965
> >
> > There are still a couple of issues left in JIRA:
> >
> >
> https://issues.apache.org/jira/issues/?jql=project%20%3D%20MNG%20AND%20resolution%20%3D%20Unresolved%20ORDER%20BY%20priority%20DESC%2C%20updated%20DESC
> >
> > Staging repo:
> > https://repository.apache.org/content/repositories/maven-1657/
> >
> > Dev dist directory:
> > https://dist.apache.org/repos/dist/dev/maven/maven-3/3.8.2/
> >
> > Source release checksums:
> > apache-maven-3.8.2-src.zip sha512:
> >
> >
> 228ae07dfd89f73cc7d0b10b60708db2730465dbe6022968bde6c5d7f0df9bcd7f460fe1d8012726a29f136486bdb63d1e1ba932e307380fe4c1f4db440407dd
> > apache-maven-3.8.2-src.tar.gz sha512:
> >
> >
> 617377ad85ced7961f972610ed88535fd3f1ab18e104556d8a3adee7769515ee67ee3cbaff50afcffd74a443b471b806acb1ae92f91a259bc8ccaab56795baf6
> >
> > Binary release checksums:
> > apache-maven-3.8.2-bin.zip sha512:
> >
> >
> 59ad2cbd6b7abde34ebedda94ce5631256373718e71b55202035bd1190d0144f071433f78b99e16f1204413b3eb888659e5039009e1ad0106f16332e3c62bced
> > apache-maven-3.8.2-bin.tar.gz sha512:
> >
> >
> b0bf39460348b2d8eae1c861ced6c3e8a077b6e761fb3d4669be5de09490521a74db294cf031b0775b2dfcd57bd82246e42ce10904063ef8e3806222e686f222
> >
> > Draft for release notes:
> > https://github.com/apache/maven-site/pull/251
> >
> >
> > Guide to testing staged releases:
> > http://maven.apache.org/guides/development/guide-testing-releases.html
> >
> > Vote open for at least 72 hours.
> >
> > [ ] +1
> > [ ] +0
> > [ ] -1
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > For additional commands, e-mail: dev-help@maven.apache.org
> >
> >
>
Re: [VOTE] Release Apache Maven version 3.8.2
Posted by Tamás Cservenák <ta...@cservenak.net>.
+1
T
On Wed, Aug 4, 2021 at 10:02 PM Michael Osipov <mi...@apache.org> wrote:
> Hi,
>
> We solved 68 issues:
>
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12316922&version=12349965
>
> There are still a couple of issues left in JIRA:
>
> https://issues.apache.org/jira/issues/?jql=project%20%3D%20MNG%20AND%20resolution%20%3D%20Unresolved%20ORDER%20BY%20priority%20DESC%2C%20updated%20DESC
>
> Staging repo:
> https://repository.apache.org/content/repositories/maven-1657/
>
> Dev dist directory:
> https://dist.apache.org/repos/dist/dev/maven/maven-3/3.8.2/
>
> Source release checksums:
> apache-maven-3.8.2-src.zip sha512:
>
> 228ae07dfd89f73cc7d0b10b60708db2730465dbe6022968bde6c5d7f0df9bcd7f460fe1d8012726a29f136486bdb63d1e1ba932e307380fe4c1f4db440407dd
> apache-maven-3.8.2-src.tar.gz sha512:
>
> 617377ad85ced7961f972610ed88535fd3f1ab18e104556d8a3adee7769515ee67ee3cbaff50afcffd74a443b471b806acb1ae92f91a259bc8ccaab56795baf6
>
> Binary release checksums:
> apache-maven-3.8.2-bin.zip sha512:
>
> 59ad2cbd6b7abde34ebedda94ce5631256373718e71b55202035bd1190d0144f071433f78b99e16f1204413b3eb888659e5039009e1ad0106f16332e3c62bced
> apache-maven-3.8.2-bin.tar.gz sha512:
>
> b0bf39460348b2d8eae1c861ced6c3e8a077b6e761fb3d4669be5de09490521a74db294cf031b0775b2dfcd57bd82246e42ce10904063ef8e3806222e686f222
>
> Draft for release notes:
> https://github.com/apache/maven-site/pull/251
>
>
> Guide to testing staged releases:
> http://maven.apache.org/guides/development/guide-testing-releases.html
>
> Vote open for at least 72 hours.
>
> [ ] +1
> [ ] +0
> [ ] -1
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>
Re: [VOTE] Release Apache Maven version 3.8.2
Posted by Michael Osipov <mi...@apache.org>.
Am 2021-08-04 um 22:02 schrieb Michael Osipov:
> Hi,
>
> We solved 68 issues:
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12316922&version=12349965
>
>
> There are still a couple of issues left in JIRA:
> https://issues.apache.org/jira/issues/?jql=project%20%3D%20MNG%20AND%20resolution%20%3D%20Unresolved%20ORDER%20BY%20priority%20DESC%2C%20updated%20DESC
>
>
> Staging repo:
> https://repository.apache.org/content/repositories/maven-1657/
>
> Dev dist directory:
> https://dist.apache.org/repos/dist/dev/maven/maven-3/3.8.2/
>
> Source release checksums:
> apache-maven-3.8.2-src.zip sha512:
> 228ae07dfd89f73cc7d0b10b60708db2730465dbe6022968bde6c5d7f0df9bcd7f460fe1d8012726a29f136486bdb63d1e1ba932e307380fe4c1f4db440407dd
>
> apache-maven-3.8.2-src.tar.gz sha512:
> 617377ad85ced7961f972610ed88535fd3f1ab18e104556d8a3adee7769515ee67ee3cbaff50afcffd74a443b471b806acb1ae92f91a259bc8ccaab56795baf6
>
>
> Binary release checksums:
> apache-maven-3.8.2-bin.zip sha512:
> 59ad2cbd6b7abde34ebedda94ce5631256373718e71b55202035bd1190d0144f071433f78b99e16f1204413b3eb888659e5039009e1ad0106f16332e3c62bced
>
> apache-maven-3.8.2-bin.tar.gz sha512:
> b0bf39460348b2d8eae1c861ced6c3e8a077b6e761fb3d4669be5de09490521a74db294cf031b0775b2dfcd57bd82246e42ce10904063ef8e3806222e686f222
>
>
> Draft for release notes:
> https://github.com/apache/maven-site/pull/251
>
>
> Guide to testing staged releases:
> http://maven.apache.org/guides/development/guide-testing-releases.html
>
> Vote open for at least 72 hours.
+1
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: [VOTE] Release Apache Maven version 3.8.2
Posted by Olivier Lamy <ol...@apache.org>.
On Thu, 12 Aug 2021 at 11:54, Olivier Lamy <ol...@apache.org> wrote:
> No it's not that simple :) and probably doesn;t impact many plugins (btw
> those plugins are using a wrong pattern :) )
>
> In your mojo you have this field:
> @Parameter(defaultValue = "${project}", readonly = true)
> private MavenProject project;
>
> Within the mojo you do
> List<String> classpathElements = project.getTestClasspathElements();
>
> But when you start a new thread the result is different.
>
> Thread t = new Thread(() ->
> {
> List<String> classpathElements =
> project.getTestClasspathElements();
> });
>
> t.start();
>
> It is because of the new ThreadLocal usage in MavenProject class.
> Maybe original behaviour could be fixed using InheritableThreadLocal (but
> I haven't tested that yet)
>
using InheritableThreadLocal is fixing the problem.
Personally, I would not make that as a mandatory fix for this release.
but it's up to the release manager.
anyway pr here https://github.com/apache/maven/pull/521
>
> On Thu, 12 Aug 2021 at 05:32, Dan Tran <da...@gmail.com> wrote:
>
>> sounds to me, it impacts any plugin creating a class loader? such jaxws?
>>
>> -D
>>
>> On Wed, Aug 11, 2021 at 4:20 AM Olivier Lamy <ol...@apache.org> wrote:
>>
>> > On Wed, 11 Aug 2021 at 21:16, Michael Osipov <mi...@apache.org>
>> wrote:
>> >
>> > > Merci Olivier for testing.
>> > > Would you say that the change in Maven just revealed this bug in that
>> > > particular plugin?
>> > >
>> >
>> > Yes we can say that :)
>> > I just hope no other plugins do something similar....
>> >
>> >
>> >
>> > > Am 2021-08-11 um 06:03 schrieb Olivier Lamy:
>> > > > did the bisect and found this
>> > > >
>> > > > *➜ **maven-core* *git:(**42c99b45e**)* git bisect good
>> > > >
>> > > > 76d5f0d942f52650d3bdf775b6af42d23d69066b is the first bad commit
>> > > >
>> > > > commit 76d5f0d942f52650d3bdf775b6af42d23d69066b
>> > > >
>> > > > Author: Falko Modler <fa...@users.noreply.github.com>
>> > > >
>> > > > Date: Fri Jun 25 19:28:40 2021 +0200
>> > > >
>> > > >
>> > > > [MNG-6843] Parallel build fails due to missing JAR artifacts in
>> > > > compilePath
>> > > >
>> > > >
>> > > >
>> > > > Signed-off-by: rfscholte <rf...@apache.org>
>> > > >
>> > > > (cherry picked from commit
>> > 73e00ed85df84ba0c557dd020740812b2453f2d3)
>> > > >
>> > > >
>> > > >
>> > > > This closes #482
>> > > >
>> > > >
>> > > > .../org/apache/maven/project/MavenProject.java | 67
>> ++++++++++++
>> > > > ----------
>> > > >
>> > > > 1 file changed, 36 insertions(+), 31 deletions(-)
>> > > >
>> > > >
>> > > >
>> > > > There is a simple fix in the mentioned plugin (and btw the fix is
>> > needed
>> > > :)
>> > > > )
>> > > > So if a mojo creates a new Thread and tries to get some values from
>> > > > MavenProject the result might change (because of this new
>> threadLocal
>> > > > field).
>> > > >
>> > > > not changing my vote but it's still a change and possible failure
>> > > >
>> > > >
>> > > > On Wed, 11 Aug 2021 at 11:29, Olivier Lamy <ol...@apache.org>
>> wrote:
>> > > >
>> > > >> interesting this code change in the plugin fix the issue with the
>> > staged
>> > > >> 3.8.2
>> > > >>
>> > > >>
>> > >
>> >
>> https://github.com/jetty-project/h2spec-maven-plugin/commit/a752521d12c59347a0995d01160332af28e3f092
>> > > >>
>> > > >> looking at commits log not sure if we touched something related to
>> > > thread
>> > > >> context classloader?
>> > > >>
>> > > >> On Wed, 11 Aug 2021 at 09:11, Olivier Lamy <ol...@apache.org>
>> wrote:
>> > > >>
>> > > >>> found some breaking change.
>> > > >>> this plugin is not working anymore:
>> > > >>> https://github.com/jetty-project/h2spec-maven-plugin
>> > > >>> mvn verify
>> > > >>> got ClassNotFoundException
>> > > >>>
>> > > >>> On Wed, 11 Aug 2021 at 03:50, Falko Modler <f....@gmx.net>
>> wrote:
>> > > >>>
>> > > >>>> I checked it briefly with Quarkus (almost 1k modules) and I
>> couldn't
>> > > >>>> really see a difference.
>> > > >>>>
>> > > >>>> Cheers,
>> > > >>>> Falko
>> > > >>>>
>> > > >>>>
>> > ---------------------------------------------------------------------
>> > > >>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> > > >>>> For additional commands, e-mail: dev-help@maven.apache.org
>> > > >>>>
>> > > >>>>
>> > > >>>
>> > > >>> --
>> > > >>> Olivier Lamy
>> > > >>> http://twitter.com/olamy | http://linkedin.com/in/olamy
>> > > >>>
>> > > >>
>> > > >>
>> > > >> --
>> > > >> Olivier Lamy
>> > > >> http://twitter.com/olamy | http://linkedin.com/in/olamy
>> > > >>
>> > > >
>> > > >
>> > >
>> > >
>> > >
>> > > ---------------------------------------------------------------------
>> > > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> > > For additional commands, e-mail: dev-help@maven.apache.org
>> > >
>> > >
>> >
>> > --
>> > Olivier Lamy
>> > http://twitter.com/olamy | http://linkedin.com/in/olamy
>> >
>>
>
>
> --
> Olivier Lamy
> http://twitter.com/olamy | http://linkedin.com/in/olamy
>
--
Olivier Lamy
http://twitter.com/olamy | http://linkedin.com/in/olamy
Re: [VOTE] Release Apache Maven version 3.8.2
Posted by Olivier Lamy <ol...@apache.org>.
No it's not that simple :) and probably doesn;t impact many plugins (btw
those plugins are using a wrong pattern :) )
In your mojo you have this field:
@Parameter(defaultValue = "${project}", readonly = true)
private MavenProject project;
Within the mojo you do
List<String> classpathElements = project.getTestClasspathElements();
But when you start a new thread the result is different.
Thread t = new Thread(() ->
{
List<String> classpathElements = project.getTestClasspathElements();
});
t.start();
It is because of the new ThreadLocal usage in MavenProject class.
Maybe original behaviour could be fixed using InheritableThreadLocal (but I
haven't tested that yet)
On Thu, 12 Aug 2021 at 05:32, Dan Tran <da...@gmail.com> wrote:
> sounds to me, it impacts any plugin creating a class loader? such jaxws?
>
> -D
>
> On Wed, Aug 11, 2021 at 4:20 AM Olivier Lamy <ol...@apache.org> wrote:
>
> > On Wed, 11 Aug 2021 at 21:16, Michael Osipov <mi...@apache.org>
> wrote:
> >
> > > Merci Olivier for testing.
> > > Would you say that the change in Maven just revealed this bug in that
> > > particular plugin?
> > >
> >
> > Yes we can say that :)
> > I just hope no other plugins do something similar....
> >
> >
> >
> > > Am 2021-08-11 um 06:03 schrieb Olivier Lamy:
> > > > did the bisect and found this
> > > >
> > > > *➜ **maven-core* *git:(**42c99b45e**)* git bisect good
> > > >
> > > > 76d5f0d942f52650d3bdf775b6af42d23d69066b is the first bad commit
> > > >
> > > > commit 76d5f0d942f52650d3bdf775b6af42d23d69066b
> > > >
> > > > Author: Falko Modler <fa...@users.noreply.github.com>
> > > >
> > > > Date: Fri Jun 25 19:28:40 2021 +0200
> > > >
> > > >
> > > > [MNG-6843] Parallel build fails due to missing JAR artifacts in
> > > > compilePath
> > > >
> > > >
> > > >
> > > > Signed-off-by: rfscholte <rf...@apache.org>
> > > >
> > > > (cherry picked from commit
> > 73e00ed85df84ba0c557dd020740812b2453f2d3)
> > > >
> > > >
> > > >
> > > > This closes #482
> > > >
> > > >
> > > > .../org/apache/maven/project/MavenProject.java | 67
> ++++++++++++
> > > > ----------
> > > >
> > > > 1 file changed, 36 insertions(+), 31 deletions(-)
> > > >
> > > >
> > > >
> > > > There is a simple fix in the mentioned plugin (and btw the fix is
> > needed
> > > :)
> > > > )
> > > > So if a mojo creates a new Thread and tries to get some values from
> > > > MavenProject the result might change (because of this new threadLocal
> > > > field).
> > > >
> > > > not changing my vote but it's still a change and possible failure
> > > >
> > > >
> > > > On Wed, 11 Aug 2021 at 11:29, Olivier Lamy <ol...@apache.org> wrote:
> > > >
> > > >> interesting this code change in the plugin fix the issue with the
> > staged
> > > >> 3.8.2
> > > >>
> > > >>
> > >
> >
> https://github.com/jetty-project/h2spec-maven-plugin/commit/a752521d12c59347a0995d01160332af28e3f092
> > > >>
> > > >> looking at commits log not sure if we touched something related to
> > > thread
> > > >> context classloader?
> > > >>
> > > >> On Wed, 11 Aug 2021 at 09:11, Olivier Lamy <ol...@apache.org>
> wrote:
> > > >>
> > > >>> found some breaking change.
> > > >>> this plugin is not working anymore:
> > > >>> https://github.com/jetty-project/h2spec-maven-plugin
> > > >>> mvn verify
> > > >>> got ClassNotFoundException
> > > >>>
> > > >>> On Wed, 11 Aug 2021 at 03:50, Falko Modler <f....@gmx.net>
> wrote:
> > > >>>
> > > >>>> I checked it briefly with Quarkus (almost 1k modules) and I
> couldn't
> > > >>>> really see a difference.
> > > >>>>
> > > >>>> Cheers,
> > > >>>> Falko
> > > >>>>
> > > >>>>
> > ---------------------------------------------------------------------
> > > >>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > > >>>> For additional commands, e-mail: dev-help@maven.apache.org
> > > >>>>
> > > >>>>
> > > >>>
> > > >>> --
> > > >>> Olivier Lamy
> > > >>> http://twitter.com/olamy | http://linkedin.com/in/olamy
> > > >>>
> > > >>
> > > >>
> > > >> --
> > > >> Olivier Lamy
> > > >> http://twitter.com/olamy | http://linkedin.com/in/olamy
> > > >>
> > > >
> > > >
> > >
> > >
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > > For additional commands, e-mail: dev-help@maven.apache.org
> > >
> > >
> >
> > --
> > Olivier Lamy
> > http://twitter.com/olamy | http://linkedin.com/in/olamy
> >
>
--
Olivier Lamy
http://twitter.com/olamy | http://linkedin.com/in/olamy
Re: [VOTE] Release Apache Maven version 3.8.2
Posted by Dan Tran <da...@gmail.com>.
sounds to me, it impacts any plugin creating a class loader? such jaxws?
-D
On Wed, Aug 11, 2021 at 4:20 AM Olivier Lamy <ol...@apache.org> wrote:
> On Wed, 11 Aug 2021 at 21:16, Michael Osipov <mi...@apache.org> wrote:
>
> > Merci Olivier for testing.
> > Would you say that the change in Maven just revealed this bug in that
> > particular plugin?
> >
>
> Yes we can say that :)
> I just hope no other plugins do something similar....
>
>
>
> > Am 2021-08-11 um 06:03 schrieb Olivier Lamy:
> > > did the bisect and found this
> > >
> > > *➜ **maven-core* *git:(**42c99b45e**)* git bisect good
> > >
> > > 76d5f0d942f52650d3bdf775b6af42d23d69066b is the first bad commit
> > >
> > > commit 76d5f0d942f52650d3bdf775b6af42d23d69066b
> > >
> > > Author: Falko Modler <fa...@users.noreply.github.com>
> > >
> > > Date: Fri Jun 25 19:28:40 2021 +0200
> > >
> > >
> > > [MNG-6843] Parallel build fails due to missing JAR artifacts in
> > > compilePath
> > >
> > >
> > >
> > > Signed-off-by: rfscholte <rf...@apache.org>
> > >
> > > (cherry picked from commit
> 73e00ed85df84ba0c557dd020740812b2453f2d3)
> > >
> > >
> > >
> > > This closes #482
> > >
> > >
> > > .../org/apache/maven/project/MavenProject.java | 67 ++++++++++++
> > > ----------
> > >
> > > 1 file changed, 36 insertions(+), 31 deletions(-)
> > >
> > >
> > >
> > > There is a simple fix in the mentioned plugin (and btw the fix is
> needed
> > :)
> > > )
> > > So if a mojo creates a new Thread and tries to get some values from
> > > MavenProject the result might change (because of this new threadLocal
> > > field).
> > >
> > > not changing my vote but it's still a change and possible failure
> > >
> > >
> > > On Wed, 11 Aug 2021 at 11:29, Olivier Lamy <ol...@apache.org> wrote:
> > >
> > >> interesting this code change in the plugin fix the issue with the
> staged
> > >> 3.8.2
> > >>
> > >>
> >
> https://github.com/jetty-project/h2spec-maven-plugin/commit/a752521d12c59347a0995d01160332af28e3f092
> > >>
> > >> looking at commits log not sure if we touched something related to
> > thread
> > >> context classloader?
> > >>
> > >> On Wed, 11 Aug 2021 at 09:11, Olivier Lamy <ol...@apache.org> wrote:
> > >>
> > >>> found some breaking change.
> > >>> this plugin is not working anymore:
> > >>> https://github.com/jetty-project/h2spec-maven-plugin
> > >>> mvn verify
> > >>> got ClassNotFoundException
> > >>>
> > >>> On Wed, 11 Aug 2021 at 03:50, Falko Modler <f....@gmx.net> wrote:
> > >>>
> > >>>> I checked it briefly with Quarkus (almost 1k modules) and I couldn't
> > >>>> really see a difference.
> > >>>>
> > >>>> Cheers,
> > >>>> Falko
> > >>>>
> > >>>>
> ---------------------------------------------------------------------
> > >>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > >>>> For additional commands, e-mail: dev-help@maven.apache.org
> > >>>>
> > >>>>
> > >>>
> > >>> --
> > >>> Olivier Lamy
> > >>> http://twitter.com/olamy | http://linkedin.com/in/olamy
> > >>>
> > >>
> > >>
> > >> --
> > >> Olivier Lamy
> > >> http://twitter.com/olamy | http://linkedin.com/in/olamy
> > >>
> > >
> > >
> >
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > For additional commands, e-mail: dev-help@maven.apache.org
> >
> >
>
> --
> Olivier Lamy
> http://twitter.com/olamy | http://linkedin.com/in/olamy
>
Re: [VOTE] Release Apache Maven version 3.8.2
Posted by Olivier Lamy <ol...@apache.org>.
On Wed, 11 Aug 2021 at 21:16, Michael Osipov <mi...@apache.org> wrote:
> Merci Olivier for testing.
> Would you say that the change in Maven just revealed this bug in that
> particular plugin?
>
Yes we can say that :)
I just hope no other plugins do something similar....
> Am 2021-08-11 um 06:03 schrieb Olivier Lamy:
> > did the bisect and found this
> >
> > *➜ **maven-core* *git:(**42c99b45e**)* git bisect good
> >
> > 76d5f0d942f52650d3bdf775b6af42d23d69066b is the first bad commit
> >
> > commit 76d5f0d942f52650d3bdf775b6af42d23d69066b
> >
> > Author: Falko Modler <fa...@users.noreply.github.com>
> >
> > Date: Fri Jun 25 19:28:40 2021 +0200
> >
> >
> > [MNG-6843] Parallel build fails due to missing JAR artifacts in
> > compilePath
> >
> >
> >
> > Signed-off-by: rfscholte <rf...@apache.org>
> >
> > (cherry picked from commit 73e00ed85df84ba0c557dd020740812b2453f2d3)
> >
> >
> >
> > This closes #482
> >
> >
> > .../org/apache/maven/project/MavenProject.java | 67 ++++++++++++
> > ----------
> >
> > 1 file changed, 36 insertions(+), 31 deletions(-)
> >
> >
> >
> > There is a simple fix in the mentioned plugin (and btw the fix is needed
> :)
> > )
> > So if a mojo creates a new Thread and tries to get some values from
> > MavenProject the result might change (because of this new threadLocal
> > field).
> >
> > not changing my vote but it's still a change and possible failure
> >
> >
> > On Wed, 11 Aug 2021 at 11:29, Olivier Lamy <ol...@apache.org> wrote:
> >
> >> interesting this code change in the plugin fix the issue with the staged
> >> 3.8.2
> >>
> >>
> https://github.com/jetty-project/h2spec-maven-plugin/commit/a752521d12c59347a0995d01160332af28e3f092
> >>
> >> looking at commits log not sure if we touched something related to
> thread
> >> context classloader?
> >>
> >> On Wed, 11 Aug 2021 at 09:11, Olivier Lamy <ol...@apache.org> wrote:
> >>
> >>> found some breaking change.
> >>> this plugin is not working anymore:
> >>> https://github.com/jetty-project/h2spec-maven-plugin
> >>> mvn verify
> >>> got ClassNotFoundException
> >>>
> >>> On Wed, 11 Aug 2021 at 03:50, Falko Modler <f....@gmx.net> wrote:
> >>>
> >>>> I checked it briefly with Quarkus (almost 1k modules) and I couldn't
> >>>> really see a difference.
> >>>>
> >>>> Cheers,
> >>>> Falko
> >>>>
> >>>> ---------------------------------------------------------------------
> >>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> >>>> For additional commands, e-mail: dev-help@maven.apache.org
> >>>>
> >>>>
> >>>
> >>> --
> >>> Olivier Lamy
> >>> http://twitter.com/olamy | http://linkedin.com/in/olamy
> >>>
> >>
> >>
> >> --
> >> Olivier Lamy
> >> http://twitter.com/olamy | http://linkedin.com/in/olamy
> >>
> >
> >
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>
--
Olivier Lamy
http://twitter.com/olamy | http://linkedin.com/in/olamy
Re: [VOTE] Release Apache Maven version 3.8.2
Posted by Michael Osipov <mi...@apache.org>.
Merci Olivier for testing.
Would you say that the change in Maven just revealed this bug in that
particular plugin?
Am 2021-08-11 um 06:03 schrieb Olivier Lamy:
> did the bisect and found this
>
> *➜ **maven-core* *git:(**42c99b45e**)* git bisect good
>
> 76d5f0d942f52650d3bdf775b6af42d23d69066b is the first bad commit
>
> commit 76d5f0d942f52650d3bdf775b6af42d23d69066b
>
> Author: Falko Modler <fa...@users.noreply.github.com>
>
> Date: Fri Jun 25 19:28:40 2021 +0200
>
>
> [MNG-6843] Parallel build fails due to missing JAR artifacts in
> compilePath
>
>
>
> Signed-off-by: rfscholte <rf...@apache.org>
>
> (cherry picked from commit 73e00ed85df84ba0c557dd020740812b2453f2d3)
>
>
>
> This closes #482
>
>
> .../org/apache/maven/project/MavenProject.java | 67 ++++++++++++
> ----------
>
> 1 file changed, 36 insertions(+), 31 deletions(-)
>
>
>
> There is a simple fix in the mentioned plugin (and btw the fix is needed :)
> )
> So if a mojo creates a new Thread and tries to get some values from
> MavenProject the result might change (because of this new threadLocal
> field).
>
> not changing my vote but it's still a change and possible failure
>
>
> On Wed, 11 Aug 2021 at 11:29, Olivier Lamy <ol...@apache.org> wrote:
>
>> interesting this code change in the plugin fix the issue with the staged
>> 3.8.2
>>
>> https://github.com/jetty-project/h2spec-maven-plugin/commit/a752521d12c59347a0995d01160332af28e3f092
>>
>> looking at commits log not sure if we touched something related to thread
>> context classloader?
>>
>> On Wed, 11 Aug 2021 at 09:11, Olivier Lamy <ol...@apache.org> wrote:
>>
>>> found some breaking change.
>>> this plugin is not working anymore:
>>> https://github.com/jetty-project/h2spec-maven-plugin
>>> mvn verify
>>> got ClassNotFoundException
>>>
>>> On Wed, 11 Aug 2021 at 03:50, Falko Modler <f....@gmx.net> wrote:
>>>
>>>> I checked it briefly with Quarkus (almost 1k modules) and I couldn't
>>>> really see a difference.
>>>>
>>>> Cheers,
>>>> Falko
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>>>> For additional commands, e-mail: dev-help@maven.apache.org
>>>>
>>>>
>>>
>>> --
>>> Olivier Lamy
>>> http://twitter.com/olamy | http://linkedin.com/in/olamy
>>>
>>
>>
>> --
>> Olivier Lamy
>> http://twitter.com/olamy | http://linkedin.com/in/olamy
>>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: [VOTE] Release Apache Maven version 3.8.2
Posted by Romain Manni-Bucau <rm...@gmail.com>.
As explained over slack it moves the problem and creates by design new
ones, if urging a revert is easier IMHO.
Long term fix can be a ref counting or so but no regression, at least in
single thread, is better anyway for end users I think.
Le lun. 23 août 2021 à 12:12, Falko Modler <f....@gmx.net> a écrit :
> There is an open PR for that as well:
> https://github.com/apache/maven/pull/521
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>
Re: [VOTE] Release Apache Maven version 3.8.2
Posted by Falko Modler <f....@gmx.net>.
There is an open PR for that as well: https://github.com/apache/maven/pull/521
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: [VOTE] Release Apache Maven version 3.8.2
Posted by Romain Manni-Bucau <rm...@gmail.com>.
The one Olivier spotted is not fixed.
Le lun. 23 août 2021 à 11:02, Falko Modler <f....@gmx.net> a écrit :
> Why revert? Are you aware of any other regression caused by that?
> Both known regressions have been fixed (not yet merged).
>
> Having said that, as discussed previously, a solution without a TL is
> preferable in the long run but probably requires a more invasive approach
> that is too big for a 3.8.x patch release.
>
> Cheers,
> Falko
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>
Re: [VOTE] Release Apache Maven version 3.8.2
Posted by Falko Modler <f....@gmx.net>.
Why revert? Are you aware of any other regression caused by that?
Both known regressions have been fixed (not yet merged).
Having said that, as discussed previously, a solution without a TL is preferable in the long run but probably requires a more invasive approach that is too big for a 3.8.x patch release.
Cheers,
Falko
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: [VOTE] Release Apache Maven version 3.8.2
Posted by Romain Manni-Bucau <rm...@gmail.com>.
+1 to revert this threadlocal thing in a 3.8.3
Breaks too silently mojo and is hard to track and technically it is
solvable on our side.
Le lun. 23 août 2021 à 08:29, Slawomir Jaranowski <s....@gmail.com>
a écrit :
> Hi,
>
> I think that https://issues.apache.org/jira/browse/MNG-7215 is also
> important, it breaks the build maven site for projects ...
>
> Please don't extend the manual process ... nowadays we have everything to
> do automatically, every (or most of) plugin has IT tests ... so we need
> just to run its
>
>
> niedz., 22 sie 2021 o 23:48 Falko Modler <f....@gmx.net> napisał(a):
>
> > Unfortunately, this commit introduced another, more severe regression:
> >
> > https://issues.apache.org/jira/browse/MNG-7220
> >
> > I was able to fix it already: https://github.com/apache/maven/pull/527
> >
> > IMO, this warrants a timely 3.8.3 release. WDYT?
> >
> > PS: If there are no automated tests of the standard Maven plugins such
> > as javadoc-plugin before a Maven release,
> > maybe release votes should come with a checklist of plugins that need to
> > pass their tests with that new release, before it's actually published?
> >
> > Cheers,
> >
> > Falko
> >
> > Am 11.08.2021 um 06:03 schrieb Olivier Lamy:
> > > did the bisect and found this
> > >
> > > *➜ **maven-core* *git:(**42c99b45e**)* git bisect good
> > >
> > > 76d5f0d942f52650d3bdf775b6af42d23d69066b is the first bad commit
> > >
> > > commit 76d5f0d942f52650d3bdf775b6af42d23d69066b
> > >
> > > Author: Falko Modler <fa...@users.noreply.github.com>
> > >
> > > Date: Fri Jun 25 19:28:40 2021 +0200
> > >
> > >
> > > [MNG-6843] Parallel build fails due to missing JAR artifacts in
> > > compilePath
> > >
> > >
> > >
> > > Signed-off-by: rfscholte <rf...@apache.org>
> > >
> > > (cherry picked from commit
> 73e00ed85df84ba0c557dd020740812b2453f2d3)
> > >
> > >
> > >
> > > This closes #482
> > >
> > >
> > > .../org/apache/maven/project/MavenProject.java | 67 ++++++++++++
> > > ----------
> > >
> > > 1 file changed, 36 insertions(+), 31 deletions(-)
> > >
> > >
> > >
> > > There is a simple fix in the mentioned plugin (and btw the fix is
> needed
> > :)
> > > )
> > > So if a mojo creates a new Thread and tries to get some values from
> > > MavenProject the result might change (because of this new threadLocal
> > > field).
> > >
> > > not changing my vote but it's still a change and possible failure
> > >
> > >
> > > On Wed, 11 Aug 2021 at 11:29, Olivier Lamy <ol...@apache.org> wrote:
> > >
> > >> interesting this code change in the plugin fix the issue with the
> staged
> > >> 3.8.2
> > >>
> > >>
> >
> https://github.com/jetty-project/h2spec-maven-plugin/commit/a752521d12c59347a0995d01160332af28e3f092
> > >>
> > >> looking at commits log not sure if we touched something related to
> > thread
> > >> context classloader?
> > >>
> > >> On Wed, 11 Aug 2021 at 09:11, Olivier Lamy <ol...@apache.org> wrote:
> > >>
> > >>> found some breaking change.
> > >>> this plugin is not working anymore:
> > >>> https://github.com/jetty-project/h2spec-maven-plugin
> > >>> mvn verify
> > >>> got ClassNotFoundException
> > >>>
> > >>> On Wed, 11 Aug 2021 at 03:50, Falko Modler <f....@gmx.net> wrote:
> > >>>
> > >>>> I checked it briefly with Quarkus (almost 1k modules) and I couldn't
> > >>>> really see a difference.
> > >>>>
> > >>>> Cheers,
> > >>>> Falko
> > >>>>
> > >>>>
> ---------------------------------------------------------------------
> > >>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > >>>> For additional commands, e-mail: dev-help@maven.apache.org
> > >>>>
> > >>>>
> > >>> --
> > >>> Olivier Lamy
> > >>> http://twitter.com/olamy | http://linkedin.com/in/olamy
> > >>>
> > >>
> > >> --
> > >> Olivier Lamy
> > >> http://twitter.com/olamy | http://linkedin.com/in/olamy
> > >>
> > >
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > For additional commands, e-mail: dev-help@maven.apache.org
> >
> >
>
> --
> Sławomir Jaranowski
>
> https://twitter.com/SlawekJaran
> https://github.com/slawekjaranowski
> https://linkedin.com/in/slawomirjaranowski
>
Re: [VOTE] Release Apache Maven version 3.8.2
Posted by Slawomir Jaranowski <s....@gmail.com>.
Hi,
I think that https://issues.apache.org/jira/browse/MNG-7215 is also
important, it breaks the build maven site for projects ...
Please don't extend the manual process ... nowadays we have everything to
do automatically, every (or most of) plugin has IT tests ... so we need
just to run its
niedz., 22 sie 2021 o 23:48 Falko Modler <f....@gmx.net> napisał(a):
> Unfortunately, this commit introduced another, more severe regression:
>
> https://issues.apache.org/jira/browse/MNG-7220
>
> I was able to fix it already: https://github.com/apache/maven/pull/527
>
> IMO, this warrants a timely 3.8.3 release. WDYT?
>
> PS: If there are no automated tests of the standard Maven plugins such
> as javadoc-plugin before a Maven release,
> maybe release votes should come with a checklist of plugins that need to
> pass their tests with that new release, before it's actually published?
>
> Cheers,
>
> Falko
>
> Am 11.08.2021 um 06:03 schrieb Olivier Lamy:
> > did the bisect and found this
> >
> > *➜ **maven-core* *git:(**42c99b45e**)* git bisect good
> >
> > 76d5f0d942f52650d3bdf775b6af42d23d69066b is the first bad commit
> >
> > commit 76d5f0d942f52650d3bdf775b6af42d23d69066b
> >
> > Author: Falko Modler <fa...@users.noreply.github.com>
> >
> > Date: Fri Jun 25 19:28:40 2021 +0200
> >
> >
> > [MNG-6843] Parallel build fails due to missing JAR artifacts in
> > compilePath
> >
> >
> >
> > Signed-off-by: rfscholte <rf...@apache.org>
> >
> > (cherry picked from commit 73e00ed85df84ba0c557dd020740812b2453f2d3)
> >
> >
> >
> > This closes #482
> >
> >
> > .../org/apache/maven/project/MavenProject.java | 67 ++++++++++++
> > ----------
> >
> > 1 file changed, 36 insertions(+), 31 deletions(-)
> >
> >
> >
> > There is a simple fix in the mentioned plugin (and btw the fix is needed
> :)
> > )
> > So if a mojo creates a new Thread and tries to get some values from
> > MavenProject the result might change (because of this new threadLocal
> > field).
> >
> > not changing my vote but it's still a change and possible failure
> >
> >
> > On Wed, 11 Aug 2021 at 11:29, Olivier Lamy <ol...@apache.org> wrote:
> >
> >> interesting this code change in the plugin fix the issue with the staged
> >> 3.8.2
> >>
> >>
> https://github.com/jetty-project/h2spec-maven-plugin/commit/a752521d12c59347a0995d01160332af28e3f092
> >>
> >> looking at commits log not sure if we touched something related to
> thread
> >> context classloader?
> >>
> >> On Wed, 11 Aug 2021 at 09:11, Olivier Lamy <ol...@apache.org> wrote:
> >>
> >>> found some breaking change.
> >>> this plugin is not working anymore:
> >>> https://github.com/jetty-project/h2spec-maven-plugin
> >>> mvn verify
> >>> got ClassNotFoundException
> >>>
> >>> On Wed, 11 Aug 2021 at 03:50, Falko Modler <f....@gmx.net> wrote:
> >>>
> >>>> I checked it briefly with Quarkus (almost 1k modules) and I couldn't
> >>>> really see a difference.
> >>>>
> >>>> Cheers,
> >>>> Falko
> >>>>
> >>>> ---------------------------------------------------------------------
> >>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> >>>> For additional commands, e-mail: dev-help@maven.apache.org
> >>>>
> >>>>
> >>> --
> >>> Olivier Lamy
> >>> http://twitter.com/olamy | http://linkedin.com/in/olamy
> >>>
> >>
> >> --
> >> Olivier Lamy
> >> http://twitter.com/olamy | http://linkedin.com/in/olamy
> >>
> >
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>
--
Sławomir Jaranowski
https://twitter.com/SlawekJaran
https://github.com/slawekjaranowski
https://linkedin.com/in/slawomirjaranowski
Re: [VOTE] Release Apache Maven version 3.8.2
Posted by Falko Modler <f....@gmx.net>.
Unfortunately, this commit introduced another, more severe regression:
https://issues.apache.org/jira/browse/MNG-7220
I was able to fix it already: https://github.com/apache/maven/pull/527
IMO, this warrants a timely 3.8.3 release. WDYT?
PS: If there are no automated tests of the standard Maven plugins such
as javadoc-plugin before a Maven release,
maybe release votes should come with a checklist of plugins that need to
pass their tests with that new release, before it's actually published?
Cheers,
Falko
Am 11.08.2021 um 06:03 schrieb Olivier Lamy:
> did the bisect and found this
>
> *➜ **maven-core* *git:(**42c99b45e**)* git bisect good
>
> 76d5f0d942f52650d3bdf775b6af42d23d69066b is the first bad commit
>
> commit 76d5f0d942f52650d3bdf775b6af42d23d69066b
>
> Author: Falko Modler <fa...@users.noreply.github.com>
>
> Date: Fri Jun 25 19:28:40 2021 +0200
>
>
> [MNG-6843] Parallel build fails due to missing JAR artifacts in
> compilePath
>
>
>
> Signed-off-by: rfscholte <rf...@apache.org>
>
> (cherry picked from commit 73e00ed85df84ba0c557dd020740812b2453f2d3)
>
>
>
> This closes #482
>
>
> .../org/apache/maven/project/MavenProject.java | 67 ++++++++++++
> ----------
>
> 1 file changed, 36 insertions(+), 31 deletions(-)
>
>
>
> There is a simple fix in the mentioned plugin (and btw the fix is needed :)
> )
> So if a mojo creates a new Thread and tries to get some values from
> MavenProject the result might change (because of this new threadLocal
> field).
>
> not changing my vote but it's still a change and possible failure
>
>
> On Wed, 11 Aug 2021 at 11:29, Olivier Lamy <ol...@apache.org> wrote:
>
>> interesting this code change in the plugin fix the issue with the staged
>> 3.8.2
>>
>> https://github.com/jetty-project/h2spec-maven-plugin/commit/a752521d12c59347a0995d01160332af28e3f092
>>
>> looking at commits log not sure if we touched something related to thread
>> context classloader?
>>
>> On Wed, 11 Aug 2021 at 09:11, Olivier Lamy <ol...@apache.org> wrote:
>>
>>> found some breaking change.
>>> this plugin is not working anymore:
>>> https://github.com/jetty-project/h2spec-maven-plugin
>>> mvn verify
>>> got ClassNotFoundException
>>>
>>> On Wed, 11 Aug 2021 at 03:50, Falko Modler <f....@gmx.net> wrote:
>>>
>>>> I checked it briefly with Quarkus (almost 1k modules) and I couldn't
>>>> really see a difference.
>>>>
>>>> Cheers,
>>>> Falko
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>>>> For additional commands, e-mail: dev-help@maven.apache.org
>>>>
>>>>
>>> --
>>> Olivier Lamy
>>> http://twitter.com/olamy | http://linkedin.com/in/olamy
>>>
>>
>> --
>> Olivier Lamy
>> http://twitter.com/olamy | http://linkedin.com/in/olamy
>>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: [VOTE] Release Apache Maven version 3.8.2
Posted by Olivier Lamy <ol...@apache.org>.
did the bisect and found this
*➜ **maven-core* *git:(**42c99b45e**)* git bisect good
76d5f0d942f52650d3bdf775b6af42d23d69066b is the first bad commit
commit 76d5f0d942f52650d3bdf775b6af42d23d69066b
Author: Falko Modler <fa...@users.noreply.github.com>
Date: Fri Jun 25 19:28:40 2021 +0200
[MNG-6843] Parallel build fails due to missing JAR artifacts in
compilePath
Signed-off-by: rfscholte <rf...@apache.org>
(cherry picked from commit 73e00ed85df84ba0c557dd020740812b2453f2d3)
This closes #482
.../org/apache/maven/project/MavenProject.java | 67 ++++++++++++
----------
1 file changed, 36 insertions(+), 31 deletions(-)
There is a simple fix in the mentioned plugin (and btw the fix is needed :)
)
So if a mojo creates a new Thread and tries to get some values from
MavenProject the result might change (because of this new threadLocal
field).
not changing my vote but it's still a change and possible failure
On Wed, 11 Aug 2021 at 11:29, Olivier Lamy <ol...@apache.org> wrote:
> interesting this code change in the plugin fix the issue with the staged
> 3.8.2
>
> https://github.com/jetty-project/h2spec-maven-plugin/commit/a752521d12c59347a0995d01160332af28e3f092
>
> looking at commits log not sure if we touched something related to thread
> context classloader?
>
> On Wed, 11 Aug 2021 at 09:11, Olivier Lamy <ol...@apache.org> wrote:
>
>> found some breaking change.
>> this plugin is not working anymore:
>> https://github.com/jetty-project/h2spec-maven-plugin
>> mvn verify
>> got ClassNotFoundException
>>
>> On Wed, 11 Aug 2021 at 03:50, Falko Modler <f....@gmx.net> wrote:
>>
>>> I checked it briefly with Quarkus (almost 1k modules) and I couldn't
>>> really see a difference.
>>>
>>> Cheers,
>>> Falko
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>>> For additional commands, e-mail: dev-help@maven.apache.org
>>>
>>>
>>
>> --
>> Olivier Lamy
>> http://twitter.com/olamy | http://linkedin.com/in/olamy
>>
>
>
> --
> Olivier Lamy
> http://twitter.com/olamy | http://linkedin.com/in/olamy
>
--
Olivier Lamy
http://twitter.com/olamy | http://linkedin.com/in/olamy
Re: [VOTE] Release Apache Maven version 3.8.2
Posted by Olivier Lamy <ol...@apache.org>.
interesting this code change in the plugin fix the issue with the staged
3.8.2
https://github.com/jetty-project/h2spec-maven-plugin/commit/a752521d12c59347a0995d01160332af28e3f092
looking at commits log not sure if we touched something related to thread
context classloader?
On Wed, 11 Aug 2021 at 09:11, Olivier Lamy <ol...@apache.org> wrote:
> found some breaking change.
> this plugin is not working anymore:
> https://github.com/jetty-project/h2spec-maven-plugin
> mvn verify
> got ClassNotFoundException
>
> On Wed, 11 Aug 2021 at 03:50, Falko Modler <f....@gmx.net> wrote:
>
>> I checked it briefly with Quarkus (almost 1k modules) and I couldn't
>> really see a difference.
>>
>> Cheers,
>> Falko
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> For additional commands, e-mail: dev-help@maven.apache.org
>>
>>
>
> --
> Olivier Lamy
> http://twitter.com/olamy | http://linkedin.com/in/olamy
>
--
Olivier Lamy
http://twitter.com/olamy | http://linkedin.com/in/olamy
Re: [VOTE] Release Apache Maven version 3.8.2
Posted by Olivier Lamy <ol...@apache.org>.
found some breaking change.
this plugin is not working anymore:
https://github.com/jetty-project/h2spec-maven-plugin
mvn verify
got ClassNotFoundException
On Wed, 11 Aug 2021 at 03:50, Falko Modler <f....@gmx.net> wrote:
> I checked it briefly with Quarkus (almost 1k modules) and I couldn't
> really see a difference.
>
> Cheers,
> Falko
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>
--
Olivier Lamy
http://twitter.com/olamy | http://linkedin.com/in/olamy
Re: [VOTE] Release Apache Maven version 3.8.2
Posted by Falko Modler <f....@gmx.net>.
I checked it briefly with Quarkus (almost 1k modules) and I couldn't really see a difference.
Cheers,
Falko
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: [VOTE] Release Apache Maven version 3.8.2
Posted by Eric Lilja <mi...@gmail.com>.
Thank you for testing a bit more, Dan, I can't see anything particular on
my end either, but I don't have access to any really huge builds at
the moment, since I'm on vacation
All in all, I do however feel comfortable to vote now: +1 (non-binding)
- Eric Lilja
On Tue, Aug 10, 2021 at 10:29 AM Dan Tran <da...@gmail.com> wrote:
> Further testing and comparison with current builds, there is no concrete
> evidence of performance degradation.
>
> here is my +1 ( none binding)
>
> Sorry about noise
>
> -D
>
> On Mon, Aug 9, 2021 at 5:13 PM Dan Tran <da...@gmail.com> wrote:
>
> > Hello,
> >
> > I am not able to dedicate the time to do bisecting this issue
> >
> > -D
> >
> > On Mon, Aug 9, 2021 at 3:03 AM Eric Lilja <mi...@gmail.com> wrote:
> >
> >> It's an impressive list of fixes and we are many that would like to see
> a
> >> 3.8.2 release appear. Question for me is if the particular change
> >> that appears to cause a general performance degradation on the scale of
> >> ten
> >> percent is worth it (if it indeed can be isolated to particular JIRA and
> >> not due to general performance creep). No word on the bisect? I find it
> a
> >> bit hard to give a verdict now...if the fix was for a problem that only
> >> affected a small number of users, but its solution makes everyone pay a
> >> performance decrease, it might not be worth it in its current form
> >>
> >> - Eric L
> >>
> >> On Mon, Aug 9, 2021 at 11:50 AM Arnaud Héritier <ah...@gmail.com>
> >> wrote:
> >>
> >> > +1
> >> > Tested on several projects with no issue
> >> > I agree that the performance is a bit degraded but nothing blocker
> >> compared
> >> > the value of the fixes introduced here.
> >> >
> >> > On Sun, Aug 8, 2021 at 10:53 PM Sylwester Lachiewicz <
> >> > slachiewicz@gmail.com>
> >> > wrote:
> >> >
> >> > > +1
> >> > >
> >> > > niedz., 8 sie 2021, 21:32 użytkownik Robert Scholte <
> >> > rfscholte@apache.org>
> >> > > napisał:
> >> > >
> >> > > > +1
> >> > > > On 4-8-2021 22:02:18, Michael Osipov <mi...@apache.org> wrote:
> >> > > > Hi,
> >> > > >
> >> > > > We solved 68 issues:
> >> > > >
> >> > > >
> >> > >
> >> >
> >>
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12316922&version=12349965
> >> > > >
> >> > > > There are still a couple of issues left in JIRA:
> >> > > >
> >> > > >
> >> > >
> >> >
> >>
> https://issues.apache.org/jira/issues/?jql=project%20%3D%20MNG%20AND%20resolution%20%3D%20Unresolved%20ORDER%20BY%20priority%20DESC%2C%20updated%20DESC
> >> > > >
> >> > > > Staging repo:
> >> > > > https://repository.apache.org/content/repositories/maven-1657/
> >> > > >
> >> > > > Dev dist directory:
> >> > > > https://dist.apache.org/repos/dist/dev/maven/maven-3/3.8.2/
> >> > > >
> >> > > > Source release checksums:
> >> > > > apache-maven-3.8.2-src.zip sha512:
> >> > > >
> >> > > >
> >> > >
> >> >
> >>
> 228ae07dfd89f73cc7d0b10b60708db2730465dbe6022968bde6c5d7f0df9bcd7f460fe1d8012726a29f136486bdb63d1e1ba932e307380fe4c1f4db440407dd
> >> > > > apache-maven-3.8.2-src.tar.gz sha512:
> >> > > >
> >> > > >
> >> > >
> >> >
> >>
> 617377ad85ced7961f972610ed88535fd3f1ab18e104556d8a3adee7769515ee67ee3cbaff50afcffd74a443b471b806acb1ae92f91a259bc8ccaab56795baf6
> >> > > >
> >> > > > Binary release checksums:
> >> > > > apache-maven-3.8.2-bin.zip sha512:
> >> > > >
> >> > > >
> >> > >
> >> >
> >>
> 59ad2cbd6b7abde34ebedda94ce5631256373718e71b55202035bd1190d0144f071433f78b99e16f1204413b3eb888659e5039009e1ad0106f16332e3c62bced
> >> > > > apache-maven-3.8.2-bin.tar.gz sha512:
> >> > > >
> >> > > >
> >> > >
> >> >
> >>
> b0bf39460348b2d8eae1c861ced6c3e8a077b6e761fb3d4669be5de09490521a74db294cf031b0775b2dfcd57bd82246e42ce10904063ef8e3806222e686f222
> >> > > >
> >> > > > Draft for release notes:
> >> > > > https://github.com/apache/maven-site/pull/251
> >> > > >
> >> > > >
> >> > > > Guide to testing staged releases:
> >> > > >
> >> http://maven.apache.org/guides/development/guide-testing-releases.html
> >> > > >
> >> > > > Vote open for at least 72 hours.
> >> > > >
> >> > > > [ ] +1
> >> > > > [ ] +0
> >> > > > [ ] -1
> >> > > >
> >> > > >
> >> ---------------------------------------------------------------------
> >> > > > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> >> > > > For additional commands, e-mail: dev-help@maven.apache.org
> >> > > >
> >> > > >
> >> > >
> >> >
> >> >
> >> > --
> >> > Arnaud Héritier
> >> > Twitter/GitHub/... : aheritier
> >> >
> >>
> >
>
Re: [VOTE] Release Apache Maven version 3.8.2
Posted by Dan Tran <da...@gmail.com>.
Further testing and comparison with current builds, there is no concrete
evidence of performance degradation.
here is my +1 ( none binding)
Sorry about noise
-D
On Mon, Aug 9, 2021 at 5:13 PM Dan Tran <da...@gmail.com> wrote:
> Hello,
>
> I am not able to dedicate the time to do bisecting this issue
>
> -D
>
> On Mon, Aug 9, 2021 at 3:03 AM Eric Lilja <mi...@gmail.com> wrote:
>
>> It's an impressive list of fixes and we are many that would like to see a
>> 3.8.2 release appear. Question for me is if the particular change
>> that appears to cause a general performance degradation on the scale of
>> ten
>> percent is worth it (if it indeed can be isolated to particular JIRA and
>> not due to general performance creep). No word on the bisect? I find it a
>> bit hard to give a verdict now...if the fix was for a problem that only
>> affected a small number of users, but its solution makes everyone pay a
>> performance decrease, it might not be worth it in its current form
>>
>> - Eric L
>>
>> On Mon, Aug 9, 2021 at 11:50 AM Arnaud Héritier <ah...@gmail.com>
>> wrote:
>>
>> > +1
>> > Tested on several projects with no issue
>> > I agree that the performance is a bit degraded but nothing blocker
>> compared
>> > the value of the fixes introduced here.
>> >
>> > On Sun, Aug 8, 2021 at 10:53 PM Sylwester Lachiewicz <
>> > slachiewicz@gmail.com>
>> > wrote:
>> >
>> > > +1
>> > >
>> > > niedz., 8 sie 2021, 21:32 użytkownik Robert Scholte <
>> > rfscholte@apache.org>
>> > > napisał:
>> > >
>> > > > +1
>> > > > On 4-8-2021 22:02:18, Michael Osipov <mi...@apache.org> wrote:
>> > > > Hi,
>> > > >
>> > > > We solved 68 issues:
>> > > >
>> > > >
>> > >
>> >
>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12316922&version=12349965
>> > > >
>> > > > There are still a couple of issues left in JIRA:
>> > > >
>> > > >
>> > >
>> >
>> https://issues.apache.org/jira/issues/?jql=project%20%3D%20MNG%20AND%20resolution%20%3D%20Unresolved%20ORDER%20BY%20priority%20DESC%2C%20updated%20DESC
>> > > >
>> > > > Staging repo:
>> > > > https://repository.apache.org/content/repositories/maven-1657/
>> > > >
>> > > > Dev dist directory:
>> > > > https://dist.apache.org/repos/dist/dev/maven/maven-3/3.8.2/
>> > > >
>> > > > Source release checksums:
>> > > > apache-maven-3.8.2-src.zip sha512:
>> > > >
>> > > >
>> > >
>> >
>> 228ae07dfd89f73cc7d0b10b60708db2730465dbe6022968bde6c5d7f0df9bcd7f460fe1d8012726a29f136486bdb63d1e1ba932e307380fe4c1f4db440407dd
>> > > > apache-maven-3.8.2-src.tar.gz sha512:
>> > > >
>> > > >
>> > >
>> >
>> 617377ad85ced7961f972610ed88535fd3f1ab18e104556d8a3adee7769515ee67ee3cbaff50afcffd74a443b471b806acb1ae92f91a259bc8ccaab56795baf6
>> > > >
>> > > > Binary release checksums:
>> > > > apache-maven-3.8.2-bin.zip sha512:
>> > > >
>> > > >
>> > >
>> >
>> 59ad2cbd6b7abde34ebedda94ce5631256373718e71b55202035bd1190d0144f071433f78b99e16f1204413b3eb888659e5039009e1ad0106f16332e3c62bced
>> > > > apache-maven-3.8.2-bin.tar.gz sha512:
>> > > >
>> > > >
>> > >
>> >
>> b0bf39460348b2d8eae1c861ced6c3e8a077b6e761fb3d4669be5de09490521a74db294cf031b0775b2dfcd57bd82246e42ce10904063ef8e3806222e686f222
>> > > >
>> > > > Draft for release notes:
>> > > > https://github.com/apache/maven-site/pull/251
>> > > >
>> > > >
>> > > > Guide to testing staged releases:
>> > > >
>> http://maven.apache.org/guides/development/guide-testing-releases.html
>> > > >
>> > > > Vote open for at least 72 hours.
>> > > >
>> > > > [ ] +1
>> > > > [ ] +0
>> > > > [ ] -1
>> > > >
>> > > >
>> ---------------------------------------------------------------------
>> > > > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> > > > For additional commands, e-mail: dev-help@maven.apache.org
>> > > >
>> > > >
>> > >
>> >
>> >
>> > --
>> > Arnaud Héritier
>> > Twitter/GitHub/... : aheritier
>> >
>>
>
Re: [VOTE] Release Apache Maven version 3.8.2
Posted by Dan Tran <da...@gmail.com>.
Hello,
I am not able to dedicate the time to do bisecting this issue
-D
On Mon, Aug 9, 2021 at 3:03 AM Eric Lilja <mi...@gmail.com> wrote:
> It's an impressive list of fixes and we are many that would like to see a
> 3.8.2 release appear. Question for me is if the particular change
> that appears to cause a general performance degradation on the scale of ten
> percent is worth it (if it indeed can be isolated to particular JIRA and
> not due to general performance creep). No word on the bisect? I find it a
> bit hard to give a verdict now...if the fix was for a problem that only
> affected a small number of users, but its solution makes everyone pay a
> performance decrease, it might not be worth it in its current form
>
> - Eric L
>
> On Mon, Aug 9, 2021 at 11:50 AM Arnaud Héritier <ah...@gmail.com>
> wrote:
>
> > +1
> > Tested on several projects with no issue
> > I agree that the performance is a bit degraded but nothing blocker
> compared
> > the value of the fixes introduced here.
> >
> > On Sun, Aug 8, 2021 at 10:53 PM Sylwester Lachiewicz <
> > slachiewicz@gmail.com>
> > wrote:
> >
> > > +1
> > >
> > > niedz., 8 sie 2021, 21:32 użytkownik Robert Scholte <
> > rfscholte@apache.org>
> > > napisał:
> > >
> > > > +1
> > > > On 4-8-2021 22:02:18, Michael Osipov <mi...@apache.org> wrote:
> > > > Hi,
> > > >
> > > > We solved 68 issues:
> > > >
> > > >
> > >
> >
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12316922&version=12349965
> > > >
> > > > There are still a couple of issues left in JIRA:
> > > >
> > > >
> > >
> >
> https://issues.apache.org/jira/issues/?jql=project%20%3D%20MNG%20AND%20resolution%20%3D%20Unresolved%20ORDER%20BY%20priority%20DESC%2C%20updated%20DESC
> > > >
> > > > Staging repo:
> > > > https://repository.apache.org/content/repositories/maven-1657/
> > > >
> > > > Dev dist directory:
> > > > https://dist.apache.org/repos/dist/dev/maven/maven-3/3.8.2/
> > > >
> > > > Source release checksums:
> > > > apache-maven-3.8.2-src.zip sha512:
> > > >
> > > >
> > >
> >
> 228ae07dfd89f73cc7d0b10b60708db2730465dbe6022968bde6c5d7f0df9bcd7f460fe1d8012726a29f136486bdb63d1e1ba932e307380fe4c1f4db440407dd
> > > > apache-maven-3.8.2-src.tar.gz sha512:
> > > >
> > > >
> > >
> >
> 617377ad85ced7961f972610ed88535fd3f1ab18e104556d8a3adee7769515ee67ee3cbaff50afcffd74a443b471b806acb1ae92f91a259bc8ccaab56795baf6
> > > >
> > > > Binary release checksums:
> > > > apache-maven-3.8.2-bin.zip sha512:
> > > >
> > > >
> > >
> >
> 59ad2cbd6b7abde34ebedda94ce5631256373718e71b55202035bd1190d0144f071433f78b99e16f1204413b3eb888659e5039009e1ad0106f16332e3c62bced
> > > > apache-maven-3.8.2-bin.tar.gz sha512:
> > > >
> > > >
> > >
> >
> b0bf39460348b2d8eae1c861ced6c3e8a077b6e761fb3d4669be5de09490521a74db294cf031b0775b2dfcd57bd82246e42ce10904063ef8e3806222e686f222
> > > >
> > > > Draft for release notes:
> > > > https://github.com/apache/maven-site/pull/251
> > > >
> > > >
> > > > Guide to testing staged releases:
> > > >
> http://maven.apache.org/guides/development/guide-testing-releases.html
> > > >
> > > > Vote open for at least 72 hours.
> > > >
> > > > [ ] +1
> > > > [ ] +0
> > > > [ ] -1
> > > >
> > > > ---------------------------------------------------------------------
> > > > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > > > For additional commands, e-mail: dev-help@maven.apache.org
> > > >
> > > >
> > >
> >
> >
> > --
> > Arnaud Héritier
> > Twitter/GitHub/... : aheritier
> >
>
Re: [VOTE] Release Apache Maven version 3.8.2
Posted by Eric Lilja <mi...@gmail.com>.
It's an impressive list of fixes and we are many that would like to see a
3.8.2 release appear. Question for me is if the particular change
that appears to cause a general performance degradation on the scale of ten
percent is worth it (if it indeed can be isolated to particular JIRA and
not due to general performance creep). No word on the bisect? I find it a
bit hard to give a verdict now...if the fix was for a problem that only
affected a small number of users, but its solution makes everyone pay a
performance decrease, it might not be worth it in its current form
- Eric L
On Mon, Aug 9, 2021 at 11:50 AM Arnaud Héritier <ah...@gmail.com> wrote:
> +1
> Tested on several projects with no issue
> I agree that the performance is a bit degraded but nothing blocker compared
> the value of the fixes introduced here.
>
> On Sun, Aug 8, 2021 at 10:53 PM Sylwester Lachiewicz <
> slachiewicz@gmail.com>
> wrote:
>
> > +1
> >
> > niedz., 8 sie 2021, 21:32 użytkownik Robert Scholte <
> rfscholte@apache.org>
> > napisał:
> >
> > > +1
> > > On 4-8-2021 22:02:18, Michael Osipov <mi...@apache.org> wrote:
> > > Hi,
> > >
> > > We solved 68 issues:
> > >
> > >
> >
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12316922&version=12349965
> > >
> > > There are still a couple of issues left in JIRA:
> > >
> > >
> >
> https://issues.apache.org/jira/issues/?jql=project%20%3D%20MNG%20AND%20resolution%20%3D%20Unresolved%20ORDER%20BY%20priority%20DESC%2C%20updated%20DESC
> > >
> > > Staging repo:
> > > https://repository.apache.org/content/repositories/maven-1657/
> > >
> > > Dev dist directory:
> > > https://dist.apache.org/repos/dist/dev/maven/maven-3/3.8.2/
> > >
> > > Source release checksums:
> > > apache-maven-3.8.2-src.zip sha512:
> > >
> > >
> >
> 228ae07dfd89f73cc7d0b10b60708db2730465dbe6022968bde6c5d7f0df9bcd7f460fe1d8012726a29f136486bdb63d1e1ba932e307380fe4c1f4db440407dd
> > > apache-maven-3.8.2-src.tar.gz sha512:
> > >
> > >
> >
> 617377ad85ced7961f972610ed88535fd3f1ab18e104556d8a3adee7769515ee67ee3cbaff50afcffd74a443b471b806acb1ae92f91a259bc8ccaab56795baf6
> > >
> > > Binary release checksums:
> > > apache-maven-3.8.2-bin.zip sha512:
> > >
> > >
> >
> 59ad2cbd6b7abde34ebedda94ce5631256373718e71b55202035bd1190d0144f071433f78b99e16f1204413b3eb888659e5039009e1ad0106f16332e3c62bced
> > > apache-maven-3.8.2-bin.tar.gz sha512:
> > >
> > >
> >
> b0bf39460348b2d8eae1c861ced6c3e8a077b6e761fb3d4669be5de09490521a74db294cf031b0775b2dfcd57bd82246e42ce10904063ef8e3806222e686f222
> > >
> > > Draft for release notes:
> > > https://github.com/apache/maven-site/pull/251
> > >
> > >
> > > Guide to testing staged releases:
> > > http://maven.apache.org/guides/development/guide-testing-releases.html
> > >
> > > Vote open for at least 72 hours.
> > >
> > > [ ] +1
> > > [ ] +0
> > > [ ] -1
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > > For additional commands, e-mail: dev-help@maven.apache.org
> > >
> > >
> >
>
>
> --
> Arnaud Héritier
> Twitter/GitHub/... : aheritier
>
Re: [VOTE] Release Apache Maven version 3.8.2
Posted by Arnaud Héritier <ah...@gmail.com>.
+1
Tested on several projects with no issue
I agree that the performance is a bit degraded but nothing blocker compared
the value of the fixes introduced here.
On Sun, Aug 8, 2021 at 10:53 PM Sylwester Lachiewicz <sl...@gmail.com>
wrote:
> +1
>
> niedz., 8 sie 2021, 21:32 użytkownik Robert Scholte <rf...@apache.org>
> napisał:
>
> > +1
> > On 4-8-2021 22:02:18, Michael Osipov <mi...@apache.org> wrote:
> > Hi,
> >
> > We solved 68 issues:
> >
> >
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12316922&version=12349965
> >
> > There are still a couple of issues left in JIRA:
> >
> >
> https://issues.apache.org/jira/issues/?jql=project%20%3D%20MNG%20AND%20resolution%20%3D%20Unresolved%20ORDER%20BY%20priority%20DESC%2C%20updated%20DESC
> >
> > Staging repo:
> > https://repository.apache.org/content/repositories/maven-1657/
> >
> > Dev dist directory:
> > https://dist.apache.org/repos/dist/dev/maven/maven-3/3.8.2/
> >
> > Source release checksums:
> > apache-maven-3.8.2-src.zip sha512:
> >
> >
> 228ae07dfd89f73cc7d0b10b60708db2730465dbe6022968bde6c5d7f0df9bcd7f460fe1d8012726a29f136486bdb63d1e1ba932e307380fe4c1f4db440407dd
> > apache-maven-3.8.2-src.tar.gz sha512:
> >
> >
> 617377ad85ced7961f972610ed88535fd3f1ab18e104556d8a3adee7769515ee67ee3cbaff50afcffd74a443b471b806acb1ae92f91a259bc8ccaab56795baf6
> >
> > Binary release checksums:
> > apache-maven-3.8.2-bin.zip sha512:
> >
> >
> 59ad2cbd6b7abde34ebedda94ce5631256373718e71b55202035bd1190d0144f071433f78b99e16f1204413b3eb888659e5039009e1ad0106f16332e3c62bced
> > apache-maven-3.8.2-bin.tar.gz sha512:
> >
> >
> b0bf39460348b2d8eae1c861ced6c3e8a077b6e761fb3d4669be5de09490521a74db294cf031b0775b2dfcd57bd82246e42ce10904063ef8e3806222e686f222
> >
> > Draft for release notes:
> > https://github.com/apache/maven-site/pull/251
> >
> >
> > Guide to testing staged releases:
> > http://maven.apache.org/guides/development/guide-testing-releases.html
> >
> > Vote open for at least 72 hours.
> >
> > [ ] +1
> > [ ] +0
> > [ ] -1
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > For additional commands, e-mail: dev-help@maven.apache.org
> >
> >
>
--
Arnaud Héritier
Twitter/GitHub/... : aheritier
Re: [VOTE] Release Apache Maven version 3.8.2
Posted by Sylwester Lachiewicz <sl...@gmail.com>.
+1
niedz., 8 sie 2021, 21:32 użytkownik Robert Scholte <rf...@apache.org>
napisał:
> +1
> On 4-8-2021 22:02:18, Michael Osipov <mi...@apache.org> wrote:
> Hi,
>
> We solved 68 issues:
>
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12316922&version=12349965
>
> There are still a couple of issues left in JIRA:
>
> https://issues.apache.org/jira/issues/?jql=project%20%3D%20MNG%20AND%20resolution%20%3D%20Unresolved%20ORDER%20BY%20priority%20DESC%2C%20updated%20DESC
>
> Staging repo:
> https://repository.apache.org/content/repositories/maven-1657/
>
> Dev dist directory:
> https://dist.apache.org/repos/dist/dev/maven/maven-3/3.8.2/
>
> Source release checksums:
> apache-maven-3.8.2-src.zip sha512:
>
> 228ae07dfd89f73cc7d0b10b60708db2730465dbe6022968bde6c5d7f0df9bcd7f460fe1d8012726a29f136486bdb63d1e1ba932e307380fe4c1f4db440407dd
> apache-maven-3.8.2-src.tar.gz sha512:
>
> 617377ad85ced7961f972610ed88535fd3f1ab18e104556d8a3adee7769515ee67ee3cbaff50afcffd74a443b471b806acb1ae92f91a259bc8ccaab56795baf6
>
> Binary release checksums:
> apache-maven-3.8.2-bin.zip sha512:
>
> 59ad2cbd6b7abde34ebedda94ce5631256373718e71b55202035bd1190d0144f071433f78b99e16f1204413b3eb888659e5039009e1ad0106f16332e3c62bced
> apache-maven-3.8.2-bin.tar.gz sha512:
>
> b0bf39460348b2d8eae1c861ced6c3e8a077b6e761fb3d4669be5de09490521a74db294cf031b0775b2dfcd57bd82246e42ce10904063ef8e3806222e686f222
>
> Draft for release notes:
> https://github.com/apache/maven-site/pull/251
>
>
> Guide to testing staged releases:
> http://maven.apache.org/guides/development/guide-testing-releases.html
>
> Vote open for at least 72 hours.
>
> [ ] +1
> [ ] +0
> [ ] -1
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>
Re: [VOTE] Release Apache Maven version 3.8.2
Posted by Robert Scholte <rf...@apache.org>.
+1
On 4-8-2021 22:02:18, Michael Osipov <mi...@apache.org> wrote:
Hi,
We solved 68 issues:
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12316922&version=12349965
There are still a couple of issues left in JIRA:
https://issues.apache.org/jira/issues/?jql=project%20%3D%20MNG%20AND%20resolution%20%3D%20Unresolved%20ORDER%20BY%20priority%20DESC%2C%20updated%20DESC
Staging repo:
https://repository.apache.org/content/repositories/maven-1657/
Dev dist directory:
https://dist.apache.org/repos/dist/dev/maven/maven-3/3.8.2/
Source release checksums:
apache-maven-3.8.2-src.zip sha512:
228ae07dfd89f73cc7d0b10b60708db2730465dbe6022968bde6c5d7f0df9bcd7f460fe1d8012726a29f136486bdb63d1e1ba932e307380fe4c1f4db440407dd
apache-maven-3.8.2-src.tar.gz sha512:
617377ad85ced7961f972610ed88535fd3f1ab18e104556d8a3adee7769515ee67ee3cbaff50afcffd74a443b471b806acb1ae92f91a259bc8ccaab56795baf6
Binary release checksums:
apache-maven-3.8.2-bin.zip sha512:
59ad2cbd6b7abde34ebedda94ce5631256373718e71b55202035bd1190d0144f071433f78b99e16f1204413b3eb888659e5039009e1ad0106f16332e3c62bced
apache-maven-3.8.2-bin.tar.gz sha512:
b0bf39460348b2d8eae1c861ced6c3e8a077b6e761fb3d4669be5de09490521a74db294cf031b0775b2dfcd57bd82246e42ce10904063ef8e3806222e686f222
Draft for release notes:
https://github.com/apache/maven-site/pull/251
Guide to testing staged releases:
http://maven.apache.org/guides/development/guide-testing-releases.html
Vote open for at least 72 hours.
[ ] +1
[ ] +0
[ ] -1
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: [VOTE] Release Apache Maven version 3.8.2
Posted by Karl Heinz Marbaise <kh...@gmx.de>.
Hi,
+1 from me
tested with several project and testing during the last days... without
any issue.
Kind regards
Karl Heinz Marbaise
On 04.08.21 22:02, Michael Osipov wrote:
> Hi,
>
> We solved 68 issues:
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12316922&version=12349965
>
>
> There are still a couple of issues left in JIRA:
> https://issues.apache.org/jira/issues/?jql=project%20%3D%20MNG%20AND%20resolution%20%3D%20Unresolved%20ORDER%20BY%20priority%20DESC%2C%20updated%20DESC
>
>
> Staging repo:
> https://repository.apache.org/content/repositories/maven-1657/
>
> Dev dist directory:
> https://dist.apache.org/repos/dist/dev/maven/maven-3/3.8.2/
>
> Source release checksums:
> apache-maven-3.8.2-src.zip sha512:
> 228ae07dfd89f73cc7d0b10b60708db2730465dbe6022968bde6c5d7f0df9bcd7f460fe1d8012726a29f136486bdb63d1e1ba932e307380fe4c1f4db440407dd
>
> apache-maven-3.8.2-src.tar.gz sha512:
> 617377ad85ced7961f972610ed88535fd3f1ab18e104556d8a3adee7769515ee67ee3cbaff50afcffd74a443b471b806acb1ae92f91a259bc8ccaab56795baf6
>
>
> Binary release checksums:
> apache-maven-3.8.2-bin.zip sha512:
> 59ad2cbd6b7abde34ebedda94ce5631256373718e71b55202035bd1190d0144f071433f78b99e16f1204413b3eb888659e5039009e1ad0106f16332e3c62bced
>
> apache-maven-3.8.2-bin.tar.gz sha512:
> b0bf39460348b2d8eae1c861ced6c3e8a077b6e761fb3d4669be5de09490521a74db294cf031b0775b2dfcd57bd82246e42ce10904063ef8e3806222e686f222
>
>
> Draft for release notes:
> https://github.com/apache/maven-site/pull/251
>
>
> Guide to testing staged releases:
> http://maven.apache.org/guides/development/guide-testing-releases.html
>
> Vote open for at least 72 hours.
>
> [ ] +1
> [ ] +0
> [ ] -1
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: [VOTE] Release Apache Maven version 3.8.2
Posted by Tibor Digana <ti...@apache.org>.
+1
On Wed, Aug 4, 2021 at 10:02 PM Michael Osipov <mi...@apache.org> wrote:
> Hi,
>
> We solved 68 issues:
>
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12316922&version=12349965
>
> There are still a couple of issues left in JIRA:
>
> https://issues.apache.org/jira/issues/?jql=project%20%3D%20MNG%20AND%20resolution%20%3D%20Unresolved%20ORDER%20BY%20priority%20DESC%2C%20updated%20DESC
>
> Staging repo:
> https://repository.apache.org/content/repositories/maven-1657/
>
> Dev dist directory:
> https://dist.apache.org/repos/dist/dev/maven/maven-3/3.8.2/
>
> Source release checksums:
> apache-maven-3.8.2-src.zip sha512:
>
> 228ae07dfd89f73cc7d0b10b60708db2730465dbe6022968bde6c5d7f0df9bcd7f460fe1d8012726a29f136486bdb63d1e1ba932e307380fe4c1f4db440407dd
> apache-maven-3.8.2-src.tar.gz sha512:
>
> 617377ad85ced7961f972610ed88535fd3f1ab18e104556d8a3adee7769515ee67ee3cbaff50afcffd74a443b471b806acb1ae92f91a259bc8ccaab56795baf6
>
> Binary release checksums:
> apache-maven-3.8.2-bin.zip sha512:
>
> 59ad2cbd6b7abde34ebedda94ce5631256373718e71b55202035bd1190d0144f071433f78b99e16f1204413b3eb888659e5039009e1ad0106f16332e3c62bced
> apache-maven-3.8.2-bin.tar.gz sha512:
>
> b0bf39460348b2d8eae1c861ced6c3e8a077b6e761fb3d4669be5de09490521a74db294cf031b0775b2dfcd57bd82246e42ce10904063ef8e3806222e686f222
>
> Draft for release notes:
> https://github.com/apache/maven-site/pull/251
>
>
> Guide to testing staged releases:
> http://maven.apache.org/guides/development/guide-testing-releases.html
>
> Vote open for at least 72 hours.
>
> [ ] +1
> [ ] +0
> [ ] -1
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>