You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openoffice.apache.org by bu...@apache.org on 2013/05/03 17:45:31 UTC
[Bug 122221] New: multiple slides are selected in Slide Pane if page
up from last slide
https://issues.apache.org/ooo/show_bug.cgi?id=122221
Bug ID: 122221
Issue Type: DEFECT
Summary: multiple slides are selected in Slide Pane if page up
from last slide
Classification: Application
Product: Impress
Version: AOO400-dev
Hardware: All
OS: Windows 7
Status: CONFIRMED
Severity: normal
Priority: P3
Component: ui
Assignee: issues@openoffice.apache.org
Reporter: liushenf@gmail.com
CC: issues@openoffice.apache.org
Created attachment 80634
--> https://issues.apache.org/ooo/attachment.cgi?id=80634&action=edit
screenshot
Steps to reproduce:
1. Open a presentation with multiple pages.
2. Focus to the Normal view.
3. Press Page Down to go to the last page.
4. Press Page Up.
Issue: please notice in Slide Pane that multiple pages are in selected status.
(see the attachment for screenshot)
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
[Bug 122221] Slides added to selection in Slide Pane with 'Page Up'
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122221
jkfidel@iupui.edu changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jkfidel@iupui.edu
--- Comment #3 from jkfidel@iupui.edu ---
I have replicated the bug using the steps in both the original description and
Comment 1, using the following build and configuration…
Apache OpenOffice 4.0.1; AOO401m5(Build:9714) - Rev. 1524958
Windows 7 Ultimate 64-bit, Service Pack 1
Intel Core 2 Duo T6600 2.20 GHz, 4GB RAM
A potentially simpler set of reproduction steps:
1. Create a new Impress presentation or open an existing one.
2. Be sure you are in View->Normal mode.
3. If necessary, add a new slide so that you have at least two slides.
4. Make a slide other than the first visible in the main window.
5. Set focus on the slide in Step 4 by clicking it in the main window.
6. Press Page Up.
7. Notice in the Slides Pane sidebar that two slides are now selected.
8. If the presentation has more than two slides, it is possible to select
more by continuing to press Page Up.
Some follow-up tests reveal additional implications, once multiple slides are
selected as above:
1. Hiding one of the slides will result in hiding all selected slides.
2. Deleting one of the slides will result in deleting all selected slides.
3. Formatting or adding text to one of the slides WILL NOT result in changes to
all of the selected slides.
Further, the same multiple-selection behavior does not result from pressing
Page Down.
Implications for users:
The multiple selections are unexpected. If a user does not notice it, (s)he
could inadvertently delete slides. When preparing to give a presentation, the
user could inadvertently hide too many slides, leaving out important
information for the audience.
A workaround:
Once multiple slides are inadvertently selected, click any single slide in the
slide selection pane to remove the multiple selection.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.
[Bug 122221] Slides added to selection in Slide Pane with 'Page Up'
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122221
hanya <ha...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |hanya.runo@gmail.com
--- Comment #4 from hanya <ha...@gmail.com> ---
When the current page is changed by PageDown or PageUp key pressing on the
normal view,
::sd::slidesorter::controller::Listener::propertyChange method is called to
change the current page in the slidesorter window.
In the propertyChange method,
::sd::slidesorter::controller::PageSelector::SelectPage method is called.
PageSelector::UpdateCurrentPage method is called from the SelectPage method to
make the first selected page the current page. This behaviour is used to
change the current page when multiple slides are selected in the slidesorter.
In the UpdateCurrentPage method, CurrentSlideManager::SwitchCurrentSlide method
is called and its AcquireCurrentSlide method changes mnCurrentSlideIndex
instance variable
to the index of first selected slide.
After the above sequence, CurrentSlideManager::NotifyCurrentSlideChange method
is called from propertyChange method.
In this method, if the passed slide index is not match with mnCurrentSlideIndex
instance variable,
previous slides are deselected by calling PageSelector::DeselectAllPages
method.
If PageDown button is pushed, PageSelector::UpdateCurrentPage method tries to
switch the current slide to the previous one because it is first selected
slide.
In this case, CurrentSlideManager::mnCurrentSlideIndex member keeps still
previous index of the slide.
But if PageUp button is pushed, the first selected slide is the slide that will
be
current slide because slide selection in the document model is already changed.
mnCurrentSlideIndex member has new index for the current slide and
PageSelector::DeselectAllPages method is not called from
CurrentSlideManager::NotifyCurrentSlideChange method.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.
[Bug 122221] Slides added to selection in Slide Pane with 'Page Up'
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122221
--- Comment #5 from hanya <ha...@gmail.com> ---
Created attachment 82310
--> https://issues.apache.org/ooo/attachment.cgi?id=82310&action=edit
Experimental patch to avoid calling PageSelector::SelectPage method in
Listener::propertyChange method
The comment before calling PageSelector::SelectPage method says, the calling
is required to make the selection visible. It seems this means the
following part of PageSelector::SelectPage method:
> mrSlideSorter.GetController().GetVisibleAreaManager().RequestVisible(rpDescriptor,true);
> mrSlideSorter.GetView().RequestRepaint(rpDescriptor);
Even the above is not triggered, in
CurrentSlideManager::NotifyCurrentSlideChange method,
the SelectPage method is called for current slide (already updated) if
mnCurrentSlideIndex is not yet updated.
CurrentSlideManager::mpCurrentSlide and mnCurrentSlideIndex variables are
updated
in AcquireCurrentSlide method. Threfore SelectPage method for the current slide
after deselecting all pages and the slide is shown inside the slidesorter.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.
[Bug 122221] Slides added to selection in Slide Pane with 'Page Up'
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122221
--- Comment #2 from rainerbielefeld <ra...@bielefeldundbuss.de> ---
Created attachment 80638
--> https://issues.apache.org/ooo/attachment.cgi?id=80638&action=edit
Samle Document
See Comment 1
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
[Bug 122221] Slides added to selection in Slide Pane with 'Page Up'
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122221
rainerbielefeld <ra...@bielefeldundbuss.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #80638|Samle Document |Sample Document
description| |
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
[Bug 122221] Slides added to selection in Slide Pane with 'Page Up'
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122221
Shenfeng Liu <li...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |VERIFIED
--- Comment #8 from Shenfeng Liu <li...@gmail.com> ---
Verified in build. AOO410m1(Build:9750) - Rev. 1560773 .
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.
[Bug 122221] Slides added to selection in Slide Pane if P'age Up'
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122221
rainerbielefeld <ra...@bielefeldundbuss.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords| |oooqa, regression
CC| |rainerbielefeld_ooo_qa@biel
| |efeldundbuss.de
Summary|multiple slides are |Slides added to selection
|selected in Slide Pane if |in Slide Pane if P'age Up'
|page up from last slide |
--- Comment #1 from rainerbielefeld <ra...@bielefeldundbuss.de> ---
Reproducible with server installation of "AOOo 4.0.0-Dev – English UI /
German locale [AOO400m1(Build:9700) - Rev.1476029]" on WIN7 Home Premium
(64bit)", own separate user profile:
0. If necessary create a new impress document, make slides pane visible in
'Normal View', save and close document
1. Open attached sample document form AOO Start Center - File menu
> Document with 5 slides appears, first slide is highlighted in slides pane
2. 'Page Down' 4 times:
> highlights / selects slides 2 ... 5 one after the other as expected
3. 'Page Up' 4 times
Expected: highlights / selects slides 4 ... 1 one after the other
Actual: ADDS 4 ... 1 to selection, all slides in Slides Pane will become
selected.
Additional info
a) Not reproducible if you click slide 5 as step 2
b) It seems that the effect disappears after any mouse click on a slide in the
Slides Pane; reappears after click on any other Tab than 'Normal' and Back to
Normal'
c) I did not find a setting related to this
d) already reproducible with 3.4.1 with a little different proceeding
(because Slide 1 will not be selected after Step 1): Insert a
step 1.1 and 'click Tab "Outline" -> Click Tab "Normal"'
e) not related to "Last slide". Also reproducible:
variant e1) In step 2 only 2 times 'Page down'
variant e2) In Step 2 in Slide Pane 'Click Slide 3 -> 'click Tab "Outline"
-> Click Tab "Normal"'
f) Also reproducible in Draw, so that might be the more appropriate Product?
Already was a problem with 3.4.1. and 3.4.0, but NOT with OOo 3.1.1, so
REGRESSION
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
[Bug 122221] Slides added to selection in Slide Pane with 'Page Up'
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122221
hanya <ha...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|CONFIRMED |RESOLVED
Resolution|--- |FIXED
Target Milestone|--- |4.1.0
--- Comment #7 from hanya <ha...@gmail.com> ---
Fixed on trunk.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.
[Bug 122221] Slides added to selection in Slide Pane with 'Page Up'
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122221
--- Comment #6 from SVN Robot <sv...@dev.null.org> ---
"hanya" committed SVN revision 1559671 into trunk:
#i122221# fix slide selected in Slide Pane with Page Up
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.
[Bug 122221] Slides added to selection in Slide Pane with 'Page Up'
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122221
rainerbielefeld <ra...@bielefeldundbuss.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|Slides added to selection |Slides added to selection
|in Slide Pane if P'age Up' |in Slide Pane with 'Page
| |Up'
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.