You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by ma...@apache.org on 2012/08/16 21:56:48 UTC
svn commit: r1374025 - in /tomcat/trunk/java/org/apache/coyote/spdy:
SpdyProcessor.java SpdyProxyProtocol.java
Author: markt
Date: Thu Aug 16 19:56:48 2012
New Revision: 1374025
URL: http://svn.apache.org/viewvc?rev=1374025&view=rev
Log:
Code clean-up
- UCDetector use of final
- Reduce visibility
Modified:
tomcat/trunk/java/org/apache/coyote/spdy/SpdyProcessor.java
tomcat/trunk/java/org/apache/coyote/spdy/SpdyProxyProtocol.java
Modified: tomcat/trunk/java/org/apache/coyote/spdy/SpdyProcessor.java
URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/spdy/SpdyProcessor.java?rev=1374025&r1=1374024&r2=1374025&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/coyote/spdy/SpdyProcessor.java (original)
+++ tomcat/trunk/java/org/apache/coyote/spdy/SpdyProcessor.java Thu Aug 16 19:56:48 2012
@@ -52,7 +52,6 @@ import org.apache.tomcat.util.net.Socket
* tomcat servlet.
*
* Based on the AJP processor.
- *
*/
public class SpdyProcessor extends AbstractProcessor<Object> implements
Runnable {
@@ -63,22 +62,22 @@ public class SpdyProcessor extends Abstr
// TODO: find a way to inject an OutputBuffer, or interecept close() -
// so we can send FIN in the last data packet.
- private SpdyConnection spdy;
+ private final SpdyConnection spdy;
// Associated spdy stream
- SpdyStream spdyStream;
+ private SpdyStream spdyStream;
- ByteChunk keyBuffer = new ByteChunk();
+ private final ByteChunk keyBuffer = new ByteChunk();
- boolean error = false;
+ private boolean error = false;
private boolean finished;
- SpdyFrame inFrame = null;
+ private SpdyFrame inFrame = null;
- boolean outClosed = false;
+ private boolean outClosed = false;
- boolean outCommit = false;
+ private boolean outCommit = false;
public SpdyProcessor(SpdyConnection spdy, AbstractEndpoint endpoint) {
super(endpoint);
@@ -204,7 +203,7 @@ public class SpdyProcessor extends Abstr
response.finish();
}
- static final byte[] EMPTY = new byte[0];
+ private static final byte[] EMPTY = new byte[0];
// Processor implementation
Modified: tomcat/trunk/java/org/apache/coyote/spdy/SpdyProxyProtocol.java
URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/spdy/SpdyProxyProtocol.java?rev=1374025&r1=1374024&r2=1374025&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/coyote/spdy/SpdyProxyProtocol.java (original)
+++ tomcat/trunk/java/org/apache/coyote/spdy/SpdyProxyProtocol.java Thu Aug 16 19:56:48 2012
@@ -52,8 +52,8 @@ import org.apache.tomcat.util.net.Socket
public class SpdyProxyProtocol extends AbstractProtocol {
private static final Log log = LogFactory.getLog(SpdyProxyProtocol.class);
- JIoEndpoint.Handler cHandler = new TomcatJioHandler();
- SpdyContext spdyContext;
+ private final JIoEndpoint.Handler cHandler = new TomcatJioHandler();
+ private SpdyContext spdyContext;
public SpdyProxyProtocol() {
endpoint = new JIoEndpoint();
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org