You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "yyqdbngt (via GitHub)" <gi...@apache.org> on 2026/09/05 16:11:51 UTC
[PR] test: cover deleteByRuleId and runtime projection in MybatisPlusAlertStateRepository [rocketmq-dashboard]
yyqdbngt opened a new pull request, #3451:
URL: https://github.com/apache/rocketmq-dashboard/pull/3451
### Summary
`MybatisPlusAlertStateRepository` persists per-rule state, acknowledges firings, lists active states and projects rule runtime rows. The suite covered find/save/acknowledge/findActive but not state cleanup or the runtime projection.
### Changes
- `deleteByRuleId` removes rows scoped to the rule id; a `null` id is a no-op
- `findRuntimeByRuleIds` projects stored states into `AlertRuleRuntimeVO`, deriving `nextReminderAt` from the rule's reminder interval and last notification time
### Testing
`mvn test -Dtest=MybatisPlusAlertStateRepositoryTest` passes: 7 tests, 0 failures (up from 4).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test: cover deleteByRuleId and runtime projection in MybatisPlusAlertStateRepository [rocketmq-dashboard]
Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins closed pull request #3451: test: cover deleteByRuleId and runtime projection in MybatisPlusAlertStateRepository
URL: https://github.com/apache/rocketmq-dashboard/pull/3451
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org