[GitHub] anirudhacharya commented on a change in pull request #12646: ONNX export: Fully connected operator with no bias

[GitBox <gi...@apache.org>]

anirudhacharya commented on a change in pull request #12646: ONNX export: Fully connected operator with no bias
URL: https://github.com/apache/incubator-mxnet/pull/12646#discussion_r223532329
 
 

 ##########
 File path: python/mxnet/contrib/onnx/mx2onnx/_op_translations.py
 ##########
 @@ -753,7 +789,7 @@ def convert_pooling(node, **kwargs):
     pool_types = {"max": "MaxPool", "avg": "AveragePool"}
     global_pool_types = {"max": "GlobalMaxPool", "avg": "GlobalAveragePool"}
 
-    if global_pool:
+    if global_pool == 1:
 
 Review comment:
   `if global_pool` should still be fine. why this change?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services