You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by spmallette <gi...@git.apache.org> on 2016/04/19 20:18:36 UTC

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1269 Additional SSL op...

GitHub user spmallette opened a pull request:

    https://github.com/apache/incubator-tinkerpop/pull/292

    TINKERPOP-1269 Additional SSL options for Driver

    This is a really boring PR - just added some more flexibility to the driver to allow the user to do more SSL stuff. Existing SSL settings still works as before:
    
    ```text
    gremlin> :remote connect tinkerpop.server conf/remote-secure.yaml
    WARN  org.apache.tinkerpop.gremlin.driver.Channelizer$AbstractChannelizer  - SSL configured without a trustCertChainFile and thus trusts all certificates without verification (not suitable for production)
    ==>Connected - localhost/127.0.0.1:8182
    gremlin> :remote console
    ==>All scripts will now be sent to Gremlin Server - [localhost/127.0.0.1:8182] - type ':remote console' to return to local mode
    gremlin> 1 + 1
    ==>2
    ```
    
    Tests for SSL still working after:
    
    ```text
    $ mvn clean install && mvn verify -pl gremlin-server -DskipIntegrationTests=false -DincludeNeo4j
    ``` 
    
    VOTE +1

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apache/incubator-tinkerpop TINKERPOP-1269

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-tinkerpop/pull/292.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #292
    
----
commit f779cf9227c93fa5a2e4c3716ff460e1ed8f97a4
Author: Stephen Mallette <sp...@genoprime.com>
Date:   2016-04-19T17:53:35Z

    Added additional SSL configuration options for Gremlin Driver.
    
    Specifically added: keyPassword, keyFile and keyCertChainFile.

commit 38b474a7c7ef1e4dd7a86767daa4c7644fec707d
Author: Stephen Mallette <sp...@genoprime.com>
Date:   2016-04-19T18:02:12Z

    Added docs for new SSL settings on the driver side.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1269 Additional SSL op...

Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on the pull request:

    https://github.com/apache/incubator-tinkerpop/pull/292#issuecomment-212121749
  
    Thought of something I should add. Closing until i get that update in


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1269 Additional SSL op...

Posted by spmallette <gi...@git.apache.org>.
Github user spmallette closed the pull request at:

    https://github.com/apache/incubator-tinkerpop/pull/292


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---