You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@griffin.apache.org by GitBox <gi...@apache.org> on 2020/01/20 02:41:23 UTC
[GitHub] [griffin] XiaoyuBD opened a new pull request #566: optimize get
metric maps in 'MetricWriteStep'
XiaoyuBD opened a new pull request #566: optimize get metric maps in 'MetricWriteStep'
URL: https://github.com/apache/griffin/pull/566
**Why/What changes?**
In 'MetricWriteStep.getMetricMaps()' the dataframe was transformed to json rdd, and then collect, and then transformed to Seq[Map].
It's not elegant and hard to understand. More optimized way is to collect it first, and then transform it to Seq[Map] directly.
**How was this patch tested?**
Griffin test suite.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [griffin] wankunde commented on issue #566: optimize get metric
maps in 'MetricWriteStep'
Posted by GitBox <gi...@apache.org>.
wankunde commented on issue #566: optimize get metric maps in 'MetricWriteStep'
URL: https://github.com/apache/griffin/pull/566#issuecomment-584015238
LGTM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [griffin] wankunde commented on issue #566: optimize get metric
maps in 'MetricWriteStep'
Posted by GitBox <gi...@apache.org>.
wankunde commented on issue #566: optimize get metric maps in 'MetricWriteStep'
URL: https://github.com/apache/griffin/pull/566#issuecomment-584015751
@XiaoyuBD Thanks for your contribution. Any test case will be better.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [griffin] asfgit closed pull request #566: optimize get metric maps
in 'MetricWriteStep'
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #566: optimize get metric maps in 'MetricWriteStep'
URL: https://github.com/apache/griffin/pull/566
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services