You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2023/01/11 23:17:32 UTC
[GitHub] [superset] justinpark opened a new pull request, #22695: fix(sqllab): Invalid schema fetch for deprecated value @justinpark
justinpark opened a new pull request, #22695:
URL: https://github.com/apache/superset/pull/22695
### SUMMARY
When a selected schema option in a old saved tab has been deprecated, it would fail to query since the selected schema is no longer existed.
This commit adds the validation logic for the current selected schema option and then discard the schema option if no longer existed.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
After:
<img width="398" alt="Screenshot_2023-01-11_at_3_14_23_PM" src="https://user-images.githubusercontent.com/1392866/211938466-223b5473-be41-4de1-89e4-6cc19021afc1.png">
No error thrown
Before:
<img width="415" alt="Screenshot_2023-01-09_at_3_55_57_PM" src="https://user-images.githubusercontent.com/1392866/211938201-af50da2a-3a5b-4fec-b479-e15e98eb2060.png">
<img width="900" alt="Superset-2" src="https://user-images.githubusercontent.com/1392866/211938150-e2d3d9a7-1566-4787-ab9e-cde8a645de16.png">
<img width="746" alt="superset-goalie_-_Airbnb_-_Slack" src="https://user-images.githubusercontent.com/1392866/211938400-bfb1560a-272e-4ea5-b450-261e7ab42b00.png">
### TESTING INSTRUCTIONS
- Select a schema from the list and then close
- delete the above selected schema
- reopen the sqllab and check the error
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on pull request #22695: fix(sqllab): Invalid schema fetch for deprecated value
Posted by GitBox <gi...@apache.org>.
rusackas commented on PR #22695:
URL: https://github.com/apache/superset/pull/22695#issuecomment-1397334851
I didn't merge this only because @justinpark hadn't answered an open question from @ktmud. Hopefully he can follow up on this later. Merging!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] EugeneTorap commented on pull request #22695: fix(sqllab): Invalid schema fetch for deprecated value
Posted by GitBox <gi...@apache.org>.
EugeneTorap commented on PR #22695:
URL: https://github.com/apache/superset/pull/22695#issuecomment-1387020225
@michael-s-molina Merge it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #22695: fix(sqllab): Invalid schema fetch for deprecated value
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #22695:
URL: https://github.com/apache/superset/pull/22695#issuecomment-1381029417
# [Codecov](https://codecov.io/gh/apache/superset/pull/22695?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#22695](https://codecov.io/gh/apache/superset/pull/22695?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3cd4f61) into [master](https://codecov.io/gh/apache/superset/commit/159dcd7e62e9466e2da4ad81cd25c06770fb4a5e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (159dcd7) will **decrease** coverage by `0.03%`.
> The diff coverage is `100.00%`.
```diff
@@ Coverage Diff @@
## master #22695 +/- ##
==========================================
- Coverage 67.14% 67.11% -0.04%
==========================================
Files 1869 1869
Lines 71523 71503 -20
Branches 7814 7823 +9
==========================================
- Hits 48022 47987 -35
- Misses 21460 21489 +29
+ Partials 2041 2027 -14
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `53.92% <100.00%> (-0.07%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/22695?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...d/src/SqlLab/components/SqlEditorLeftBar/index.tsx](https://codecov.io/gh/apache/superset/pull/22695?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvckxlZnRCYXIvaW5kZXgudHN4) | `53.52% <ø> (+1.40%)` | :arrow_up: |
| [superset-frontend/src/SqlLab/types.ts](https://codecov.io/gh/apache/superset/pull/22695?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi90eXBlcy50cw==) | `57.14% <ø> (ø)` | |
| [superset-frontend/src/SqlLab/actions/sqlLab.js](https://codecov.io/gh/apache/superset/pull/22695?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9hY3Rpb25zL3NxbExhYi5qcw==) | `63.93% <100.00%> (+0.37%)` | :arrow_up: |
| [...-frontend/src/SqlLab/hooks/useQueryEditor/index.ts](https://codecov.io/gh/apache/superset/pull/22695?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9ob29rcy91c2VRdWVyeUVkaXRvci9pbmRleC50cw==) | `100.00% <100.00%> (ø)` | |
| [superset-frontend/src/setup/setupFormatters.ts](https://codecov.io/gh/apache/superset/pull/22695?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwRm9ybWF0dGVycy50cw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupClient.ts](https://codecov.io/gh/apache/superset/pull/22695?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ2xpZW50LnRz) | `0.00% <0.00%> (-70.00%)` | :arrow_down: |
| [superset-frontend/src/preamble.ts](https://codecov.io/gh/apache/superset/pull/22695?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ByZWFtYmxlLnRz) | `0.00% <0.00%> (-44.00%)` | :arrow_down: |
| [...rontend/src/components/DeprecatedSelect/styles.tsx](https://codecov.io/gh/apache/superset/pull/22695?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRGVwcmVjYXRlZFNlbGVjdC9zdHlsZXMudHN4) | `52.83% <0.00%> (-28.31%)` | :arrow_down: |
| [...erset-frontend/src/profile/components/Security.tsx](https://codecov.io/gh/apache/superset/pull/22695?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Byb2ZpbGUvY29tcG9uZW50cy9TZWN1cml0eS50c3g=) | `75.00% <0.00%> (-25.00%)` | :arrow_down: |
| [...erset-frontend/src/profile/components/UserInfo.tsx](https://codecov.io/gh/apache/superset/pull/22695?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Byb2ZpbGUvY29tcG9uZW50cy9Vc2VySW5mby50c3g=) | `75.00% <0.00%> (-25.00%)` | :arrow_down: |
| ... and [80 more](https://codecov.io/gh/apache/superset/pull/22695?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas merged pull request #22695: fix(sqllab): Invalid schema fetch for deprecated value
Posted by GitBox <gi...@apache.org>.
rusackas merged PR #22695:
URL: https://github.com/apache/superset/pull/22695
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org