You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Blair Zajac <bl...@orcaware.com> on 2012/09/29 21:29:24 UTC
Re: svn commit: r1391641 - /subversion/trunk/subversion/libsvn_subr/cache-memcache.c
On 09/28/2012 01:34 PM, cmpilato@apache.org wrote:
> Author: cmpilato
> Date: Fri Sep 28 20:34:50 2012
> New Revision: 1391641
>
> URL: http://svn.apache.org/viewvc?rev=1391641&view=rev
> Log:
> * subversion/libsvn_subr/cache-memcache.c
> (add_memcache_server): Convert time-to-live value from seconds to
> the expected microseconds.
>
> ==============================================================================
> --- subversion/trunk/subversion/libsvn_subr/cache-memcache.c (original)
> +++ subversion/trunk/subversion/libsvn_subr/cache-memcache.c Fri Sep 28 20:34:50 2012
> @@ -470,7 +470,7 @@ add_memcache_server(const char *name,
> 0, /* min connections */
> 5, /* soft max connections */
> 10, /* hard max connections */
> - 50, /* connection time to live (secs) */
> + apr_time_from_sec(50), /* ttl (ms) */
Hi Mike,
ms is for milliseconds and µs for microseconds, I suggest changing 'ms'
to 'microseconds', as 'us' would be confusing.
Blair
Re: svn commit: r1391641 - /subversion/trunk/subversion/libsvn_subr/cache-memcache.c
Posted by "C. Michael Pilato" <cm...@collab.net>.
On 09/29/2012 03:29 PM, Blair Zajac wrote:
> On 09/28/2012 01:34 PM, cmpilato@apache.org wrote:
>> Author: cmpilato
>> Date: Fri Sep 28 20:34:50 2012
>> New Revision: 1391641
>>
>> URL: http://svn.apache.org/viewvc?rev=1391641&view=rev
>> Log:
>> * subversion/libsvn_subr/cache-memcache.c
>> (add_memcache_server): Convert time-to-live value from seconds to
>> the expected microseconds.
>>
>
>> ==============================================================================
>>
>> --- subversion/trunk/subversion/libsvn_subr/cache-memcache.c (original)
>> +++ subversion/trunk/subversion/libsvn_subr/cache-memcache.c Fri Sep 28
>> 20:34:50 2012
>> @@ -470,7 +470,7 @@ add_memcache_server(const char *name,
>> 0, /* min connections */
>> 5, /* soft max connections */
>> 10, /* hard max connections */
>> - 50, /* connection time to live
>> (secs) */
>> + apr_time_from_sec(50), /* ttl (ms) */
>
> Hi Mike,
>
> ms is for milliseconds and µs for microseconds, I suggest changing 'ms' to
> 'microseconds', as 'us' would be confusing.
That's what I get for focusing on compressing code rather than, you know,
thinking. Fixed. (Thanks, Blair.)
--
C. Michael Pilato <cm...@collab.net>
CollabNet <> www.collab.net <> Enterprise Cloud Development