You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/04/11 13:28:25 UTC

[GitHub] [arrow] raulcd commented on a diff in pull request #12854: ARROW-15893: [Python] Exercise Python minimal build examples on CI

raulcd commented on code in PR #12854:
URL: https://github.com/apache/arrow/pull/12854#discussion_r847327663


##########
python/examples/minimal_build/README.md:
##########
@@ -34,10 +34,21 @@ docker build -t arrow_fedora_minimal -f Dockerfile.fedora .
 Then build PyArrow with conda or pip, respectively:
 ```
 # With pip
-docker run --rm -t -i -v $PWD:/io arrow_fedora_minimal /io/build_venv.sh
+docker run --rm -t -i -v $PWD:/io -v $PWD/../../..:/arrow arrow_fedora_minimal /io/build_venv.sh
 
 # With conda
-docker run --rm -t -i -v $PWD:/io arrow_fedora_minimal /io/build_conda.sh
+docker run --rm -t -i -v $PWD:/io -v $PWD/../../..:/arrow arrow_fedora_minimal /io/build_conda.sh
+```
+
+Alternatively you can use [Docker Compose][docker-compose] to build and run using:

Review Comment:
   For the reviewer, do you think it would be better to only document the Docker compose interface as we do on the CPP minimal build instead of having `docker`, `docker-compose` and `podman`? See:
   https://github.com/apache/arrow/blob/master/cpp/examples/minimal_build/README.md#running-the-example



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org