You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@ofbiz.apache.org by "Jacques Le Roux (Jira)" <ji...@apache.org> on 2022/07/10 08:58:00 UTC

[jira] [Commented] (OFBIZ-12662) getDisplayGrandTotal - double tax

    [ https://issues.apache.org/jira/browse/OFBIZ-12662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17564654#comment-17564654 ] 

Jacques Le Roux commented on OFBIZ-12662:
-----------------------------------------

Hi Ingo,

Any reasons why you did not add a patch?

> getDisplayGrandTotal - double tax
> ---------------------------------
>
>                 Key: OFBIZ-12662
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-12662
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: order
>    Affects Versions: Upcoming Branch
>            Reporter: Ingo Wolfmayr
>            Priority: Major
>             Fix For: Upcoming Branch
>
>
> The method getDisplayGrandTotal() from ShoppingCart.java adds tax twice.
> this.getDisplaySubTotal() already inclued item taxes.
> {code:java}
> /** Returns the total from the cart, including tax/shipping. */
>     public BigDecimal getDisplayGrandTotal() {
>         return this.getDisplaySubTotal().add(this.getTotalShipping()).add(this.getTotalSalesTax())
>                 .add(this.getOrderOtherAdjustmentTotal()).add(this.getOrderGlobalAdjustments());
>     }{code}
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)