You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/04/25 11:00:22 UTC

[GitHub] [arrow] edponce commented on a diff in pull request #12096: ARROW-15277: [Python] Use Make to create ChunkedArray and remove checks

edponce commented on code in PR #12096:
URL: https://github.com/apache/arrow/pull/12096#discussion_r857505629


##########
python/pyarrow/tests/test_compute.py:
##########
@@ -1187,8 +1187,8 @@ def test_drop_null(ty, values):
 
 
 def test_drop_null_chunked_array():
-    arr = pa.chunked_array([["a", None], ["c", "d", None], [None], []])
-    expected_drop = pa.chunked_array([["a"], ["c", "d"], [], []])
+    arr = pa.chunked_array([[None, None], [None], []])

Review Comment:
   In C++, a ChunkedArray has to have all Arrays of the same type, but [the Python API allowed coercion of `None`](https://github.com/apache/arrow/pull/12096/files#diff-cede36e8e2e0eb6e6e1ee21745db9687174527f463520c6e6d8b9e8f957bf304L1313)
   ```c++
   ["a", None] --> StringType
   [None] --> NullType
   [] --> NullType
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org