[GitHub] [iceberg] nastra commented on a diff in pull request #6146: Build: Enable revapi on core/parquet/orc/common/data modules

[GitBox <gi...@apache.org>]

nastra commented on code in PR #6146:
URL: https://github.com/apache/iceberg/pull/6146#discussion_r1017593969


##########
core/src/main/java/org/apache/iceberg/BaseReplacePartitions.java:
##########
@@ -79,6 +79,20 @@ public ReplacePartitions validateNoConflictingData() {
     return this;
   }
 
+  /**
+   * Validate the current metadata.
+   *
+   * <p>Child operations can override this to add custom validation.
+   *
+   * @param currentMetadata current table metadata to validate
+   * @deprecated Will be removed in 1.2.0, use {@link SnapshotProducer#validate(TableMetadata,
+   *     Snapshot)}.
+   */
+  @Deprecated
+  public void validate(TableMetadata currentMetadata) {

Review Comment:
   we need to add separate Deprecations for `validate()` and `apply` here and in a few other places, because their visibility has been `public` and not `protected` (as it is defined in `SnapshotProducer`)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org