You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2019/05/30 04:23:02 UTC
[kudu-CR] a small cleanup: removed unnecessary semicolons
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13462
Change subject: a small cleanup: removed unnecessary semicolons
......................................................................
a small cleanup: removed unnecessary semicolons
The motivation for this change was finding a few warnings by QtCreator's
built-in static analysis tool while browsing through the code.
This patch does not contain any functional changes.
Change-Id: I62cab3048cb9556a546625393cc5b73374a3e088
---
M src/kudu/client/client-unittest.cc
M src/kudu/clock/hybrid_clock-test.cc
M src/kudu/consensus/consensus_meta.cc
M src/kudu/consensus/consensus_queue.cc
M src/kudu/consensus/time_manager.cc
M src/kudu/gutil/casts.h
M src/kudu/hms/hms_client.h
M src/kudu/integration-tests/mini_cluster_fs_inspector.cc
M src/kudu/integration-tests/stop_tablet-itest.cc
M src/kudu/integration-tests/timestamp_advancement-itest.cc
M src/kudu/tablet/tablet_replica-test.cc
M src/kudu/tools/ksck_checksum.cc
M src/kudu/tools/kudu-admin-test.cc
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/util/debug/trace_event_impl.cc
M src/kudu/util/flag_tags.h
M src/kudu/util/net/net_util.cc
M src/kudu/util/thread.cc
M src/kudu/util/user.cc
19 files changed, 28 insertions(+), 28 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/62/13462/1
--
To view, visit http://gerrit.cloudera.org:8080/13462
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I62cab3048cb9556a546625393cc5b73374a3e088
Gerrit-Change-Number: 13462
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] a small cleanup: removed unnecessary semicolons
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13462 )
Change subject: a small cleanup: removed unnecessary semicolons
......................................................................
a small cleanup: removed unnecessary semicolons
The motivation for this change was finding a few warnings by QtCreator's
built-in static analysis tool while browsing through the code.
This patch does not contain any functional changes.
Change-Id: I62cab3048cb9556a546625393cc5b73374a3e088
Reviewed-on: http://gerrit.cloudera.org:8080/13462
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Kudu Jenkins
---
M src/kudu/client/client-unittest.cc
M src/kudu/clock/hybrid_clock-test.cc
M src/kudu/consensus/consensus_meta.cc
M src/kudu/consensus/consensus_queue.cc
M src/kudu/consensus/time_manager.cc
M src/kudu/gutil/casts.h
M src/kudu/hms/hms_client.h
M src/kudu/integration-tests/mini_cluster_fs_inspector.cc
M src/kudu/integration-tests/stop_tablet-itest.cc
M src/kudu/integration-tests/timestamp_advancement-itest.cc
M src/kudu/tablet/tablet_replica-test.cc
M src/kudu/tools/ksck_checksum.cc
M src/kudu/tools/kudu-admin-test.cc
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/util/debug/trace_event_impl.cc
M src/kudu/util/flag_tags.h
M src/kudu/util/net/net_util.cc
M src/kudu/util/thread.cc
M src/kudu/util/user.cc
19 files changed, 28 insertions(+), 28 deletions(-)
Approvals:
Adar Dembo: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/13462
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I62cab3048cb9556a546625393cc5b73374a3e088
Gerrit-Change-Number: 13462
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] a small cleanup: removed unnecessary semicolons
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13462 )
Change subject: a small cleanup: removed unnecessary semicolons
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/13462
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I62cab3048cb9556a546625393cc5b73374a3e088
Gerrit-Change-Number: 13462
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 30 May 2019 04:29:53 +0000
Gerrit-HasComments: No