You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@devlake.apache.org by GitBox <gi...@apache.org> on 2022/10/19 13:58:30 UTC

[GitHub] [incubator-devlake] e2corporation commented on a diff in pull request #3477: refactor: add providerId to entity type data models

e2corporation commented on code in PR #3477:
URL: https://github.com/apache/incubator-devlake/pull/3477#discussion_r999497770


##########
config-ui/src/models/GithubProject.js:
##########
@@ -47,6 +48,7 @@ class GitHubProject {
 
     this.useApi = data?.useApi || false
     this.variant = data?.variant || 'project'

Review Comment:
   Reason outlined in ticket #3411, https://github.com/apache/incubator-devlake/issues/3411. Maybe it get's removed in the future, for now it would be ideal to determine providerId without dependency to $activeProvider.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org