You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/01/28 18:46:19 UTC

[GitHub] [arrow] pitrou commented on a change in pull request #9349: ARROW-10056: [C++][Python] PyArrow fails to read (valid) Feather v2 f…

pitrou commented on a change in pull request #9349:
URL: https://github.com/apache/arrow/pull/9349#discussion_r566327155



##########
File path: cpp/src/arrow/ipc/reader.cc
##########
@@ -1053,7 +1053,7 @@ class RecordBatchFileReaderImpl : public RecordBatchFileReader {
         file_->ReadAt(footer_offset_ - footer_length - file_end_size, footer_length));
 
     auto data = footer_buffer_->data();
-    flatbuffers::Verifier verifier(data, footer_buffer_->size(), 128);
+    flatbuffers::Verifier verifier(data, footer_buffer_->size(), 128, UINT_MAX);

Review comment:
       No, like this:
   ```c++
   
   flatbuffers::Verifier verifier(data, footer_buffer_->size(), /*max_depth=*/128, /*max_tables=*/UINT_MAX);
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org