You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2022/06/30 10:25:13 UTC

[GitHub] [pinot] gortiz commented on issue #8776: [Flaky Test] PinotTaskManagerStatelessTest.testPinotTaskManagerSchedulerWithUpdate()

gortiz commented on issue #8776:
URL: https://github.com/apache/pinot/issues/8776#issuecomment-1171042743

   After some time thinking about this test and understanding how it works, I think the test was designed with this scenario in mind:
   
   
   ```mermaid
   
   sequenceDiagram
       Test->>+Controller: update table config (0 */20 * ? * * *)
       Controller->>+Helix: update table config (0 */20 * ? * * *)
       Helix->>Helix: Change ideal state to (0 */20 * ? * * *)
       Helix->>-Controller: Ok
       Controller->>-Test: Ok
       
       Test->>+Controller: get job info
       Controller->>+Helix: get job info
       Helix->>-Controller: updated job info (0 */20 * ? * * *)
       Controller->>-Test: updated job info (0 */20 * ? * * *)
       
   ```
   
   But I think Helix does not guaranteed that the sequence and sometimes, due to the lack of resources in GHA, we may find this scenario:
   
   ```mermaid
   
   sequenceDiagram
       Test->>+Controller: update table config (0 */20 * ? * * *)
       Controller->>+Helix: update table config (0 */20 * ? * * *)
       Helix->>Controller: Ok
       Controller->>-Test: Ok
       
       Test->>+Controller: get job info
       Controller->>+Helix: get job info
       Helix->>-Controller: updated job info (0 */10 * ? * * *)
       
       Helix->>-Helix: Change ideal state (0 */20 * ? * * *)
       
       Controller->>-Test: updated job info (0 */10 * ? * * *)
       
   ```
   
   If that is the case, the palliative solution is to retry the validation with some timeout.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org