You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2018/08/17 09:30:32 UTC

[GitHub] kaxil commented on issue #3755: [AIRFLOW-2905] Fix get job API endpoint

kaxil commented on issue #3755: [AIRFLOW-2905] Fix get job API endpoint
URL: https://github.com/apache/incubator-airflow/pull/3755#issuecomment-413811314
 
 
   @fenglu-g Can you modify the associated tests?
   
   Check the failing Travis:
   ```
   ======================================================================
   16) FAIL: test_dataflow_job_init_with_job_id (tests.contrib.hooks.test_gcp_dataflow_hook.DataFlowJobTest)
   ----------------------------------------------------------------------
      Traceback (most recent call last):
       tests/contrib/hooks/test_gcp_dataflow_hook.py line 274 in test_dataflow_job_init_with_job_id
         mock_jobs.get.assert_called_with(projectId=TEST_PROJECT, jobId=TEST_JOB_ID)
       .tox/py27-backend_mysql/lib/python2.7/site-packages/mock/mock.py line 925 in assert_called_with
         raise AssertionError('Expected call: %s\nNot called' % (expected,))
      AssertionError: Expected call: get(jobId='test-job-id', projectId='test-project')
      Not called
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services