[jira] [Commented] (NIFI-4143) Make configurable maximum number of concurrent requests

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/NIFI-4143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16075303#comment-16075303 ] 

ASF GitHub Bot commented on NIFI-4143:
--------------------------------------

Github user mcgilman commented on the issue:

    https://github.com/apache/nifi/pull/1962
  
    @pvillard31 Just started reviewing this PR. I'm wondering if the property should be associated with the cluster section instead of the web properties. This property is only relevant when clustered and am concerned it may be confusing being colocated with the jetty thread configuration. Since that thread pool drives the size of the thread pool that Jetty uses it could be confused with the maximum number of concurrent requests. It might make sense to associate this property with other request replication properties. 
    
    For instance the replication thread pool size:
    
    ```
    nifi.cluster.node.protocol.threads=${nifi.cluster.node.protocol.threads}
    nifi.cluster.node.protocol.max.threads=${nifi.cluster.node.protocol.max.threads}
    ```
    
    Or the replication timeouts:
    
    ```
    nifi.cluster.node.connection.timeout=${nifi.cluster.node.connection.timeout}
    nifi.cluster.node.read.timeout=${nifi.cluster.node.read.timeout}
    ```
    
    Thoughts?


> Make configurable maximum number of concurrent requests
> -------------------------------------------------------
>
>                 Key: NIFI-4143
>                 URL: https://issues.apache.org/jira/browse/NIFI-4143
>             Project: Apache NiFi
>          Issue Type: Improvement
>          Components: Core Framework
>            Reporter: Pierre Villard
>            Assignee: Pierre Villard
>
> At the moment, the maximum number of concurrent requests is hard coded in {{ThreadPoolRequestReplicator}}
> https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-cluster/src/main/java/org/apache/nifi/cluster/coordination/http/replication/ThreadPoolRequestReplicator.java
> The value is equal to 100.
> In some situations where multiple factors are combined (large cluster, S2S to load balance data in the cluster, multiple users accessing the UI), the limit can be reached and the UI may become intermittently unavailable with the message: "There are too many outstanding HTTP requests with a total 100 outstanding requests".
> This value should be configurable in nifi.properties allowing users to increase the value.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)