You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "morningman (via GitHub)" <gi...@apache.org> on 2023/04/27 05:58:57 UTC

[GitHub] [doris] morningman commented on a diff in pull request #18615: [Feature](orc-reader) Implements ORC lazy materialization.

morningman commented on code in PR #18615:
URL: https://github.com/apache/doris/pull/18615#discussion_r1174421614


##########
be/CMakeLists.txt:
##########
@@ -649,11 +649,11 @@ include_directories(
     ${THIRDPARTY_DIR}/include
     ${GPERFTOOLS_HOME}/include
 )
-include_directories($ENV{JAVA_HOME}/include)
+include_directories(/mnt/datadisk0/chenqi/jdk1.8.0_131/include)

Review Comment:
   fix it



##########
build.sh:
##########
@@ -247,16 +247,13 @@ if [[ ! -f "${DORIS_THIRDPARTY}/installed/lib/libbacktrace.a" ]]; then
     fi
 fi
 
-if [[ ! -f "${DORIS_HOME}/be/src/apache-orc/README.md" ]]; then
+if [[ ! -f "${DORIS_HOME}/be/src/apache-orc/README.md " ]]; then

Review Comment:
   ```suggestion
   if [[ ! -f "${DORIS_HOME}/be/src/apache-orc/README.md" ]]; then
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org