You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@syncope.apache.org by DimaAy <gi...@git.apache.org> on 2018/05/02 07:51:29 UTC
[GitHub] syncope pull request #74: [SYNCOPE-1270] implementation for OpenID Connect f...
GitHub user DimaAy opened a pull request:
https://github.com/apache/syncope/pull/74
[SYNCOPE-1270] implementation for OpenID Connect for Admin Console and Enduser
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/DimaAy/syncope 2_0_X
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/syncope/pull/74.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #74
----
commit a7267019bda61f5aaf98cf91d0b08447c383c2e7
Author: dayash <di...@...>
Date: 2018-05-02T07:50:13Z
[SYNCOPE-1270] implementation for OpenID Connect for Admin Console and Enduser
----
---
[GitHub] syncope issue #74: [SYNCOPE-1270] implementation for OpenID Connect for Admi...
Posted by ilgrosso <gi...@git.apache.org>.
Github user ilgrosso commented on the issue:
https://github.com/apache/syncope/pull/74
Thanks @DimaAy the code looks almost complete, and it's also working.
I would just make some enhancements to the Admin Console management:
1. When adding / editing an OIDC provider, validate all values that are expected to be URIs *before* saving
1. Move the `Has Discovery Document` flag after `Issuer`
1. When editing an existing ODIC provider, make all the second step's fields as read-only, and show them all despite the Discovery Document was used during create
Side note: I see there is no yet support for [Logout](https://medium.com/@robert.broeckelmann/openid-connect-logout-eccc73df758f), which is provided at least by [Azure](https://docs.microsoft.com/en-us/windows-server/identity/ad-fs/development/ad-fs-logout-openid-connect), maybe you can submit a new PR for that after the current ones gets merged.
---
[GitHub] syncope issue #74: [SYNCOPE-1270] implementation for OpenID Connect for Admi...
Posted by ilgrosso <gi...@git.apache.org>.
Github user ilgrosso commented on the issue:
https://github.com/apache/syncope/pull/74
Thanks @DimaAy for your changes, they look fine!
Just squash your 3 commits into 1 and I'll gladly merge this PR, thanks.
---
[GitHub] syncope pull request #74: [SYNCOPE-1270] implementation for OpenID Connect f...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/syncope/pull/74
---
[GitHub] syncope issue #74: [SYNCOPE-1270] implementation for OpenID Connect for Admi...
Posted by ilgrosso <gi...@git.apache.org>.
Github user ilgrosso commented on the issue:
https://github.com/apache/syncope/pull/74
Other things for Admin Console: adjust modal window title to match the actual name:
---