You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2021/08/16 12:40:43 UTC
[GitHub] [lucene] msokolov opened a new pull request #243: LUCENE-8638: remove deprecated code
msokolov opened a new pull request #243:
URL: https://github.com/apache/lucene/pull/243
This includes the commits from the `lucene-solr/master-deprecations` branch that merged cleanly. I also made a start at fixing some uninteresting deprecation warnings by either fixing or suppressing.
I don't know the history here - I know there was some previous discussion, butI didn't follow it closely. However, these changes are pretty straightforward, except possibly the one that changes the `haversin` expression function to return meters instead of km. That could be confusing for users, and if we merge this as-is, definitely merits some mention in CHANGES, which I haven't added here. Do we have a policy for deprecating and/or changing expression functions? Otherwise - how important is the haversin function change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] msokolov commented on pull request #243: LUCENE-8638: remove deprecated code
Posted by GitBox <gi...@apache.org>.
msokolov commented on pull request #243:
URL: https://github.com/apache/lucene/pull/243#issuecomment-900422588
OK I added the haversin() change to CHANGES.txt. I also removed the fixes relating to TermVector refactoring that may be controversial. I'll push this soon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] msokolov merged pull request #243: LUCENE-8638: remove deprecated code
Posted by GitBox <gi...@apache.org>.
msokolov merged pull request #243:
URL: https://github.com/apache/lucene/pull/243
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] msokolov commented on pull request #243: LUCENE-8638: remove deprecated code
Posted by GitBox <gi...@apache.org>.
msokolov commented on pull request #243:
URL: https://github.com/apache/lucene/pull/243#issuecomment-900422588
OK I added the haversin() change to CHANGES.txt. I also removed the fixes relating to TermVector refactoring that may be controversial. I'll push this soon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] msokolov merged pull request #243: LUCENE-8638: remove deprecated code
Posted by GitBox <gi...@apache.org>.
msokolov merged pull request #243:
URL: https://github.com/apache/lucene/pull/243
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org