[GitHub] [geode] ringles commented on a diff in pull request #7558: GEODE-10157: Add Radish Delta Unit Tests

[GitBox <gi...@apache.org>]

ringles commented on code in PR #7558:
URL: https://github.com/apache/geode/pull/7558#discussion_r846557991


##########
geode-for-redis/src/test/java/org/apache/geode/redis/internal/data/delta/SetTimestampDeltaUnitTest.java:
##########
@@ -23,18 +23,19 @@
 import java.io.DataOutputStream;
 
 import org.junit.Test;
+import org.junit.runner.RunWith;
 
-import org.apache.geode.redis.internal.data.delta.ReplaceByteArrayAtOffset;
-
-public class DeltaClassesJUnitTest {
+import org.apache.geode.redis.internal.data.RedisString;
+import org.apache.geode.test.junit.runners.GeodeParamsRunner;
 
+@RunWith(GeodeParamsRunner.class)
+public class SetTimestampDeltaUnitTest {
   @Test
-  public void testReplaceByteArrayAtOffsetForRedisString() throws Exception {
+  public void testSetTimestampDelta() throws Exception {

Review Comment:
   Since the actual code is in AbstractRedisData, which they all inherit from, I didn't think it necessary. Are we worried about someone overriding it?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org