[GitHub] [lucene] uschindler edited a comment on pull request #592: LUCENE-10366: Reduce the number of valid checks for ByteBufferIndexInput#readVInt

[GitBox <gi...@apache.org>]

uschindler edited a comment on pull request #592:
URL: https://github.com/apache/lucene/pull/592#issuecomment-1009767556


   The problem here is that we just reducing the number of guard checks and at same time raising the risk to segv: ReadVint uses multiple atomic reads and all of those reads can segv.
   
   Sorry to tell this: I would not change anything here, it is too risky. Let's wait for MemorySegmentIndexInput, which has JVM internal checks and a guard is not needed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org