You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/10/05 18:32:41 UTC
[GitHub] [tvm] hogepodge opened a new pull request #9203: Documentation Refactor
hogepodge opened a new pull request #9203:
URL: https://github.com/apache/tvm/pull/9203
RFC: https://github.com/apache/tvm-rfcs/blob/main/rfcs/0027-formalize-documentation-organization.md
Tracking Issue: #8987
Stage 1 of the documentation refactor reorganizes the docs structure,
moving files (without content changes) and adding new scaffolding to
generate the proper document tree.
It does not address naming, style, content, links, or other existing
content in documents that were moved. State 2 will address fixing these
issues with existing content.
Major changes include but are not limited to:
* Dividing the existing tutorials into two sections:
* Tutorials
* How Tos
* Moving all of the existing tutorials out of the `/tutorial`
directory and into the more general `/gallery` directory.
* Breaking up how-tos into individual sections for more
flexibility and more consistent rendering.
* Moving content into new classifications:
* `/docs/arch` for architecture guides
* `/docs/reference` for API guides and other reference material
* `/docs/topic` for topic specific guides such as microTVM and VTA
* Restructuring `/docs/dev`
* Adding a table of contents to the doc index
* Adding instructions on how to install using third-party tlcpack
Stage 2 of the documentation refactor fixes naming and links
in the documentation to be consistent with the overall structure.
Major changes include:
* an update to how to contribute to docs.
* several updated index pages with title changes to match
the organization style and bring consistency to the sections
* expanded descriptions of some page collections
* fixed links
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tqchen commented on pull request #9203: Documentation Refactor
Posted by GitBox <gi...@apache.org>.
tqchen commented on pull request #9203:
URL: https://github.com/apache/tvm/pull/9203#issuecomment-936327280
The remaining error seems was due to tvm not being available in some of the how to example executions. It might be helpful to run the following command to quickly check a specific tutorial to debug
```
TVM_TUTORIAL_EXEC_PATTERN=/path/to/specific_file\.py make html
```
It could be related to the staging setup, the way we setup env variables (cc @Lunderberg to see if you have any ideas).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tmoreau89 commented on pull request #9203: Documentation Refactor
Posted by GitBox <gi...@apache.org>.
tmoreau89 commented on pull request #9203:
URL: https://github.com/apache/tvm/pull/9203#issuecomment-935228518
Thank you @hogepodge for this colossal PR and equally colossal effort! These changes will have a hugely positive impact on improving TVM's approachability for the community at large. Thanks for moving the needle in the right direction
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tqchen commented on pull request #9203: Documentation Refactor
Posted by GitBox <gi...@apache.org>.
tqchen commented on pull request #9203:
URL: https://github.com/apache/tvm/pull/9203#issuecomment-938926659
OK, I find sometime to dig a bit deeper into the errors. The problem comes from the way we get tvm_path https://github.com/apache/tvm/blob/main/docs/conf.py#L52 which is relative instead of absolute path.
Sphinx gallery runs the tutorial file from cwd of the file(e.g. it will run on `gallery/how_to/compile_models/`) where the environment variable of tvm_path set to `../../python` produces a mismatch.
A possible way to fix is to add `tvm_path = os.path.abs_path` to https://github.com/apache/tvm/blob/main/docs/conf.py#L54(and I confirm it works)
But given @Lunderberg you wrote this part and left a comment about relative path, would be great to confirm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] hogepodge commented on pull request #9203: Documentation Refactor
Posted by GitBox <gi...@apache.org>.
hogepodge commented on pull request #9203:
URL: https://github.com/apache/tvm/pull/9203#issuecomment-937474438
@Lunderberg I made the suggested changed, but that didn't improve it. After digging into the Sphinx Gallery code a bit more, I don't think the `memory_usage` code is being called. It's disabled by default. Seems like this is going to need some deeper digging. I don't see anything right away that would explain these failures.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] hogepodge commented on pull request #9203: Documentation Refactor
Posted by GitBox <gi...@apache.org>.
hogepodge commented on pull request #9203:
URL: https://github.com/apache/tvm/pull/9203#issuecomment-936731711
@Lunderberg trying that out, it makes sense. In my local dev environment I actually install TVM to a user python package, which may explain why I'm not seeing the local failures.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] hogepodge commented on pull request #9203: Documentation Refactor
Posted by GitBox <gi...@apache.org>.
hogepodge commented on pull request #9203:
URL: https://github.com/apache/tvm/pull/9203#issuecomment-937474438
@Lunderberg I made the suggested changed, but that didn't improve it. After digging into the Sphinx Gallery code a bit more, I don't think the `memory_usage` code is being called. It's disabled by default. Seems like this is going to need some deeper digging. I don't see anything right away that would explain these failures.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] hogepodge commented on pull request #9203: Documentation Refactor
Posted by GitBox <gi...@apache.org>.
hogepodge commented on pull request #9203:
URL: https://github.com/apache/tvm/pull/9203#issuecomment-936558235
I just pushed a new change to see if we can reproduce the same failures in CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] hogepodge commented on pull request #9203: Documentation Refactor
Posted by GitBox <gi...@apache.org>.
hogepodge commented on pull request #9203:
URL: https://github.com/apache/tvm/pull/9203#issuecomment-938781264
The number of failures for this PR was more widely spread across a number of tutorials, and manifested as not being able import python modules and associated libraries. It seems like sphinx-gallery is brittle and has a global python state that is easily corrupted, and I'm wondering if my reordering of the how-tos is causing failures based on those changes. Your patch fixed an instance of that, but my worry is that there are more problems like that lurking. Hopefully I'm wrong about that though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tqchen merged pull request #9203: Documentation Refactor
Posted by GitBox <gi...@apache.org>.
tqchen merged pull request #9203:
URL: https://github.com/apache/tvm/pull/9203
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] hogepodge commented on pull request #9203: Documentation Refactor
Posted by GitBox <gi...@apache.org>.
hogepodge commented on pull request #9203:
URL: https://github.com/apache/tvm/pull/9203#issuecomment-939114474
@Lunderberg I just came to the same conclusion, and addressed it by making a `tvm_path_rel` variable to use in the Sphinx Gallery `ExplicitOrder`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tqchen edited a comment on pull request #9203: Documentation Refactor
Posted by GitBox <gi...@apache.org>.
tqchen edited a comment on pull request #9203:
URL: https://github.com/apache/tvm/pull/9203#issuecomment-938926659
OK, I find sometime to dig a bit deeper into the errors. The problem comes from the way we get tvm_path https://github.com/apache/tvm/blob/main/docs/conf.py#L52 which is relative instead of absolute path.
Sphinx gallery runs the tutorial file from cwd of the file(e.g. it will run on `gallery/how_to/compile_models/`) where the environment variable of tvm_path set to `../../python` produces a mismatch.
A possible way to fix is to add `tvm_path = os.path.abs_path(tvm_path)` to https://github.com/apache/tvm/blob/main/docs/conf.py#L54(and I confirm it works)
But given @Lunderberg you wrote this part and left a comment about relative path, would be great to confirm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] hogepodge commented on pull request #9203: Documentation Refactor
Posted by GitBox <gi...@apache.org>.
hogepodge commented on pull request #9203:
URL: https://github.com/apache/tvm/pull/9203#issuecomment-936987788
Fixed linting error in conf.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] manupa-arm commented on pull request #9203: Documentation Refactor
Posted by GitBox <gi...@apache.org>.
manupa-arm commented on pull request #9203:
URL: https://github.com/apache/tvm/pull/9203#issuecomment-936679180
Is this related : https://ci.tlcpack.ai/blue/organizations/jenkins/tvm/detail/PR-9168/8/pipeline ? (cc: @Mousius )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tqchen edited a comment on pull request #9203: Documentation Refactor
Posted by GitBox <gi...@apache.org>.
tqchen edited a comment on pull request #9203:
URL: https://github.com/apache/tvm/pull/9203#issuecomment-935201352
Thanks Chris, the overall structure looks good and thanks for the effort in preserving the contribution history.
Looks like we still need to update the CI script in order to get the things to unblock the ci
See related lines here
- https://github.com/apache/tvm/blob/main/tests/scripts/task_python_docs.sh#L42
- https://github.com/apache/tvm/blob/main/tests/scripts/task_sphinx_precheck.sh#L30
Likely we need to update these to the new folder locations, and in the case of `ci_logs`, update them to match the new location of auto_scheduler(should be `gallery/how_to/tune_with_autoscheduler`?). Please let me know if you need additonal help.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] hogepodge commented on a change in pull request #9203: Documentation Refactor
Posted by GitBox <gi...@apache.org>.
hogepodge commented on a change in pull request #9203:
URL: https://github.com/apache/tvm/pull/9203#discussion_r725550704
##########
File path: docs/conf.py
##########
@@ -51,10 +51,11 @@
else:
tvm_path = Path(os.pardir)
-
sys.path.insert(0, str(tvm_path / "python"))
sys.path.insert(0, str(tvm_path / "vta" / "python"))
+os.environ["PYTHONPATH"] = os.pathsep.join(sys.path)
Review comment:
Removed line
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] areusch commented on a change in pull request #9203: Documentation Refactor
Posted by GitBox <gi...@apache.org>.
areusch commented on a change in pull request #9203:
URL: https://github.com/apache/tvm/pull/9203#discussion_r725169694
##########
File path: cmake/config.cmake
##########
@@ -85,7 +85,7 @@ set(USE_VULKAN OFF)
set(USE_OPENGL OFF)
# Whether enable MicroTVM runtime
-set(USE_MICRO OFF)
+set(USE_MICRO ON)
Review comment:
by default we leave everything off. could you say why you want to default them on?
##########
File path: docs/conf.py
##########
@@ -51,10 +51,11 @@
else:
tvm_path = Path(os.pardir)
-
sys.path.insert(0, str(tvm_path / "python"))
sys.path.insert(0, str(tvm_path / "vta" / "python"))
+os.environ["PYTHONPATH"] = os.pathsep.join(sys.path)
Review comment:
i think this might be causing the CI issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tqchen commented on pull request #9203: Documentation Refactor
Posted by GitBox <gi...@apache.org>.
tqchen commented on pull request #9203:
URL: https://github.com/apache/tvm/pull/9203#issuecomment-939377852
Thanks @hogepodge @Lunderberg @areusch . All the comments are resolved.
I am merging this in given that this is a refactor that could conflict/block future changes and would benefit from prioritization. Let us send followup PRs for future tweaks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tqchen edited a comment on pull request #9203: Documentation Refactor
Posted by GitBox <gi...@apache.org>.
tqchen edited a comment on pull request #9203:
URL: https://github.com/apache/tvm/pull/9203#issuecomment-939377852
Thanks @hogepodge @Lunderberg @areusch . All the comments are resolved.
I am merging this in during weekend given that this is a refactor that could conflict/block future changes and would benefit from prioritization. Let us send followup PRs for future tweaks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] mbs-octoml commented on pull request #9203: Documentation Refactor
Posted by GitBox <gi...@apache.org>.
mbs-octoml commented on pull request #9203:
URL: https://github.com/apache/tvm/pull/9203#issuecomment-938749942
That was my bad and the fix #9227 is merged. Why it showed up now and not
during CI for #8788 is a mystery.
On Wed, Oct 6, 2021 at 11:04 PM Manupa Karunaratne ***@***.***>
wrote:
> @hogepodge <https://github.com/hogepodge> , I've just experienced another
> failure. I remember we had an issue which got resolved by @mbs-octoml
> <https://github.com/mbs-octoml> PR, IIRC. Do we need to re-open that or
> create a new one as I dont immediately see this issue is relevant to the
> failure.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/tvm/pull/9203#issuecomment-937476927>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AUYORLF5IOU4ZJTU3UF5KYTUFUZ5PANCNFSM5FMKRM2A>
> .
> Triage notifications on the go with GitHub Mobile for iOS
> <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
> or Android
> <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
>
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] hogepodge commented on a change in pull request #9203: Documentation Refactor
Posted by GitBox <gi...@apache.org>.
hogepodge commented on a change in pull request #9203:
URL: https://github.com/apache/tvm/pull/9203#discussion_r725268713
##########
File path: cmake/config.cmake
##########
@@ -85,7 +85,7 @@ set(USE_VULKAN OFF)
set(USE_OPENGL OFF)
# Whether enable MicroTVM runtime
-set(USE_MICRO OFF)
+set(USE_MICRO ON)
Review comment:
I need to revert this. I was making (incorrect) changes to my local build environment and inadvertently committed this. Thanks for catching.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Lunderberg commented on pull request #9203: Documentation Refactor
Posted by GitBox <gi...@apache.org>.
Lunderberg commented on pull request #9203:
URL: https://github.com/apache/tvm/pull/9203#issuecomment-936676542
Hmm. It looks like it's having trouble finding the `libtvm.so` file, but it finds it correctly during the initial import. From a quick 10-minute code dive, it looks like `sphinx_gallery` calls [`memory_profiler.memory_usage`](https://github.com/pythonprofilers/memory_profiler/blob/master/memory_profiler.py#L267). This starts a subprocess, which doesn't inherit the `sys.path` updates made in [our `conf.py`](https://github.com/hogepodge/tvm/blob/docs-refactor-respin/docs/conf.py#L55).
Can you try adding `os.environ['PYTHONPATH'] = os.pathsep.join(sys.path)` to the `conf.py`, just after the modifications to `sys.path`? The environment variable should be passed to subprocesses, where the value of `sys.path` is not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tqchen commented on a change in pull request #9203: Documentation Refactor
Posted by GitBox <gi...@apache.org>.
tqchen commented on a change in pull request #9203:
URL: https://github.com/apache/tvm/pull/9203#discussion_r725171410
##########
File path: cmake/config.cmake
##########
@@ -258,7 +258,7 @@ set(USE_ANTLR OFF)
set(USE_RELAY_DEBUG OFF)
# Whether to build fast VTA simulator driver
-set(USE_VTA_FSIM OFF)
+set(USE_VTA_FSIM ON)
Review comment:
The default cmake should not affect the outcome and better kept as it is. We do configure them(override) properly in CI setup so there is no need to change here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] manupa-arm commented on pull request #9203: Documentation Refactor
Posted by GitBox <gi...@apache.org>.
manupa-arm commented on pull request #9203:
URL: https://github.com/apache/tvm/pull/9203#issuecomment-937476927
@hogepodge , I've just experienced another failure. I remember we had an issue which got resolved by @mbs-octoml PR, IIRC. Do we need to re-open that or create a new one as I dont immediately see this issue is relevant to the failure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] manupa-arm commented on pull request #9203: Documentation Refactor
Posted by GitBox <gi...@apache.org>.
manupa-arm commented on pull request #9203:
URL: https://github.com/apache/tvm/pull/9203#issuecomment-937476927
@hogepodge , I've just experienced another failure. I remember we had an issue which got resolved by @mbs-octoml PR, IIRC. Do we need to re-open that or create a new one as I dont immediately see this issue is relevant to the failure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tqchen edited a comment on pull request #9203: Documentation Refactor
Posted by GitBox <gi...@apache.org>.
tqchen edited a comment on pull request #9203:
URL: https://github.com/apache/tvm/pull/9203#issuecomment-935201352
Thanks Chris, the overall structure looks good and thanks for the effort in preserving the contribution history.
Looks like we still need to update the CI script in order to get the things to unblock the ci
See related folder here
- https://github.com/apache/tvm/blob/main/tests/scripts/task_python_docs.sh#L42
- https://github.com/apache/tvm/blob/main/tests/scripts/task_sphinx_precheck.sh#L30
Likely we need to update these to the new folder locations, and in the case of `ci_logs`, copy them over.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] hogepodge commented on a change in pull request #9203: Documentation Refactor
Posted by GitBox <gi...@apache.org>.
hogepodge commented on a change in pull request #9203:
URL: https://github.com/apache/tvm/pull/9203#discussion_r725267860
##########
File path: cmake/config.cmake
##########
@@ -258,7 +258,7 @@ set(USE_ANTLR OFF)
set(USE_RELAY_DEBUG OFF)
# Whether to build fast VTA simulator driver
-set(USE_VTA_FSIM OFF)
+set(USE_VTA_FSIM ON)
Review comment:
Thanks for catching this. This was a error in reconfiguring my local environment. Will revert it back.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] hogepodge commented on pull request #9203: Documentation Refactor
Posted by GitBox <gi...@apache.org>.
hogepodge commented on pull request #9203:
URL: https://github.com/apache/tvm/pull/9203#issuecomment-938751191
I'm not convinced this is going to fix the underlying problem, but we'll see where we are in a few hours.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Lunderberg commented on a change in pull request #9203: Documentation Refactor
Posted by GitBox <gi...@apache.org>.
Lunderberg commented on a change in pull request #9203:
URL: https://github.com/apache/tvm/pull/9203#discussion_r725255992
##########
File path: docs/conf.py
##########
@@ -51,10 +51,11 @@
else:
tvm_path = Path(os.pardir)
-
sys.path.insert(0, str(tvm_path / "python"))
sys.path.insert(0, str(tvm_path / "vta" / "python"))
+os.environ["PYTHONPATH"] = os.pathsep.join(sys.path)
Review comment:
This one was an earlier attempt to fix the issue (https://github.com/apache/tvm/pull/9203#issuecomment-936676542). The changes to `sys.path` were to make sure that `$TVM_HOME/python` is locatable, even if the cwd is within the new `_staging` directory. The updates to `PYTHONPATH` were to mirror that to subprocesses, since that appeared to be where the issue was. After testing, that ended up not being the issue after all.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tqchen edited a comment on pull request #9203: Documentation Refactor
Posted by GitBox <gi...@apache.org>.
tqchen edited a comment on pull request #9203:
URL: https://github.com/apache/tvm/pull/9203#issuecomment-939377852
Thanks @hogepodge @Lunderberg @areusch . All the comments are resolved.
I am merging this in given that this is a major refactor could conflict/block future changes and would benefit from prioritization. Let us send followup PRs for future tweaks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] hogepodge commented on pull request #9203: Documentation Refactor
Posted by GitBox <gi...@apache.org>.
hogepodge commented on pull request #9203:
URL: https://github.com/apache/tvm/pull/9203#issuecomment-935294581
> Thanks Chris, the overall structure looks good and thanks for the effort in preserving the contribution history. Looks like we still need to update the CI script in order to get the things to unblock the ci
>
> See related lines here
>
> * https://github.com/apache/tvm/blob/main/tests/scripts/task_python_docs.sh#L42
> * https://github.com/apache/tvm/blob/main/tests/scripts/task_sphinx_precheck.sh#L30
>
> Likely we need to update these to the new folder locations, and in the case of `ci_logs`, update them to match the new location of auto_scheduler(should be `gallery/how_to/tune_with_autoscheduler`?). Please let me know if you need additonal help.
Thanks! I've updated the scripts. A little while ago @Lunderberg changed the build structure to use both a `_staging` and a `_build` directory. I've updated the scripts to see the new locations and to only remove those directories (as the main tree is not being written in to any more).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] denise-k commented on pull request #9203: Documentation Refactor
Posted by GitBox <gi...@apache.org>.
denise-k commented on pull request #9203:
URL: https://github.com/apache/tvm/pull/9203#issuecomment-935244814
Huge, huge thanks to @hogepodge for spending so much time and energy to make our documentation shine! :sparkles:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] hogepodge commented on pull request #9203: Documentation Refactor
Posted by GitBox <gi...@apache.org>.
hogepodge commented on pull request #9203:
URL: https://github.com/apache/tvm/pull/9203#issuecomment-934906364
Addressed missing links and references in documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] hogepodge commented on pull request #9203: Documentation Refactor
Posted by GitBox <gi...@apache.org>.
hogepodge commented on pull request #9203:
URL: https://github.com/apache/tvm/pull/9203#issuecomment-936689809
@manupa-arm looks like the same issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] mbs-octoml commented on pull request #9203: Documentation Refactor
Posted by GitBox <gi...@apache.org>.
mbs-octoml commented on pull request #9203:
URL: https://github.com/apache/tvm/pull/9203#issuecomment-938759434
What is the underlying problem?
On Fri, Oct 8, 2021 at 8:56 AM Chris Hoge ***@***.***> wrote:
> I'm not convinced this is going to fix the underlying problem, but we'll
> see where we are in a few hours.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/tvm/pull/9203#issuecomment-938751191>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AUYORLEXMNYFI4QRJGG7XI3UF4IEPANCNFSM5FMKRM2A>
> .
> Triage notifications on the go with GitHub Mobile for iOS
> <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
> or Android
> <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
>
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Lunderberg commented on pull request #9203: Documentation Refactor
Posted by GitBox <gi...@apache.org>.
Lunderberg commented on pull request #9203:
URL: https://github.com/apache/tvm/pull/9203#issuecomment-939106017
The issue was that `ExplicitOrder` requires relative paths, and `tvm_path` is currently used to generate the arguments for `ExplcitOrder`. (I had to verify to remind myself why. The implementation of `ExplicitOrder` expects the string representation of the paths [to be an exact match](https://github.com/sphinx-gallery/sphinx-gallery/blob/master/sphinx_gallery/sorting.py#L49) for the path being used. It gets passed the path relative to the [source directory](https://github.com/sphinx-gallery/sphinx-gallery/blob/master/sphinx_gallery/gen_gallery.py#L381), and so that's what we need to give it.) If I remember correctly, I think the failure mode was generating URLs that included the full path to the file, including `/home/Lunderberg`.
The path being added to `sys.path` doesn't need to be a relative path, so we could change `tvm_path` to `tvm_path.resolve()` on those two lines.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tqchen commented on pull request #9203: Documentation Refactor
Posted by GitBox <gi...@apache.org>.
tqchen commented on pull request #9203:
URL: https://github.com/apache/tvm/pull/9203#issuecomment-935218558
BTW, I wanted to acknowledge and thank you for all the effort you have put into the documentation. Having strong user and developer documentation is critical to TVM’s mission to provide unity to the ML Acceleration ecosystem,and the entire community stands to benefit from better documentation.
The overall direction of documentation changes looks great and layed out clearly in the RFC. Sorry for the final nit-picks but this are the final steps toward closing the loop of our documentation refactor effort. Lets work together to land this and please let us know what we can do to help.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] hogepodge commented on pull request #9203: Documentation Refactor
Posted by GitBox <gi...@apache.org>.
hogepodge commented on pull request #9203:
URL: https://github.com/apache/tvm/pull/9203#issuecomment-936534481
Thanks for the suggestion on that. Whether I'm building the entire document set, or just the individual how_tos that are failing in CI, I'm unable to reproduce the failures locally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tqchen edited a comment on pull request #9203: Documentation Refactor
Posted by GitBox <gi...@apache.org>.
tqchen edited a comment on pull request #9203:
URL: https://github.com/apache/tvm/pull/9203#issuecomment-935218558
BTW, I wanted to acknowledge and thank you for all the effort you have put into the documentation. Having strong user and developer documentation is critical to TVM’s mission to provide unity to the ML Acceleration ecosystem,and the entire community stands to benefit from better documentation.
The overall direction of documentation changes looks great and layed out clearly in the RFC. Sorry for the final requests but these are the final steps toward closing the loop of our documentation refactor effort. Let's work together to land this and please let us know what we can do to help.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tqchen commented on pull request #9203: Documentation Refactor
Posted by GitBox <gi...@apache.org>.
tqchen commented on pull request #9203:
URL: https://github.com/apache/tvm/pull/9203#issuecomment-935201352
Thanks Chris, the overall structure looks good and thanks for the effort in preserving the contribution history.
Looks like we still need to update the CI script in order to get the things into a ready state.
See related folder here
- https://github.com/apache/tvm/blob/main/tests/scripts/task_python_docs.sh#L42
- https://github.com/apache/tvm/blob/main/tests/scripts/task_sphinx_precheck.sh#L30
Likely we need to update these to the new folder locations, and in the case of `ci_logs`, copy them over.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org