[GitHub] spark pull request #13176: [SPARK-15100][DOC] Modified user guide and exampl...

[MLnick <gi...@git.apache.org>]

Github user MLnick commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13176#discussion_r65634025
  
    --- Diff: examples/src/main/scala/org/apache/spark/examples/ml/QuantileDiscretizerExample.scala ---
    @@ -38,6 +38,7 @@ object QuantileDiscretizerExample {
           .setInputCol("hour")
           .setOutputCol("result")
           .setNumBuckets(3)
    +      .setRelativeError(0)
    --- End diff --
    
    If we do this here, then I think we should be explicit about the fact that we're computing exact quantiles for illustrative purposes.
    
    Something like 
    ```
    .setRelativeError(0) // note that we compute exact quantiles here for illustrative purposes, however in most cases the default parameter value should suffice 
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org