You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Martin Rust (JIRA)" <ji...@apache.org> on 2012/11/22 09:50:59 UTC
[jira] [Created] (CODEC-163) ColognePhonetic encoder unneccessarily
creates lots of char arrays on every loop run
Martin Rust created CODEC-163:
---------------------------------
Summary: ColognePhonetic encoder unneccessarily creates lots of char arrays on every loop run
Key: CODEC-163
URL: https://issues.apache.org/jira/browse/CODEC-163
Project: Commons Codec
Issue Type: Improvement
Reporter: Martin Rust
Priority: Minor
The summary says it all.
I've created a patch and will attach it.
I've benchmarked a 10% performance improvement. Admittedly, I expected more, but other positive effects should be less strain on heap and GC.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (CODEC-163) ColognePhonetic encoder
unneccessarily creates many char arrays on every loop run
Posted by "Gary Gregory (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CODEC-163?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gary Gregory resolved CODEC-163.
--------------------------------
Resolution: Fixed
Fix Version/s: 1.8
{noformat}
commit -m "<action dev="ggregory" type="fix" issue="CODEC-163" due-to="leo141">ColognePhonetic encoder unneccessarily creates many char arrays on every loop run.</action>" C:/svn/org/apache/commons/trunks-proper/codec/src/changes/changes.xml C:/svn/org/apache/commons/trunks-proper/codec/src/main/java/org/apache/commons/codec/language/ColognePhonetic.java
Sending C:/svn/org/apache/commons/trunks-proper/codec/src/changes/changes.xml
Sending C:/svn/org/apache/commons/trunks-proper/codec/src/main/java/org/apache/commons/codec/language/ColognePhonetic.java
Transmitting file data ...
Committed revision 1412589.
{noformat}
> ColognePhonetic encoder unneccessarily creates many char arrays on every loop run
> ---------------------------------------------------------------------------------
>
> Key: CODEC-163
> URL: https://issues.apache.org/jira/browse/CODEC-163
> Project: Commons Codec
> Issue Type: Improvement
> Reporter: Martin Rust
> Priority: Minor
> Labels: performance
> Fix For: 1.8
>
> Attachments: patch-CODEC-163
>
>
> The summary says it all.
> I've created a patch and have attached it.
> I've benchmarked a 10% performance improvement. Admittedly, I expected more, but other positive effects should be less strain on heap and GC.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CODEC-163) ColognePhonetic encoder
unneccessarily creates lots of char arrays on every loop run
Posted by "Sebb (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CODEC-163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13502699#comment-13502699 ]
Sebb commented on CODEC-163:
----------------------------
BTW, if you provide further patches to JIRA, please name them .patch or .txt (e.g. CODEC-163.patch) as that allows JIRA to display them as text to browsers. Otherwise one has to download the file in order to open it in a text editor. Thanks.
> ColognePhonetic encoder unneccessarily creates lots of char arrays on every loop run
> ------------------------------------------------------------------------------------
>
> Key: CODEC-163
> URL: https://issues.apache.org/jira/browse/CODEC-163
> Project: Commons Codec
> Issue Type: Improvement
> Reporter: Martin Rust
> Priority: Minor
> Labels: performance
> Attachments: patch-CODEC-163
>
>
> The summary says it all.
> I've created a patch and have attached it.
> I've benchmarked a 10% performance improvement. Admittedly, I expected more, but other positive effects should be less strain on heap and GC.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CODEC-163) ColognePhonetic encoder unneccessarily
creates lots of char arrays on every loop run
Posted by "Martin Rust (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CODEC-163?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Rust updated CODEC-163:
------------------------------
Description:
The summary says it all.
I've created a patch and have attached it.
I've benchmarked a 10% performance improvement. Admittedly, I expected more, but other positive effects should be less strain on heap and GC.
was:
The summary says it all.
I've created a patch and will attach it.
I've benchmarked a 10% performance improvement. Admittedly, I expected more, but other positive effects should be less strain on heap and GC.
> ColognePhonetic encoder unneccessarily creates lots of char arrays on every loop run
> ------------------------------------------------------------------------------------
>
> Key: CODEC-163
> URL: https://issues.apache.org/jira/browse/CODEC-163
> Project: Commons Codec
> Issue Type: Improvement
> Reporter: Martin Rust
> Priority: Minor
> Labels: performance
> Attachments: patch-CODEC-163
>
>
> The summary says it all.
> I've created a patch and have attached it.
> I've benchmarked a 10% performance improvement. Admittedly, I expected more, but other positive effects should be less strain on heap and GC.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CODEC-163) ColognePhonetic encoder
unneccessarily creates lots of char arrays on every loop run
Posted by "Martin Rust (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CODEC-163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13502705#comment-13502705 ]
Martin Rust commented on CODEC-163:
-----------------------------------
Am 22.11.2012 um 11:34 schrieb Sebb (JIRA):
[ https://issues.apache.org/jira/browse/CODEC-163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13502699#comment-13502699 ]
Sebb commented on CODEC-163:
----------------------------
BTW, if you provide further patches to JIRA, please name them .patch or .txt (e.g. CODEC-163.patch) as that allows JIRA to display them as text to browsers. Otherwise one has to download the file in order to open it in a text editor. Thanks.
OK, thanks, I will.
I followed the advice on http://commons.apache.org/patches.html, so you might consider mentioning this fact there ;) ;)
Martin
ColognePhonetic encoder unneccessarily creates lots of char arrays on every loop run
------------------------------------------------------------------------------------
Key: CODEC-163
URL: https://issues.apache.org/jira/browse/CODEC-163
Project: Commons Codec
Issue Type: Improvement
Reporter: Martin Rust
Priority: Minor
Labels: performance
Attachments: patch-CODEC-163
The summary says it all.
I've created a patch and have attached it.
I've benchmarked a 10% performance improvement. Admittedly, I expected more, but other positive effects should be less strain on heap and GC.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
> ColognePhonetic encoder unneccessarily creates lots of char arrays on every loop run
> ------------------------------------------------------------------------------------
>
> Key: CODEC-163
> URL: https://issues.apache.org/jira/browse/CODEC-163
> Project: Commons Codec
> Issue Type: Improvement
> Reporter: Martin Rust
> Priority: Minor
> Labels: performance
> Attachments: patch-CODEC-163
>
>
> The summary says it all.
> I've created a patch and have attached it.
> I've benchmarked a 10% performance improvement. Admittedly, I expected more, but other positive effects should be less strain on heap and GC.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CODEC-163) ColognePhonetic encoder unneccessarily
creates lots of char arrays on every loop run
Posted by "Martin Rust (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CODEC-163?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Rust updated CODEC-163:
------------------------------
Attachment: patch-CODEC-163
Patch for this issude
> ColognePhonetic encoder unneccessarily creates lots of char arrays on every loop run
> ------------------------------------------------------------------------------------
>
> Key: CODEC-163
> URL: https://issues.apache.org/jira/browse/CODEC-163
> Project: Commons Codec
> Issue Type: Improvement
> Reporter: Martin Rust
> Priority: Minor
> Labels: performance
> Attachments: patch-CODEC-163
>
>
> The summary says it all.
> I've created a patch and will attach it.
> I've benchmarked a 10% performance improvement. Admittedly, I expected more, but other positive effects should be less strain on heap and GC.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CODEC-163) ColognePhonetic encoder
unneccessarily creates many char arrays on every loop run
Posted by "Gary Gregory (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CODEC-163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13502824#comment-13502824 ]
Gary Gregory commented on CODEC-163:
------------------------------------
Thank you Martin!
Do you see any other improvements?
Do you have data that can improve the test coverage?
Gary
> ColognePhonetic encoder unneccessarily creates many char arrays on every loop run
> ---------------------------------------------------------------------------------
>
> Key: CODEC-163
> URL: https://issues.apache.org/jira/browse/CODEC-163
> Project: Commons Codec
> Issue Type: Improvement
> Reporter: Martin Rust
> Priority: Minor
> Labels: performance
> Fix For: 1.8
>
> Attachments: patch-CODEC-163
>
>
> The summary says it all.
> I've created a patch and have attached it.
> I've benchmarked a 10% performance improvement. Admittedly, I expected more, but other positive effects should be less strain on heap and GC.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CODEC-163) ColognePhonetic encoder unneccessarily
creates many char arrays on every loop run
Posted by "Gary Gregory (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CODEC-163?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gary Gregory updated CODEC-163:
-------------------------------
Summary: ColognePhonetic encoder unneccessarily creates many char arrays on every loop run (was: ColognePhonetic encoder unneccessarily creates lots of char arrays on every loop run)
> ColognePhonetic encoder unneccessarily creates many char arrays on every loop run
> ---------------------------------------------------------------------------------
>
> Key: CODEC-163
> URL: https://issues.apache.org/jira/browse/CODEC-163
> Project: Commons Codec
> Issue Type: Improvement
> Reporter: Martin Rust
> Priority: Minor
> Labels: performance
> Attachments: patch-CODEC-163
>
>
> The summary says it all.
> I've created a patch and have attached it.
> I've benchmarked a 10% performance improvement. Admittedly, I expected more, but other positive effects should be less strain on heap and GC.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Comment Edited] (CODEC-163) ColognePhonetic encoder
unneccessarily creates lots of char arrays on every loop run
Posted by "Martin Rust (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CODEC-163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13502659#comment-13502659 ]
Martin Rust edited comment on CODEC-163 at 11/22/12 8:56 AM:
-------------------------------------------------------------
Patch for this issue
was (Author: leo141):
Patch for this issude
> ColognePhonetic encoder unneccessarily creates lots of char arrays on every loop run
> ------------------------------------------------------------------------------------
>
> Key: CODEC-163
> URL: https://issues.apache.org/jira/browse/CODEC-163
> Project: Commons Codec
> Issue Type: Improvement
> Reporter: Martin Rust
> Priority: Minor
> Labels: performance
> Attachments: patch-CODEC-163
>
>
> The summary says it all.
> I've created a patch and have attached it.
> I've benchmarked a 10% performance improvement. Admittedly, I expected more, but other positive effects should be less strain on heap and GC.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira