You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/02/17 12:11:26 UTC

[GitHub] [arrow-datafusion] thinkharderdev commented on a change in pull request #1677: Abstract over logical and physical plan representations in Ballista

thinkharderdev commented on a change in pull request #1677:
URL: https://github.com/apache/arrow-datafusion/pull/1677#discussion_r808982243



##########
File path: ballista/rust/scheduler/src/lib.rs
##########
@@ -722,33 +765,38 @@ impl SchedulerGrpc for SchedulerServer {
     ) -> std::result::Result<Response<ExecuteQueryResult>, tonic::Status> {
         if let ExecuteQueryParams {
             query: Some(query),
-            settings,
+            settings: _,
         } = request.into_inner()
         {
             // parse config
-            let mut config_builder = BallistaConfig::builder();
-            for kv_pair in &settings {
-                config_builder = config_builder.set(&kv_pair.key, &kv_pair.value);
-            }
-            let config = config_builder.build().map_err(|e| {
-                let msg = format!("Could not parse configs: {}", e);
-                error!("{}", msg);
-                tonic::Status::internal(msg)
-            })?;
+            // let mut config_builder = BallistaConfig::builder();
+            // for kv_pair in &settings {
+            //     config_builder = config_builder.set(&kv_pair.key, &kv_pair.value);
+            // }
+            // let config = config_builder.build().map_err(|e| {
+            //     let msg = format!("Could not parse configs: {}", e);
+            //     error!("{}", msg);
+            //     tonic::Status::internal(msg)
+            // })?;
 
             let plan = match query {
-                Query::LogicalPlan(logical_plan) => {
+                Query::LogicalPlan(message) => {
                     // parse protobuf
-                    (&logical_plan).try_into().map_err(|e| {
-                        let msg = format!("Could not parse logical plan protobuf: {}", e);
-                        error!("{}", msg);
-                        tonic::Status::internal(msg)
-                    })?
+                    // let ctx = create_datafusion_context(&config);

Review comment:
       This was an oversight. I did not think these settings were actually used anywhere but was not accounting for the SQL case. Discussing fixes on https://github.com/apache/arrow-datafusion/issues/1848




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org