[GitHub] [superset] kasiazjc commented on pull request #19794: feat(explore): Rearrange controls in most popular charts

[GitBox <gi...@apache.org>]

kasiazjc commented on PR #19794:
URL: https://github.com/apache/superset/pull/19794#issuecomment-1104849409

   > A few thoughts:
   > 
   > - I've probably raised this many times before, but I'll do it once more, just in case 😆  The title "Chart" (instead of "Query") could be seen as slightly ambiguous, as everything should affect the chart. While I know that "Query" isn't very business user friendly, maybe there's some other term out there that could convey more clearly what these controls are.
   > 
   > - I noticed that Mixed Timeseries isn't included in this PR. Could we update that one, too?
   
   I think we were on the fence on how to name this section... Like "Required"/"Basic", but I don't think it makes sense 🫠 I think for now we can change the name to "query" and adjust later. This section will always be opened as there are all (I think in most cases) required controls, so shouldn't be a problem.
   
   We included only Tier 1 charts, but I guess as Mixed Timerseries is similar we can tackle that one too, @kgabryje? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org