You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Michael McCandless (Commented) (JIRA)" <ji...@apache.org> on 2012/04/10 21:45:13 UTC
[jira] [Commented] (LUCENE-3970) Rename
getUnique[Field/Terms]Count() into size()
[ https://issues.apache.org/jira/browse/LUCENE-3970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13251004#comment-13251004 ]
Michael McCandless commented on LUCENE-3970:
--------------------------------------------
Thanks Iulius, this looks good ... I'll commit shortly.
> Rename getUnique[Field/Terms]Count() into size()
> ------------------------------------------------
>
> Key: LUCENE-3970
> URL: https://issues.apache.org/jira/browse/LUCENE-3970
> Project: Lucene - Java
> Issue Type: Task
> Components: core/index
> Reporter: Iulius Curt
> Assignee: Michael McCandless
> Priority: Minor
> Fix For: 4.0
>
> Attachments: LUCENE-3970.patch
>
>
> Like Robert Muir said in LUCENE-3109:
> {quote}Also I think there are other improvements we can do here that would be more natural:
> Fields.getUniqueFieldCount() -> Fields.size()
> Terms.getUniqueTermCount() -> Terms.size(){quote}
> I believe this dramatically improves understandability (way less 'scary', actually beautiful).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org