You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/01/29 14:59:13 UTC
[GitHub] [flink] gaoyunhaii commented on a change in pull request #14734: [FLINK-21066][runtime][checkpoint] Refactor CheckpointCoordinator to compute tasks to trigger/ack/commit dynamically
gaoyunhaii commented on a change in pull request #14734:
URL: https://github.com/apache/flink/pull/14734#discussion_r566879860
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionGraph.java
##########
@@ -448,14 +441,24 @@ public void failJobDueToTaskFailure(
new DispatcherThreadFactory(
Thread.currentThread().getThreadGroup(), "Checkpoint Timer"));
+ List<ExecutionVertex> sourceVertices = new ArrayList<>();
Review comment:
I'll put it in separate method first so that we do not need to modify too much unit tests for now. In the next PR I'll further move it into `CheckpointBriefCalculator`.
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionGraph.java
##########
@@ -448,14 +441,24 @@ public void failJobDueToTaskFailure(
new DispatcherThreadFactory(
Thread.currentThread().getThreadGroup(), "Checkpoint Timer"));
+ List<ExecutionVertex> sourceVertices = new ArrayList<>();
Review comment:
I'll first put it in separate method first so that we do not need to modify too much unit tests for now. In the next PR I'll further move it into `CheckpointBriefCalculator`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org